[jira] [Work logged] (HIVE-24537) Optimise locking in LlapTaskSchedulerService

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24537?focusedWorklogId=589700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589700 ]

ASF GitHub Bot logged work on HIVE-24537:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/21 12:25
            Start Date: 27/Apr/21 12:25
    Worklog Time Spent: 10m 
      Work Description: pgaref opened a new pull request #2224:
URL: https://github.com/apache/hive/pull/2224


   Change-Id: I91c004a06b35d60d11551c5fa04db7e6ba6f4550
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   Optimise locking in LlapTaskSchedulerService
   
   
   ### Why are the changes needed?
   Perf optimization
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   TestLlapTaskSchedulerService
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 589700)
    Remaining Estimate: 0h
            Time Spent: 10m

> Optimise locking in LlapTaskSchedulerService
> --------------------------------------------
>
>                 Key: HIVE-24537
>                 URL: https://issues.apache.org/jira/browse/HIVE-24537
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Rajesh Balamohan
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>         Attachments: Screenshot 2020-12-15 at 11.41.49 AM.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> 1. Read lock should suffice for "notifyStarted()".
> 2. Locking in "allocateTask()" can be optimised. 
> 3. Optimize preemptTasks() & preemptTasksFromMap(). This would help in reducing the codepath with writeLock. Currently, it iterates through all tasks.
>  
>   !Screenshot 2020-12-15 at 11.41.49 AM.png|width=847,height=446!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)