You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/12/12 14:52:30 UTC

[14/41] hbase-site git commit: Published site at 67d6d5084cf8fc094cda4bd3f091d8a0a9cb1d3e.

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/d702fb71/devapidocs/src-html/org/apache/hadoop/hbase/util/HBaseFsck.MetaEntry.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/util/HBaseFsck.MetaEntry.html b/devapidocs/src-html/org/apache/hadoop/hbase/util/HBaseFsck.MetaEntry.html
index 62f81b6..f6f6104 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/util/HBaseFsck.MetaEntry.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/util/HBaseFsck.MetaEntry.html
@@ -930,7 +930,7 @@
 <span class="sourceLineNo">922</span>            // For all the stores in this column family.<a name="line.922"></a>
 <span class="sourceLineNo">923</span>            for (FileStatus storeFile : storeFiles) {<a name="line.923"></a>
 <span class="sourceLineNo">924</span>              HFile.Reader reader = HFile.createReader(fs, storeFile.getPath(),<a name="line.924"></a>
-<span class="sourceLineNo">925</span>                new CacheConfig(getConf()), true, getConf());<a name="line.925"></a>
+<span class="sourceLineNo">925</span>                CacheConfig.DISABLED, true, getConf());<a name="line.925"></a>
 <span class="sourceLineNo">926</span>              if ((reader.getFirstKey() != null)<a name="line.926"></a>
 <span class="sourceLineNo">927</span>                  &amp;&amp; ((storeFirstKey == null) || (comparator.compare(storeFirstKey,<a name="line.927"></a>
 <span class="sourceLineNo">928</span>                      ((KeyValue.KeyOnlyKeyValue) reader.getFirstKey().get()).getKey()) &gt; 0))) {<a name="line.928"></a>
@@ -1033,4295 +1033,4294 @@
 <span class="sourceLineNo">1025</span>        byte[] start, end;<a name="line.1025"></a>
 <span class="sourceLineNo">1026</span>        HFile.Reader hf = null;<a name="line.1026"></a>
 <span class="sourceLineNo">1027</span>        try {<a name="line.1027"></a>
-<span class="sourceLineNo">1028</span>          CacheConfig cacheConf = new CacheConfig(getConf());<a name="line.1028"></a>
-<span class="sourceLineNo">1029</span>          hf = HFile.createReader(fs, hfile.getPath(), cacheConf, true, getConf());<a name="line.1029"></a>
-<span class="sourceLineNo">1030</span>          hf.loadFileInfo();<a name="line.1030"></a>
-<span class="sourceLineNo">1031</span>          Optional&lt;Cell&gt; startKv = hf.getFirstKey();<a name="line.1031"></a>
-<span class="sourceLineNo">1032</span>          start = CellUtil.cloneRow(startKv.get());<a name="line.1032"></a>
-<span class="sourceLineNo">1033</span>          Optional&lt;Cell&gt; endKv = hf.getLastKey();<a name="line.1033"></a>
-<span class="sourceLineNo">1034</span>          end = CellUtil.cloneRow(endKv.get());<a name="line.1034"></a>
-<span class="sourceLineNo">1035</span>        } catch (IOException ioe) {<a name="line.1035"></a>
-<span class="sourceLineNo">1036</span>          LOG.warn("Problem reading orphan file " + hfile + ", skipping");<a name="line.1036"></a>
-<span class="sourceLineNo">1037</span>          continue;<a name="line.1037"></a>
-<span class="sourceLineNo">1038</span>        } catch (NullPointerException ioe) {<a name="line.1038"></a>
-<span class="sourceLineNo">1039</span>          LOG.warn("Orphan file " + hfile + " is possibly corrupted HFile, skipping");<a name="line.1039"></a>
-<span class="sourceLineNo">1040</span>          continue;<a name="line.1040"></a>
-<span class="sourceLineNo">1041</span>        } finally {<a name="line.1041"></a>
-<span class="sourceLineNo">1042</span>          if (hf != null) {<a name="line.1042"></a>
-<span class="sourceLineNo">1043</span>            hf.close();<a name="line.1043"></a>
-<span class="sourceLineNo">1044</span>          }<a name="line.1044"></a>
-<span class="sourceLineNo">1045</span>        }<a name="line.1045"></a>
-<span class="sourceLineNo">1046</span><a name="line.1046"></a>
-<span class="sourceLineNo">1047</span>        // expand the range to include the range of all hfiles<a name="line.1047"></a>
-<span class="sourceLineNo">1048</span>        if (orphanRegionRange == null) {<a name="line.1048"></a>
-<span class="sourceLineNo">1049</span>          // first range<a name="line.1049"></a>
-<span class="sourceLineNo">1050</span>          orphanRegionRange = new Pair&lt;&gt;(start, end);<a name="line.1050"></a>
-<span class="sourceLineNo">1051</span>        } else {<a name="line.1051"></a>
-<span class="sourceLineNo">1052</span>          // TODO add test<a name="line.1052"></a>
-<span class="sourceLineNo">1053</span><a name="line.1053"></a>
-<span class="sourceLineNo">1054</span>          // expand range only if the hfile is wider.<a name="line.1054"></a>
-<span class="sourceLineNo">1055</span>          if (Bytes.compareTo(orphanRegionRange.getFirst(), start) &gt; 0) {<a name="line.1055"></a>
-<span class="sourceLineNo">1056</span>            orphanRegionRange.setFirst(start);<a name="line.1056"></a>
-<span class="sourceLineNo">1057</span>          }<a name="line.1057"></a>
-<span class="sourceLineNo">1058</span>          if (Bytes.compareTo(orphanRegionRange.getSecond(), end) &lt; 0 ) {<a name="line.1058"></a>
-<span class="sourceLineNo">1059</span>            orphanRegionRange.setSecond(end);<a name="line.1059"></a>
-<span class="sourceLineNo">1060</span>          }<a name="line.1060"></a>
-<span class="sourceLineNo">1061</span>        }<a name="line.1061"></a>
-<span class="sourceLineNo">1062</span>      }<a name="line.1062"></a>
-<span class="sourceLineNo">1063</span>    }<a name="line.1063"></a>
-<span class="sourceLineNo">1064</span>    if (orphanRegionRange == null) {<a name="line.1064"></a>
-<span class="sourceLineNo">1065</span>      LOG.warn("No data in dir " + p + ", sidelining data");<a name="line.1065"></a>
-<span class="sourceLineNo">1066</span>      fixes++;<a name="line.1066"></a>
-<span class="sourceLineNo">1067</span>      sidelineRegionDir(fs, hi);<a name="line.1067"></a>
-<span class="sourceLineNo">1068</span>      return;<a name="line.1068"></a>
-<span class="sourceLineNo">1069</span>    }<a name="line.1069"></a>
-<span class="sourceLineNo">1070</span>    LOG.info("Min max keys are : [" + Bytes.toString(orphanRegionRange.getFirst()) + ", " +<a name="line.1070"></a>
-<span class="sourceLineNo">1071</span>        Bytes.toString(orphanRegionRange.getSecond()) + ")");<a name="line.1071"></a>
-<span class="sourceLineNo">1072</span><a name="line.1072"></a>
-<span class="sourceLineNo">1073</span>    // create new region on hdfs. move data into place.<a name="line.1073"></a>
-<span class="sourceLineNo">1074</span>    RegionInfo regionInfo = RegionInfoBuilder.newBuilder(template.getTableName())<a name="line.1074"></a>
-<span class="sourceLineNo">1075</span>        .setStartKey(orphanRegionRange.getFirst())<a name="line.1075"></a>
-<span class="sourceLineNo">1076</span>        .setEndKey(Bytes.add(orphanRegionRange.getSecond(), new byte[1]))<a name="line.1076"></a>
-<span class="sourceLineNo">1077</span>        .build();<a name="line.1077"></a>
-<span class="sourceLineNo">1078</span>    LOG.info("Creating new region : " + regionInfo);<a name="line.1078"></a>
-<span class="sourceLineNo">1079</span>    HRegion region = HBaseFsckRepair.createHDFSRegionDir(getConf(), regionInfo, template);<a name="line.1079"></a>
-<span class="sourceLineNo">1080</span>    Path target = region.getRegionFileSystem().getRegionDir();<a name="line.1080"></a>
-<span class="sourceLineNo">1081</span><a name="line.1081"></a>
-<span class="sourceLineNo">1082</span>    // rename all the data to new region<a name="line.1082"></a>
-<span class="sourceLineNo">1083</span>    mergeRegionDirs(target, hi);<a name="line.1083"></a>
-<span class="sourceLineNo">1084</span>    fixes++;<a name="line.1084"></a>
-<span class="sourceLineNo">1085</span>  }<a name="line.1085"></a>
-<span class="sourceLineNo">1086</span><a name="line.1086"></a>
-<span class="sourceLineNo">1087</span>  /**<a name="line.1087"></a>
-<span class="sourceLineNo">1088</span>   * This method determines if there are table integrity errors in HDFS.  If<a name="line.1088"></a>
-<span class="sourceLineNo">1089</span>   * there are errors and the appropriate "fix" options are enabled, the method<a name="line.1089"></a>
-<span class="sourceLineNo">1090</span>   * will first correct orphan regions making them into legit regiondirs, and<a name="line.1090"></a>
-<span class="sourceLineNo">1091</span>   * then reload to merge potentially overlapping regions.<a name="line.1091"></a>
-<span class="sourceLineNo">1092</span>   *<a name="line.1092"></a>
-<span class="sourceLineNo">1093</span>   * @return number of table integrity errors found<a name="line.1093"></a>
-<span class="sourceLineNo">1094</span>   */<a name="line.1094"></a>
-<span class="sourceLineNo">1095</span>  private int restoreHdfsIntegrity() throws IOException, InterruptedException {<a name="line.1095"></a>
-<span class="sourceLineNo">1096</span>    // Determine what's on HDFS<a name="line.1096"></a>
-<span class="sourceLineNo">1097</span>    LOG.info("Loading HBase regioninfo from HDFS...");<a name="line.1097"></a>
-<span class="sourceLineNo">1098</span>    loadHdfsRegionDirs(); // populating regioninfo table.<a name="line.1098"></a>
-<span class="sourceLineNo">1099</span><a name="line.1099"></a>
-<span class="sourceLineNo">1100</span>    int errs = errors.getErrorList().size();<a name="line.1100"></a>
-<span class="sourceLineNo">1101</span>    // First time just get suggestions.<a name="line.1101"></a>
-<span class="sourceLineNo">1102</span>    tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1102"></a>
-<span class="sourceLineNo">1103</span>    checkHdfsIntegrity(false, false);<a name="line.1103"></a>
-<span class="sourceLineNo">1104</span><a name="line.1104"></a>
-<span class="sourceLineNo">1105</span>    if (errors.getErrorList().size() == errs) {<a name="line.1105"></a>
-<span class="sourceLineNo">1106</span>      LOG.info("No integrity errors.  We are done with this phase. Glorious.");<a name="line.1106"></a>
-<span class="sourceLineNo">1107</span>      return 0;<a name="line.1107"></a>
-<span class="sourceLineNo">1108</span>    }<a name="line.1108"></a>
-<span class="sourceLineNo">1109</span><a name="line.1109"></a>
-<span class="sourceLineNo">1110</span>    if (shouldFixHdfsOrphans() &amp;&amp; orphanHdfsDirs.size() &gt; 0) {<a name="line.1110"></a>
-<span class="sourceLineNo">1111</span>      adoptHdfsOrphans(orphanHdfsDirs);<a name="line.1111"></a>
-<span class="sourceLineNo">1112</span>      // TODO optimize by incrementally adding instead of reloading.<a name="line.1112"></a>
-<span class="sourceLineNo">1113</span>    }<a name="line.1113"></a>
-<span class="sourceLineNo">1114</span><a name="line.1114"></a>
-<span class="sourceLineNo">1115</span>    // Make sure there are no holes now.<a name="line.1115"></a>
-<span class="sourceLineNo">1116</span>    if (shouldFixHdfsHoles()) {<a name="line.1116"></a>
-<span class="sourceLineNo">1117</span>      clearState(); // this also resets # fixes.<a name="line.1117"></a>
-<span class="sourceLineNo">1118</span>      loadHdfsRegionDirs();<a name="line.1118"></a>
-<span class="sourceLineNo">1119</span>      tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1119"></a>
-<span class="sourceLineNo">1120</span>      tablesInfo = checkHdfsIntegrity(shouldFixHdfsHoles(), false);<a name="line.1120"></a>
-<span class="sourceLineNo">1121</span>    }<a name="line.1121"></a>
-<span class="sourceLineNo">1122</span><a name="line.1122"></a>
-<span class="sourceLineNo">1123</span>    // Now we fix overlaps<a name="line.1123"></a>
-<span class="sourceLineNo">1124</span>    if (shouldFixHdfsOverlaps()) {<a name="line.1124"></a>
-<span class="sourceLineNo">1125</span>      // second pass we fix overlaps.<a name="line.1125"></a>
-<span class="sourceLineNo">1126</span>      clearState(); // this also resets # fixes.<a name="line.1126"></a>
-<span class="sourceLineNo">1127</span>      loadHdfsRegionDirs();<a name="line.1127"></a>
-<span class="sourceLineNo">1128</span>      tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1128"></a>
-<span class="sourceLineNo">1129</span>      tablesInfo = checkHdfsIntegrity(false, shouldFixHdfsOverlaps());<a name="line.1129"></a>
-<span class="sourceLineNo">1130</span>    }<a name="line.1130"></a>
-<span class="sourceLineNo">1131</span><a name="line.1131"></a>
-<span class="sourceLineNo">1132</span>    return errors.getErrorList().size();<a name="line.1132"></a>
-<span class="sourceLineNo">1133</span>  }<a name="line.1133"></a>
-<span class="sourceLineNo">1134</span><a name="line.1134"></a>
-<span class="sourceLineNo">1135</span>  /**<a name="line.1135"></a>
-<span class="sourceLineNo">1136</span>   * Scan all the store file names to find any lingering reference files,<a name="line.1136"></a>
-<span class="sourceLineNo">1137</span>   * which refer to some none-exiting files. If "fix" option is enabled,<a name="line.1137"></a>
-<span class="sourceLineNo">1138</span>   * any lingering reference file will be sidelined if found.<a name="line.1138"></a>
-<span class="sourceLineNo">1139</span>   * &lt;p&gt;<a name="line.1139"></a>
-<span class="sourceLineNo">1140</span>   * Lingering reference file prevents a region from opening. It has to<a name="line.1140"></a>
-<span class="sourceLineNo">1141</span>   * be fixed before a cluster can start properly.<a name="line.1141"></a>
-<span class="sourceLineNo">1142</span>   */<a name="line.1142"></a>
-<span class="sourceLineNo">1143</span>  private void offlineReferenceFileRepair() throws IOException, InterruptedException {<a name="line.1143"></a>
-<span class="sourceLineNo">1144</span>    clearState();<a name="line.1144"></a>
-<span class="sourceLineNo">1145</span>    Configuration conf = getConf();<a name="line.1145"></a>
-<span class="sourceLineNo">1146</span>    Path hbaseRoot = FSUtils.getRootDir(conf);<a name="line.1146"></a>
-<span class="sourceLineNo">1147</span>    FileSystem fs = hbaseRoot.getFileSystem(conf);<a name="line.1147"></a>
-<span class="sourceLineNo">1148</span>    LOG.info("Computing mapping of all store files");<a name="line.1148"></a>
-<span class="sourceLineNo">1149</span>    Map&lt;String, Path&gt; allFiles = FSUtils.getTableStoreFilePathMap(fs, hbaseRoot,<a name="line.1149"></a>
-<span class="sourceLineNo">1150</span>      new FSUtils.ReferenceFileFilter(fs), executor, errors);<a name="line.1150"></a>
-<span class="sourceLineNo">1151</span>    errors.print("");<a name="line.1151"></a>
-<span class="sourceLineNo">1152</span>    LOG.info("Validating mapping using HDFS state");<a name="line.1152"></a>
-<span class="sourceLineNo">1153</span>    for (Path path: allFiles.values()) {<a name="line.1153"></a>
-<span class="sourceLineNo">1154</span>      Path referredToFile = StoreFileInfo.getReferredToFile(path);<a name="line.1154"></a>
-<span class="sourceLineNo">1155</span>      if (fs.exists(referredToFile)) continue;  // good, expected<a name="line.1155"></a>
-<span class="sourceLineNo">1156</span><a name="line.1156"></a>
-<span class="sourceLineNo">1157</span>      // Found a lingering reference file<a name="line.1157"></a>
-<span class="sourceLineNo">1158</span>      errors.reportError(ERROR_CODE.LINGERING_REFERENCE_HFILE,<a name="line.1158"></a>
-<span class="sourceLineNo">1159</span>        "Found lingering reference file " + path);<a name="line.1159"></a>
-<span class="sourceLineNo">1160</span>      if (!shouldFixReferenceFiles()) continue;<a name="line.1160"></a>
-<span class="sourceLineNo">1161</span><a name="line.1161"></a>
-<span class="sourceLineNo">1162</span>      // Now, trying to fix it since requested<a name="line.1162"></a>
-<span class="sourceLineNo">1163</span>      boolean success = false;<a name="line.1163"></a>
-<span class="sourceLineNo">1164</span>      String pathStr = path.toString();<a name="line.1164"></a>
-<span class="sourceLineNo">1165</span><a name="line.1165"></a>
-<span class="sourceLineNo">1166</span>      // A reference file path should be like<a name="line.1166"></a>
-<span class="sourceLineNo">1167</span>      // ${hbase.rootdir}/data/namespace/table_name/region_id/family_name/referred_file.region_name<a name="line.1167"></a>
-<span class="sourceLineNo">1168</span>      // Up 5 directories to get the root folder.<a name="line.1168"></a>
-<span class="sourceLineNo">1169</span>      // So the file will be sidelined to a similar folder structure.<a name="line.1169"></a>
-<span class="sourceLineNo">1170</span>      int index = pathStr.lastIndexOf(Path.SEPARATOR_CHAR);<a name="line.1170"></a>
-<span class="sourceLineNo">1171</span>      for (int i = 0; index &gt; 0 &amp;&amp; i &lt; 5; i++) {<a name="line.1171"></a>
-<span class="sourceLineNo">1172</span>        index = pathStr.lastIndexOf(Path.SEPARATOR_CHAR, index - 1);<a name="line.1172"></a>
-<span class="sourceLineNo">1173</span>      }<a name="line.1173"></a>
-<span class="sourceLineNo">1174</span>      if (index &gt; 0) {<a name="line.1174"></a>
-<span class="sourceLineNo">1175</span>        Path rootDir = getSidelineDir();<a name="line.1175"></a>
-<span class="sourceLineNo">1176</span>        Path dst = new Path(rootDir, pathStr.substring(index + 1));<a name="line.1176"></a>
-<span class="sourceLineNo">1177</span>        fs.mkdirs(dst.getParent());<a name="line.1177"></a>
-<span class="sourceLineNo">1178</span>        LOG.info("Trying to sideline reference file "<a name="line.1178"></a>
-<span class="sourceLineNo">1179</span>          + path + " to " + dst);<a name="line.1179"></a>
-<span class="sourceLineNo">1180</span>        setShouldRerun();<a name="line.1180"></a>
-<span class="sourceLineNo">1181</span><a name="line.1181"></a>
-<span class="sourceLineNo">1182</span>        success = fs.rename(path, dst);<a name="line.1182"></a>
-<span class="sourceLineNo">1183</span>        debugLsr(dst);<a name="line.1183"></a>
-<span class="sourceLineNo">1184</span><a name="line.1184"></a>
-<span class="sourceLineNo">1185</span>      }<a name="line.1185"></a>
-<span class="sourceLineNo">1186</span>      if (!success) {<a name="line.1186"></a>
-<span class="sourceLineNo">1187</span>        LOG.error("Failed to sideline reference file " + path);<a name="line.1187"></a>
-<span class="sourceLineNo">1188</span>      }<a name="line.1188"></a>
-<span class="sourceLineNo">1189</span>    }<a name="line.1189"></a>
-<span class="sourceLineNo">1190</span>  }<a name="line.1190"></a>
-<span class="sourceLineNo">1191</span><a name="line.1191"></a>
-<span class="sourceLineNo">1192</span>  /**<a name="line.1192"></a>
-<span class="sourceLineNo">1193</span>   * Scan all the store file names to find any lingering HFileLink files,<a name="line.1193"></a>
-<span class="sourceLineNo">1194</span>   * which refer to some none-exiting files. If "fix" option is enabled,<a name="line.1194"></a>
-<span class="sourceLineNo">1195</span>   * any lingering HFileLink file will be sidelined if found.<a name="line.1195"></a>
-<span class="sourceLineNo">1196</span>   */<a name="line.1196"></a>
-<span class="sourceLineNo">1197</span>  private void offlineHLinkFileRepair() throws IOException, InterruptedException {<a name="line.1197"></a>
-<span class="sourceLineNo">1198</span>    Configuration conf = getConf();<a name="line.1198"></a>
-<span class="sourceLineNo">1199</span>    Path hbaseRoot = FSUtils.getRootDir(conf);<a name="line.1199"></a>
-<span class="sourceLineNo">1200</span>    FileSystem fs = hbaseRoot.getFileSystem(conf);<a name="line.1200"></a>
-<span class="sourceLineNo">1201</span>    LOG.info("Computing mapping of all link files");<a name="line.1201"></a>
-<span class="sourceLineNo">1202</span>    Map&lt;String, Path&gt; allFiles = FSUtils<a name="line.1202"></a>
-<span class="sourceLineNo">1203</span>        .getTableStoreFilePathMap(fs, hbaseRoot, new FSUtils.HFileLinkFilter(), executor, errors);<a name="line.1203"></a>
-<span class="sourceLineNo">1204</span>    errors.print("");<a name="line.1204"></a>
-<span class="sourceLineNo">1205</span><a name="line.1205"></a>
-<span class="sourceLineNo">1206</span>    LOG.info("Validating mapping using HDFS state");<a name="line.1206"></a>
-<span class="sourceLineNo">1207</span>    for (Path path : allFiles.values()) {<a name="line.1207"></a>
-<span class="sourceLineNo">1208</span>      // building HFileLink object to gather locations<a name="line.1208"></a>
-<span class="sourceLineNo">1209</span>      HFileLink actualLink = HFileLink.buildFromHFileLinkPattern(conf, path);<a name="line.1209"></a>
-<span class="sourceLineNo">1210</span>      if (actualLink.exists(fs)) continue; // good, expected<a name="line.1210"></a>
-<span class="sourceLineNo">1211</span><a name="line.1211"></a>
-<span class="sourceLineNo">1212</span>      // Found a lingering HFileLink<a name="line.1212"></a>
-<span class="sourceLineNo">1213</span>      errors.reportError(ERROR_CODE.LINGERING_HFILELINK, "Found lingering HFileLink " + path);<a name="line.1213"></a>
-<span class="sourceLineNo">1214</span>      if (!shouldFixHFileLinks()) continue;<a name="line.1214"></a>
-<span class="sourceLineNo">1215</span><a name="line.1215"></a>
-<span class="sourceLineNo">1216</span>      // Now, trying to fix it since requested<a name="line.1216"></a>
-<span class="sourceLineNo">1217</span>      setShouldRerun();<a name="line.1217"></a>
-<span class="sourceLineNo">1218</span><a name="line.1218"></a>
-<span class="sourceLineNo">1219</span>      // An HFileLink path should be like<a name="line.1219"></a>
-<span class="sourceLineNo">1220</span>      // ${hbase.rootdir}/data/namespace/table_name/region_id/family_name/linkedtable=linkedregionname-linkedhfilename<a name="line.1220"></a>
-<span class="sourceLineNo">1221</span>      // sidelineing will happen in the ${hbase.rootdir}/${sidelinedir} directory with the same folder structure.<a name="line.1221"></a>
-<span class="sourceLineNo">1222</span>      boolean success = sidelineFile(fs, hbaseRoot, path);<a name="line.1222"></a>
-<span class="sourceLineNo">1223</span><a name="line.1223"></a>
-<span class="sourceLineNo">1224</span>      if (!success) {<a name="line.1224"></a>
-<span class="sourceLineNo">1225</span>        LOG.error("Failed to sideline HFileLink file " + path);<a name="line.1225"></a>
-<span class="sourceLineNo">1226</span>      }<a name="line.1226"></a>
-<span class="sourceLineNo">1227</span><a name="line.1227"></a>
-<span class="sourceLineNo">1228</span>      // An HFileLink backreference path should be like<a name="line.1228"></a>
-<span class="sourceLineNo">1229</span>      // ${hbase.rootdir}/archive/data/namespace/table_name/region_id/family_name/.links-linkedhfilename<a name="line.1229"></a>
-<span class="sourceLineNo">1230</span>      // sidelineing will happen in the ${hbase.rootdir}/${sidelinedir} directory with the same folder structure.<a name="line.1230"></a>
-<span class="sourceLineNo">1231</span>      Path backRefPath = FileLink.getBackReferencesDir(HFileArchiveUtil<a name="line.1231"></a>
-<span class="sourceLineNo">1232</span>              .getStoreArchivePath(conf, HFileLink.getReferencedTableName(path.getName().toString()),<a name="line.1232"></a>
-<span class="sourceLineNo">1233</span>                  HFileLink.getReferencedRegionName(path.getName().toString()),<a name="line.1233"></a>
-<span class="sourceLineNo">1234</span>                  path.getParent().getName()),<a name="line.1234"></a>
-<span class="sourceLineNo">1235</span>          HFileLink.getReferencedHFileName(path.getName().toString()));<a name="line.1235"></a>
-<span class="sourceLineNo">1236</span>      success = sidelineFile(fs, hbaseRoot, backRefPath);<a name="line.1236"></a>
-<span class="sourceLineNo">1237</span><a name="line.1237"></a>
-<span class="sourceLineNo">1238</span>      if (!success) {<a name="line.1238"></a>
-<span class="sourceLineNo">1239</span>        LOG.error("Failed to sideline HFileLink backreference file " + path);<a name="line.1239"></a>
-<span class="sourceLineNo">1240</span>      }<a name="line.1240"></a>
-<span class="sourceLineNo">1241</span>    }<a name="line.1241"></a>
-<span class="sourceLineNo">1242</span>  }<a name="line.1242"></a>
-<span class="sourceLineNo">1243</span><a name="line.1243"></a>
-<span class="sourceLineNo">1244</span>  private boolean sidelineFile(FileSystem fs, Path hbaseRoot, Path path) throws IOException {<a name="line.1244"></a>
-<span class="sourceLineNo">1245</span>    URI uri = hbaseRoot.toUri().relativize(path.toUri());<a name="line.1245"></a>
-<span class="sourceLineNo">1246</span>    if (uri.isAbsolute()) return false;<a name="line.1246"></a>
-<span class="sourceLineNo">1247</span>    String relativePath = uri.getPath();<a name="line.1247"></a>
-<span class="sourceLineNo">1248</span>    Path rootDir = getSidelineDir();<a name="line.1248"></a>
-<span class="sourceLineNo">1249</span>    Path dst = new Path(rootDir, relativePath);<a name="line.1249"></a>
-<span class="sourceLineNo">1250</span>    boolean pathCreated = fs.mkdirs(dst.getParent());<a name="line.1250"></a>
-<span class="sourceLineNo">1251</span>    if (!pathCreated) {<a name="line.1251"></a>
-<span class="sourceLineNo">1252</span>      LOG.error("Failed to create path: " + dst.getParent());<a name="line.1252"></a>
-<span class="sourceLineNo">1253</span>      return false;<a name="line.1253"></a>
-<span class="sourceLineNo">1254</span>    }<a name="line.1254"></a>
-<span class="sourceLineNo">1255</span>    LOG.info("Trying to sideline file " + path + " to " + dst);<a name="line.1255"></a>
-<span class="sourceLineNo">1256</span>    return fs.rename(path, dst);<a name="line.1256"></a>
-<span class="sourceLineNo">1257</span>  }<a name="line.1257"></a>
-<span class="sourceLineNo">1258</span><a name="line.1258"></a>
-<span class="sourceLineNo">1259</span>  /**<a name="line.1259"></a>
-<span class="sourceLineNo">1260</span>   * TODO -- need to add tests for this.<a name="line.1260"></a>
-<span class="sourceLineNo">1261</span>   */<a name="line.1261"></a>
-<span class="sourceLineNo">1262</span>  private void reportEmptyMetaCells() {<a name="line.1262"></a>
-<span class="sourceLineNo">1263</span>    errors.print("Number of empty REGIONINFO_QUALIFIER rows in hbase:meta: " +<a name="line.1263"></a>
-<span class="sourceLineNo">1264</span>      emptyRegionInfoQualifiers.size());<a name="line.1264"></a>
-<span class="sourceLineNo">1265</span>    if (details) {<a name="line.1265"></a>
-<span class="sourceLineNo">1266</span>      for (Result r: emptyRegionInfoQualifiers) {<a name="line.1266"></a>
-<span class="sourceLineNo">1267</span>        errors.print("  " + r);<a name="line.1267"></a>
-<span class="sourceLineNo">1268</span>      }<a name="line.1268"></a>
-<span class="sourceLineNo">1269</span>    }<a name="line.1269"></a>
-<span class="sourceLineNo">1270</span>  }<a name="line.1270"></a>
-<span class="sourceLineNo">1271</span><a name="line.1271"></a>
-<span class="sourceLineNo">1272</span>  /**<a name="line.1272"></a>
-<span class="sourceLineNo">1273</span>   * TODO -- need to add tests for this.<a name="line.1273"></a>
-<span class="sourceLineNo">1274</span>   */<a name="line.1274"></a>
-<span class="sourceLineNo">1275</span>  private void reportTablesInFlux() {<a name="line.1275"></a>
-<span class="sourceLineNo">1276</span>    AtomicInteger numSkipped = new AtomicInteger(0);<a name="line.1276"></a>
-<span class="sourceLineNo">1277</span>    TableDescriptor[] allTables = getTables(numSkipped);<a name="line.1277"></a>
-<span class="sourceLineNo">1278</span>    errors.print("Number of Tables: " + allTables.length);<a name="line.1278"></a>
-<span class="sourceLineNo">1279</span>    if (details) {<a name="line.1279"></a>
-<span class="sourceLineNo">1280</span>      if (numSkipped.get() &gt; 0) {<a name="line.1280"></a>
-<span class="sourceLineNo">1281</span>        errors.detail("Number of Tables in flux: " + numSkipped.get());<a name="line.1281"></a>
-<span class="sourceLineNo">1282</span>      }<a name="line.1282"></a>
-<span class="sourceLineNo">1283</span>      for (TableDescriptor td : allTables) {<a name="line.1283"></a>
-<span class="sourceLineNo">1284</span>        errors.detail("  Table: " + td.getTableName() + "\t" +<a name="line.1284"></a>
-<span class="sourceLineNo">1285</span>                           (td.isReadOnly() ? "ro" : "rw") + "\t" +<a name="line.1285"></a>
-<span class="sourceLineNo">1286</span>                            (td.isMetaRegion() ? "META" : "    ") + "\t" +<a name="line.1286"></a>
-<span class="sourceLineNo">1287</span>                           " families: " + td.getColumnFamilyCount());<a name="line.1287"></a>
-<span class="sourceLineNo">1288</span>      }<a name="line.1288"></a>
-<span class="sourceLineNo">1289</span>    }<a name="line.1289"></a>
-<span class="sourceLineNo">1290</span>  }<a name="line.1290"></a>
-<span class="sourceLineNo">1291</span><a name="line.1291"></a>
-<span class="sourceLineNo">1292</span>  public ErrorReporter getErrors() {<a name="line.1292"></a>
-<span class="sourceLineNo">1293</span>    return errors;<a name="line.1293"></a>
-<span class="sourceLineNo">1294</span>  }<a name="line.1294"></a>
-<span class="sourceLineNo">1295</span><a name="line.1295"></a>
-<span class="sourceLineNo">1296</span>  /**<a name="line.1296"></a>
-<span class="sourceLineNo">1297</span>   * Read the .regioninfo file from the file system.  If there is no<a name="line.1297"></a>
-<span class="sourceLineNo">1298</span>   * .regioninfo, add it to the orphan hdfs region list.<a name="line.1298"></a>
-<span class="sourceLineNo">1299</span>   */<a name="line.1299"></a>
-<span class="sourceLineNo">1300</span>  private void loadHdfsRegioninfo(HbckInfo hbi) throws IOException {<a name="line.1300"></a>
-<span class="sourceLineNo">1301</span>    Path regionDir = hbi.getHdfsRegionDir();<a name="line.1301"></a>
-<span class="sourceLineNo">1302</span>    if (regionDir == null) {<a name="line.1302"></a>
-<span class="sourceLineNo">1303</span>      if (hbi.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.1303"></a>
-<span class="sourceLineNo">1304</span>        // Log warning only for default/ primary replica with no region dir<a name="line.1304"></a>
-<span class="sourceLineNo">1305</span>        LOG.warn("No HDFS region dir found: " + hbi + " meta=" + hbi.metaEntry);<a name="line.1305"></a>
-<span class="sourceLineNo">1306</span>      }<a name="line.1306"></a>
-<span class="sourceLineNo">1307</span>      return;<a name="line.1307"></a>
-<span class="sourceLineNo">1308</span>    }<a name="line.1308"></a>
-<span class="sourceLineNo">1309</span><a name="line.1309"></a>
-<span class="sourceLineNo">1310</span>    if (hbi.hdfsEntry.hri != null) {<a name="line.1310"></a>
-<span class="sourceLineNo">1311</span>      // already loaded data<a name="line.1311"></a>
-<span class="sourceLineNo">1312</span>      return;<a name="line.1312"></a>
-<span class="sourceLineNo">1313</span>    }<a name="line.1313"></a>
-<span class="sourceLineNo">1314</span><a name="line.1314"></a>
-<span class="sourceLineNo">1315</span>    FileSystem fs = FileSystem.get(getConf());<a name="line.1315"></a>
-<span class="sourceLineNo">1316</span>    RegionInfo hri = HRegionFileSystem.loadRegionInfoFileContent(fs, regionDir);<a name="line.1316"></a>
-<span class="sourceLineNo">1317</span>    LOG.debug("RegionInfo read: " + hri.toString());<a name="line.1317"></a>
-<span class="sourceLineNo">1318</span>    hbi.hdfsEntry.hri = hri;<a name="line.1318"></a>
-<span class="sourceLineNo">1319</span>  }<a name="line.1319"></a>
-<span class="sourceLineNo">1320</span><a name="line.1320"></a>
-<span class="sourceLineNo">1321</span>  /**<a name="line.1321"></a>
-<span class="sourceLineNo">1322</span>   * Exception thrown when a integrity repair operation fails in an<a name="line.1322"></a>
-<span class="sourceLineNo">1323</span>   * unresolvable way.<a name="line.1323"></a>
-<span class="sourceLineNo">1324</span>   */<a name="line.1324"></a>
-<span class="sourceLineNo">1325</span>  public static class RegionRepairException extends IOException {<a name="line.1325"></a>
-<span class="sourceLineNo">1326</span>    private static final long serialVersionUID = 1L;<a name="line.1326"></a>
-<span class="sourceLineNo">1327</span>    final IOException ioe;<a name="line.1327"></a>
-<span class="sourceLineNo">1328</span>    public RegionRepairException(String s, IOException ioe) {<a name="line.1328"></a>
-<span class="sourceLineNo">1329</span>      super(s);<a name="line.1329"></a>
-<span class="sourceLineNo">1330</span>      this.ioe = ioe;<a name="line.1330"></a>
-<span class="sourceLineNo">1331</span>    }<a name="line.1331"></a>
-<span class="sourceLineNo">1332</span>  }<a name="line.1332"></a>
-<span class="sourceLineNo">1333</span><a name="line.1333"></a>
-<span class="sourceLineNo">1334</span>  /**<a name="line.1334"></a>
-<span class="sourceLineNo">1335</span>   * Populate hbi's from regionInfos loaded from file system.<a name="line.1335"></a>
-<span class="sourceLineNo">1336</span>   */<a name="line.1336"></a>
-<span class="sourceLineNo">1337</span>  private SortedMap&lt;TableName, TableInfo&gt; loadHdfsRegionInfos()<a name="line.1337"></a>
-<span class="sourceLineNo">1338</span>      throws IOException, InterruptedException {<a name="line.1338"></a>
-<span class="sourceLineNo">1339</span>    tablesInfo.clear(); // regenerating the data<a name="line.1339"></a>
-<span class="sourceLineNo">1340</span>    // generate region split structure<a name="line.1340"></a>
-<span class="sourceLineNo">1341</span>    Collection&lt;HbckInfo&gt; hbckInfos = regionInfoMap.values();<a name="line.1341"></a>
-<span class="sourceLineNo">1342</span><a name="line.1342"></a>
-<span class="sourceLineNo">1343</span>    // Parallelized read of .regioninfo files.<a name="line.1343"></a>
-<span class="sourceLineNo">1344</span>    List&lt;WorkItemHdfsRegionInfo&gt; hbis = new ArrayList&lt;&gt;(hbckInfos.size());<a name="line.1344"></a>
-<span class="sourceLineNo">1345</span>    List&lt;Future&lt;Void&gt;&gt; hbiFutures;<a name="line.1345"></a>
-<span class="sourceLineNo">1346</span><a name="line.1346"></a>
-<span class="sourceLineNo">1347</span>    for (HbckInfo hbi : hbckInfos) {<a name="line.1347"></a>
-<span class="sourceLineNo">1348</span>      WorkItemHdfsRegionInfo work = new WorkItemHdfsRegionInfo(hbi, this, errors);<a name="line.1348"></a>
-<span class="sourceLineNo">1349</span>      hbis.add(work);<a name="line.1349"></a>
-<span class="sourceLineNo">1350</span>    }<a name="line.1350"></a>
-<span class="sourceLineNo">1351</span><a name="line.1351"></a>
-<span class="sourceLineNo">1352</span>    // Submit and wait for completion<a name="line.1352"></a>
-<span class="sourceLineNo">1353</span>    hbiFutures = executor.invokeAll(hbis);<a name="line.1353"></a>
-<span class="sourceLineNo">1354</span><a name="line.1354"></a>
-<span class="sourceLineNo">1355</span>    for(int i=0; i&lt;hbiFutures.size(); i++) {<a name="line.1355"></a>
-<span class="sourceLineNo">1356</span>      WorkItemHdfsRegionInfo work = hbis.get(i);<a name="line.1356"></a>
-<span class="sourceLineNo">1357</span>      Future&lt;Void&gt; f = hbiFutures.get(i);<a name="line.1357"></a>
-<span class="sourceLineNo">1358</span>      try {<a name="line.1358"></a>
-<span class="sourceLineNo">1359</span>        f.get();<a name="line.1359"></a>
-<span class="sourceLineNo">1360</span>      } catch(ExecutionException e) {<a name="line.1360"></a>
-<span class="sourceLineNo">1361</span>        LOG.warn("Failed to read .regioninfo file for region " +<a name="line.1361"></a>
-<span class="sourceLineNo">1362</span>              work.hbi.getRegionNameAsString(), e.getCause());<a name="line.1362"></a>
-<span class="sourceLineNo">1363</span>      }<a name="line.1363"></a>
-<span class="sourceLineNo">1364</span>    }<a name="line.1364"></a>
-<span class="sourceLineNo">1365</span><a name="line.1365"></a>
-<span class="sourceLineNo">1366</span>    Path hbaseRoot = FSUtils.getRootDir(getConf());<a name="line.1366"></a>
-<span class="sourceLineNo">1367</span>    FileSystem fs = hbaseRoot.getFileSystem(getConf());<a name="line.1367"></a>
-<span class="sourceLineNo">1368</span>    // serialized table info gathering.<a name="line.1368"></a>
-<span class="sourceLineNo">1369</span>    for (HbckInfo hbi: hbckInfos) {<a name="line.1369"></a>
-<span class="sourceLineNo">1370</span><a name="line.1370"></a>
-<span class="sourceLineNo">1371</span>      if (hbi.getHdfsHRI() == null) {<a name="line.1371"></a>
-<span class="sourceLineNo">1372</span>        // was an orphan<a name="line.1372"></a>
-<span class="sourceLineNo">1373</span>        continue;<a name="line.1373"></a>
-<span class="sourceLineNo">1374</span>      }<a name="line.1374"></a>
+<span class="sourceLineNo">1028</span>          hf = HFile.createReader(fs, hfile.getPath(), CacheConfig.DISABLED, true, getConf());<a name="line.1028"></a>
+<span class="sourceLineNo">1029</span>          hf.loadFileInfo();<a name="line.1029"></a>
+<span class="sourceLineNo">1030</span>          Optional&lt;Cell&gt; startKv = hf.getFirstKey();<a name="line.1030"></a>
+<span class="sourceLineNo">1031</span>          start = CellUtil.cloneRow(startKv.get());<a name="line.1031"></a>
+<span class="sourceLineNo">1032</span>          Optional&lt;Cell&gt; endKv = hf.getLastKey();<a name="line.1032"></a>
+<span class="sourceLineNo">1033</span>          end = CellUtil.cloneRow(endKv.get());<a name="line.1033"></a>
+<span class="sourceLineNo">1034</span>        } catch (IOException ioe) {<a name="line.1034"></a>
+<span class="sourceLineNo">1035</span>          LOG.warn("Problem reading orphan file " + hfile + ", skipping");<a name="line.1035"></a>
+<span class="sourceLineNo">1036</span>          continue;<a name="line.1036"></a>
+<span class="sourceLineNo">1037</span>        } catch (NullPointerException ioe) {<a name="line.1037"></a>
+<span class="sourceLineNo">1038</span>          LOG.warn("Orphan file " + hfile + " is possibly corrupted HFile, skipping");<a name="line.1038"></a>
+<span class="sourceLineNo">1039</span>          continue;<a name="line.1039"></a>
+<span class="sourceLineNo">1040</span>        } finally {<a name="line.1040"></a>
+<span class="sourceLineNo">1041</span>          if (hf != null) {<a name="line.1041"></a>
+<span class="sourceLineNo">1042</span>            hf.close();<a name="line.1042"></a>
+<span class="sourceLineNo">1043</span>          }<a name="line.1043"></a>
+<span class="sourceLineNo">1044</span>        }<a name="line.1044"></a>
+<span class="sourceLineNo">1045</span><a name="line.1045"></a>
+<span class="sourceLineNo">1046</span>        // expand the range to include the range of all hfiles<a name="line.1046"></a>
+<span class="sourceLineNo">1047</span>        if (orphanRegionRange == null) {<a name="line.1047"></a>
+<span class="sourceLineNo">1048</span>          // first range<a name="line.1048"></a>
+<span class="sourceLineNo">1049</span>          orphanRegionRange = new Pair&lt;&gt;(start, end);<a name="line.1049"></a>
+<span class="sourceLineNo">1050</span>        } else {<a name="line.1050"></a>
+<span class="sourceLineNo">1051</span>          // TODO add test<a name="line.1051"></a>
+<span class="sourceLineNo">1052</span><a name="line.1052"></a>
+<span class="sourceLineNo">1053</span>          // expand range only if the hfile is wider.<a name="line.1053"></a>
+<span class="sourceLineNo">1054</span>          if (Bytes.compareTo(orphanRegionRange.getFirst(), start) &gt; 0) {<a name="line.1054"></a>
+<span class="sourceLineNo">1055</span>            orphanRegionRange.setFirst(start);<a name="line.1055"></a>
+<span class="sourceLineNo">1056</span>          }<a name="line.1056"></a>
+<span class="sourceLineNo">1057</span>          if (Bytes.compareTo(orphanRegionRange.getSecond(), end) &lt; 0 ) {<a name="line.1057"></a>
+<span class="sourceLineNo">1058</span>            orphanRegionRange.setSecond(end);<a name="line.1058"></a>
+<span class="sourceLineNo">1059</span>          }<a name="line.1059"></a>
+<span class="sourceLineNo">1060</span>        }<a name="line.1060"></a>
+<span class="sourceLineNo">1061</span>      }<a name="line.1061"></a>
+<span class="sourceLineNo">1062</span>    }<a name="line.1062"></a>
+<span class="sourceLineNo">1063</span>    if (orphanRegionRange == null) {<a name="line.1063"></a>
+<span class="sourceLineNo">1064</span>      LOG.warn("No data in dir " + p + ", sidelining data");<a name="line.1064"></a>
+<span class="sourceLineNo">1065</span>      fixes++;<a name="line.1065"></a>
+<span class="sourceLineNo">1066</span>      sidelineRegionDir(fs, hi);<a name="line.1066"></a>
+<span class="sourceLineNo">1067</span>      return;<a name="line.1067"></a>
+<span class="sourceLineNo">1068</span>    }<a name="line.1068"></a>
+<span class="sourceLineNo">1069</span>    LOG.info("Min max keys are : [" + Bytes.toString(orphanRegionRange.getFirst()) + ", " +<a name="line.1069"></a>
+<span class="sourceLineNo">1070</span>        Bytes.toString(orphanRegionRange.getSecond()) + ")");<a name="line.1070"></a>
+<span class="sourceLineNo">1071</span><a name="line.1071"></a>
+<span class="sourceLineNo">1072</span>    // create new region on hdfs. move data into place.<a name="line.1072"></a>
+<span class="sourceLineNo">1073</span>    RegionInfo regionInfo = RegionInfoBuilder.newBuilder(template.getTableName())<a name="line.1073"></a>
+<span class="sourceLineNo">1074</span>        .setStartKey(orphanRegionRange.getFirst())<a name="line.1074"></a>
+<span class="sourceLineNo">1075</span>        .setEndKey(Bytes.add(orphanRegionRange.getSecond(), new byte[1]))<a name="line.1075"></a>
+<span class="sourceLineNo">1076</span>        .build();<a name="line.1076"></a>
+<span class="sourceLineNo">1077</span>    LOG.info("Creating new region : " + regionInfo);<a name="line.1077"></a>
+<span class="sourceLineNo">1078</span>    HRegion region = HBaseFsckRepair.createHDFSRegionDir(getConf(), regionInfo, template);<a name="line.1078"></a>
+<span class="sourceLineNo">1079</span>    Path target = region.getRegionFileSystem().getRegionDir();<a name="line.1079"></a>
+<span class="sourceLineNo">1080</span><a name="line.1080"></a>
+<span class="sourceLineNo">1081</span>    // rename all the data to new region<a name="line.1081"></a>
+<span class="sourceLineNo">1082</span>    mergeRegionDirs(target, hi);<a name="line.1082"></a>
+<span class="sourceLineNo">1083</span>    fixes++;<a name="line.1083"></a>
+<span class="sourceLineNo">1084</span>  }<a name="line.1084"></a>
+<span class="sourceLineNo">1085</span><a name="line.1085"></a>
+<span class="sourceLineNo">1086</span>  /**<a name="line.1086"></a>
+<span class="sourceLineNo">1087</span>   * This method determines if there are table integrity errors in HDFS.  If<a name="line.1087"></a>
+<span class="sourceLineNo">1088</span>   * there are errors and the appropriate "fix" options are enabled, the method<a name="line.1088"></a>
+<span class="sourceLineNo">1089</span>   * will first correct orphan regions making them into legit regiondirs, and<a name="line.1089"></a>
+<span class="sourceLineNo">1090</span>   * then reload to merge potentially overlapping regions.<a name="line.1090"></a>
+<span class="sourceLineNo">1091</span>   *<a name="line.1091"></a>
+<span class="sourceLineNo">1092</span>   * @return number of table integrity errors found<a name="line.1092"></a>
+<span class="sourceLineNo">1093</span>   */<a name="line.1093"></a>
+<span class="sourceLineNo">1094</span>  private int restoreHdfsIntegrity() throws IOException, InterruptedException {<a name="line.1094"></a>
+<span class="sourceLineNo">1095</span>    // Determine what's on HDFS<a name="line.1095"></a>
+<span class="sourceLineNo">1096</span>    LOG.info("Loading HBase regioninfo from HDFS...");<a name="line.1096"></a>
+<span class="sourceLineNo">1097</span>    loadHdfsRegionDirs(); // populating regioninfo table.<a name="line.1097"></a>
+<span class="sourceLineNo">1098</span><a name="line.1098"></a>
+<span class="sourceLineNo">1099</span>    int errs = errors.getErrorList().size();<a name="line.1099"></a>
+<span class="sourceLineNo">1100</span>    // First time just get suggestions.<a name="line.1100"></a>
+<span class="sourceLineNo">1101</span>    tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1101"></a>
+<span class="sourceLineNo">1102</span>    checkHdfsIntegrity(false, false);<a name="line.1102"></a>
+<span class="sourceLineNo">1103</span><a name="line.1103"></a>
+<span class="sourceLineNo">1104</span>    if (errors.getErrorList().size() == errs) {<a name="line.1104"></a>
+<span class="sourceLineNo">1105</span>      LOG.info("No integrity errors.  We are done with this phase. Glorious.");<a name="line.1105"></a>
+<span class="sourceLineNo">1106</span>      return 0;<a name="line.1106"></a>
+<span class="sourceLineNo">1107</span>    }<a name="line.1107"></a>
+<span class="sourceLineNo">1108</span><a name="line.1108"></a>
+<span class="sourceLineNo">1109</span>    if (shouldFixHdfsOrphans() &amp;&amp; orphanHdfsDirs.size() &gt; 0) {<a name="line.1109"></a>
+<span class="sourceLineNo">1110</span>      adoptHdfsOrphans(orphanHdfsDirs);<a name="line.1110"></a>
+<span class="sourceLineNo">1111</span>      // TODO optimize by incrementally adding instead of reloading.<a name="line.1111"></a>
+<span class="sourceLineNo">1112</span>    }<a name="line.1112"></a>
+<span class="sourceLineNo">1113</span><a name="line.1113"></a>
+<span class="sourceLineNo">1114</span>    // Make sure there are no holes now.<a name="line.1114"></a>
+<span class="sourceLineNo">1115</span>    if (shouldFixHdfsHoles()) {<a name="line.1115"></a>
+<span class="sourceLineNo">1116</span>      clearState(); // this also resets # fixes.<a name="line.1116"></a>
+<span class="sourceLineNo">1117</span>      loadHdfsRegionDirs();<a name="line.1117"></a>
+<span class="sourceLineNo">1118</span>      tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1118"></a>
+<span class="sourceLineNo">1119</span>      tablesInfo = checkHdfsIntegrity(shouldFixHdfsHoles(), false);<a name="line.1119"></a>
+<span class="sourceLineNo">1120</span>    }<a name="line.1120"></a>
+<span class="sourceLineNo">1121</span><a name="line.1121"></a>
+<span class="sourceLineNo">1122</span>    // Now we fix overlaps<a name="line.1122"></a>
+<span class="sourceLineNo">1123</span>    if (shouldFixHdfsOverlaps()) {<a name="line.1123"></a>
+<span class="sourceLineNo">1124</span>      // second pass we fix overlaps.<a name="line.1124"></a>
+<span class="sourceLineNo">1125</span>      clearState(); // this also resets # fixes.<a name="line.1125"></a>
+<span class="sourceLineNo">1126</span>      loadHdfsRegionDirs();<a name="line.1126"></a>
+<span class="sourceLineNo">1127</span>      tablesInfo = loadHdfsRegionInfos(); // update tableInfos based on region info in fs.<a name="line.1127"></a>
+<span class="sourceLineNo">1128</span>      tablesInfo = checkHdfsIntegrity(false, shouldFixHdfsOverlaps());<a name="line.1128"></a>
+<span class="sourceLineNo">1129</span>    }<a name="line.1129"></a>
+<span class="sourceLineNo">1130</span><a name="line.1130"></a>
+<span class="sourceLineNo">1131</span>    return errors.getErrorList().size();<a name="line.1131"></a>
+<span class="sourceLineNo">1132</span>  }<a name="line.1132"></a>
+<span class="sourceLineNo">1133</span><a name="line.1133"></a>
+<span class="sourceLineNo">1134</span>  /**<a name="line.1134"></a>
+<span class="sourceLineNo">1135</span>   * Scan all the store file names to find any lingering reference files,<a name="line.1135"></a>
+<span class="sourceLineNo">1136</span>   * which refer to some none-exiting files. If "fix" option is enabled,<a name="line.1136"></a>
+<span class="sourceLineNo">1137</span>   * any lingering reference file will be sidelined if found.<a name="line.1137"></a>
+<span class="sourceLineNo">1138</span>   * &lt;p&gt;<a name="line.1138"></a>
+<span class="sourceLineNo">1139</span>   * Lingering reference file prevents a region from opening. It has to<a name="line.1139"></a>
+<span class="sourceLineNo">1140</span>   * be fixed before a cluster can start properly.<a name="line.1140"></a>
+<span class="sourceLineNo">1141</span>   */<a name="line.1141"></a>
+<span class="sourceLineNo">1142</span>  private void offlineReferenceFileRepair() throws IOException, InterruptedException {<a name="line.1142"></a>
+<span class="sourceLineNo">1143</span>    clearState();<a name="line.1143"></a>
+<span class="sourceLineNo">1144</span>    Configuration conf = getConf();<a name="line.1144"></a>
+<span class="sourceLineNo">1145</span>    Path hbaseRoot = FSUtils.getRootDir(conf);<a name="line.1145"></a>
+<span class="sourceLineNo">1146</span>    FileSystem fs = hbaseRoot.getFileSystem(conf);<a name="line.1146"></a>
+<span class="sourceLineNo">1147</span>    LOG.info("Computing mapping of all store files");<a name="line.1147"></a>
+<span class="sourceLineNo">1148</span>    Map&lt;String, Path&gt; allFiles = FSUtils.getTableStoreFilePathMap(fs, hbaseRoot,<a name="line.1148"></a>
+<span class="sourceLineNo">1149</span>      new FSUtils.ReferenceFileFilter(fs), executor, errors);<a name="line.1149"></a>
+<span class="sourceLineNo">1150</span>    errors.print("");<a name="line.1150"></a>
+<span class="sourceLineNo">1151</span>    LOG.info("Validating mapping using HDFS state");<a name="line.1151"></a>
+<span class="sourceLineNo">1152</span>    for (Path path: allFiles.values()) {<a name="line.1152"></a>
+<span class="sourceLineNo">1153</span>      Path referredToFile = StoreFileInfo.getReferredToFile(path);<a name="line.1153"></a>
+<span class="sourceLineNo">1154</span>      if (fs.exists(referredToFile)) continue;  // good, expected<a name="line.1154"></a>
+<span class="sourceLineNo">1155</span><a name="line.1155"></a>
+<span class="sourceLineNo">1156</span>      // Found a lingering reference file<a name="line.1156"></a>
+<span class="sourceLineNo">1157</span>      errors.reportError(ERROR_CODE.LINGERING_REFERENCE_HFILE,<a name="line.1157"></a>
+<span class="sourceLineNo">1158</span>        "Found lingering reference file " + path);<a name="line.1158"></a>
+<span class="sourceLineNo">1159</span>      if (!shouldFixReferenceFiles()) continue;<a name="line.1159"></a>
+<span class="sourceLineNo">1160</span><a name="line.1160"></a>
+<span class="sourceLineNo">1161</span>      // Now, trying to fix it since requested<a name="line.1161"></a>
+<span class="sourceLineNo">1162</span>      boolean success = false;<a name="line.1162"></a>
+<span class="sourceLineNo">1163</span>      String pathStr = path.toString();<a name="line.1163"></a>
+<span class="sourceLineNo">1164</span><a name="line.1164"></a>
+<span class="sourceLineNo">1165</span>      // A reference file path should be like<a name="line.1165"></a>
+<span class="sourceLineNo">1166</span>      // ${hbase.rootdir}/data/namespace/table_name/region_id/family_name/referred_file.region_name<a name="line.1166"></a>
+<span class="sourceLineNo">1167</span>      // Up 5 directories to get the root folder.<a name="line.1167"></a>
+<span class="sourceLineNo">1168</span>      // So the file will be sidelined to a similar folder structure.<a name="line.1168"></a>
+<span class="sourceLineNo">1169</span>      int index = pathStr.lastIndexOf(Path.SEPARATOR_CHAR);<a name="line.1169"></a>
+<span class="sourceLineNo">1170</span>      for (int i = 0; index &gt; 0 &amp;&amp; i &lt; 5; i++) {<a name="line.1170"></a>
+<span class="sourceLineNo">1171</span>        index = pathStr.lastIndexOf(Path.SEPARATOR_CHAR, index - 1);<a name="line.1171"></a>
+<span class="sourceLineNo">1172</span>      }<a name="line.1172"></a>
+<span class="sourceLineNo">1173</span>      if (index &gt; 0) {<a name="line.1173"></a>
+<span class="sourceLineNo">1174</span>        Path rootDir = getSidelineDir();<a name="line.1174"></a>
+<span class="sourceLineNo">1175</span>        Path dst = new Path(rootDir, pathStr.substring(index + 1));<a name="line.1175"></a>
+<span class="sourceLineNo">1176</span>        fs.mkdirs(dst.getParent());<a name="line.1176"></a>
+<span class="sourceLineNo">1177</span>        LOG.info("Trying to sideline reference file "<a name="line.1177"></a>
+<span class="sourceLineNo">1178</span>          + path + " to " + dst);<a name="line.1178"></a>
+<span class="sourceLineNo">1179</span>        setShouldRerun();<a name="line.1179"></a>
+<span class="sourceLineNo">1180</span><a name="line.1180"></a>
+<span class="sourceLineNo">1181</span>        success = fs.rename(path, dst);<a name="line.1181"></a>
+<span class="sourceLineNo">1182</span>        debugLsr(dst);<a name="line.1182"></a>
+<span class="sourceLineNo">1183</span><a name="line.1183"></a>
+<span class="sourceLineNo">1184</span>      }<a name="line.1184"></a>
+<span class="sourceLineNo">1185</span>      if (!success) {<a name="line.1185"></a>
+<span class="sourceLineNo">1186</span>        LOG.error("Failed to sideline reference file " + path);<a name="line.1186"></a>
+<span class="sourceLineNo">1187</span>      }<a name="line.1187"></a>
+<span class="sourceLineNo">1188</span>    }<a name="line.1188"></a>
+<span class="sourceLineNo">1189</span>  }<a name="line.1189"></a>
+<span class="sourceLineNo">1190</span><a name="line.1190"></a>
+<span class="sourceLineNo">1191</span>  /**<a name="line.1191"></a>
+<span class="sourceLineNo">1192</span>   * Scan all the store file names to find any lingering HFileLink files,<a name="line.1192"></a>
+<span class="sourceLineNo">1193</span>   * which refer to some none-exiting files. If "fix" option is enabled,<a name="line.1193"></a>
+<span class="sourceLineNo">1194</span>   * any lingering HFileLink file will be sidelined if found.<a name="line.1194"></a>
+<span class="sourceLineNo">1195</span>   */<a name="line.1195"></a>
+<span class="sourceLineNo">1196</span>  private void offlineHLinkFileRepair() throws IOException, InterruptedException {<a name="line.1196"></a>
+<span class="sourceLineNo">1197</span>    Configuration conf = getConf();<a name="line.1197"></a>
+<span class="sourceLineNo">1198</span>    Path hbaseRoot = FSUtils.getRootDir(conf);<a name="line.1198"></a>
+<span class="sourceLineNo">1199</span>    FileSystem fs = hbaseRoot.getFileSystem(conf);<a name="line.1199"></a>
+<span class="sourceLineNo">1200</span>    LOG.info("Computing mapping of all link files");<a name="line.1200"></a>
+<span class="sourceLineNo">1201</span>    Map&lt;String, Path&gt; allFiles = FSUtils<a name="line.1201"></a>
+<span class="sourceLineNo">1202</span>        .getTableStoreFilePathMap(fs, hbaseRoot, new FSUtils.HFileLinkFilter(), executor, errors);<a name="line.1202"></a>
+<span class="sourceLineNo">1203</span>    errors.print("");<a name="line.1203"></a>
+<span class="sourceLineNo">1204</span><a name="line.1204"></a>
+<span class="sourceLineNo">1205</span>    LOG.info("Validating mapping using HDFS state");<a name="line.1205"></a>
+<span class="sourceLineNo">1206</span>    for (Path path : allFiles.values()) {<a name="line.1206"></a>
+<span class="sourceLineNo">1207</span>      // building HFileLink object to gather locations<a name="line.1207"></a>
+<span class="sourceLineNo">1208</span>      HFileLink actualLink = HFileLink.buildFromHFileLinkPattern(conf, path);<a name="line.1208"></a>
+<span class="sourceLineNo">1209</span>      if (actualLink.exists(fs)) continue; // good, expected<a name="line.1209"></a>
+<span class="sourceLineNo">1210</span><a name="line.1210"></a>
+<span class="sourceLineNo">1211</span>      // Found a lingering HFileLink<a name="line.1211"></a>
+<span class="sourceLineNo">1212</span>      errors.reportError(ERROR_CODE.LINGERING_HFILELINK, "Found lingering HFileLink " + path);<a name="line.1212"></a>
+<span class="sourceLineNo">1213</span>      if (!shouldFixHFileLinks()) continue;<a name="line.1213"></a>
+<span class="sourceLineNo">1214</span><a name="line.1214"></a>
+<span class="sourceLineNo">1215</span>      // Now, trying to fix it since requested<a name="line.1215"></a>
+<span class="sourceLineNo">1216</span>      setShouldRerun();<a name="line.1216"></a>
+<span class="sourceLineNo">1217</span><a name="line.1217"></a>
+<span class="sourceLineNo">1218</span>      // An HFileLink path should be like<a name="line.1218"></a>
+<span class="sourceLineNo">1219</span>      // ${hbase.rootdir}/data/namespace/table_name/region_id/family_name/linkedtable=linkedregionname-linkedhfilename<a name="line.1219"></a>
+<span class="sourceLineNo">1220</span>      // sidelineing will happen in the ${hbase.rootdir}/${sidelinedir} directory with the same folder structure.<a name="line.1220"></a>
+<span class="sourceLineNo">1221</span>      boolean success = sidelineFile(fs, hbaseRoot, path);<a name="line.1221"></a>
+<span class="sourceLineNo">1222</span><a name="line.1222"></a>
+<span class="sourceLineNo">1223</span>      if (!success) {<a name="line.1223"></a>
+<span class="sourceLineNo">1224</span>        LOG.error("Failed to sideline HFileLink file " + path);<a name="line.1224"></a>
+<span class="sourceLineNo">1225</span>      }<a name="line.1225"></a>
+<span class="sourceLineNo">1226</span><a name="line.1226"></a>
+<span class="sourceLineNo">1227</span>      // An HFileLink backreference path should be like<a name="line.1227"></a>
+<span class="sourceLineNo">1228</span>      // ${hbase.rootdir}/archive/data/namespace/table_name/region_id/family_name/.links-linkedhfilename<a name="line.1228"></a>
+<span class="sourceLineNo">1229</span>      // sidelineing will happen in the ${hbase.rootdir}/${sidelinedir} directory with the same folder structure.<a name="line.1229"></a>
+<span class="sourceLineNo">1230</span>      Path backRefPath = FileLink.getBackReferencesDir(HFileArchiveUtil<a name="line.1230"></a>
+<span class="sourceLineNo">1231</span>              .getStoreArchivePath(conf, HFileLink.getReferencedTableName(path.getName().toString()),<a name="line.1231"></a>
+<span class="sourceLineNo">1232</span>                  HFileLink.getReferencedRegionName(path.getName().toString()),<a name="line.1232"></a>
+<span class="sourceLineNo">1233</span>                  path.getParent().getName()),<a name="line.1233"></a>
+<span class="sourceLineNo">1234</span>          HFileLink.getReferencedHFileName(path.getName().toString()));<a name="line.1234"></a>
+<span class="sourceLineNo">1235</span>      success = sidelineFile(fs, hbaseRoot, backRefPath);<a name="line.1235"></a>
+<span class="sourceLineNo">1236</span><a name="line.1236"></a>
+<span class="sourceLineNo">1237</span>      if (!success) {<a name="line.1237"></a>
+<span class="sourceLineNo">1238</span>        LOG.error("Failed to sideline HFileLink backreference file " + path);<a name="line.1238"></a>
+<span class="sourceLineNo">1239</span>      }<a name="line.1239"></a>
+<span class="sourceLineNo">1240</span>    }<a name="line.1240"></a>
+<span class="sourceLineNo">1241</span>  }<a name="line.1241"></a>
+<span class="sourceLineNo">1242</span><a name="line.1242"></a>
+<span class="sourceLineNo">1243</span>  private boolean sidelineFile(FileSystem fs, Path hbaseRoot, Path path) throws IOException {<a name="line.1243"></a>
+<span class="sourceLineNo">1244</span>    URI uri = hbaseRoot.toUri().relativize(path.toUri());<a name="line.1244"></a>
+<span class="sourceLineNo">1245</span>    if (uri.isAbsolute()) return false;<a name="line.1245"></a>
+<span class="sourceLineNo">1246</span>    String relativePath = uri.getPath();<a name="line.1246"></a>
+<span class="sourceLineNo">1247</span>    Path rootDir = getSidelineDir();<a name="line.1247"></a>
+<span class="sourceLineNo">1248</span>    Path dst = new Path(rootDir, relativePath);<a name="line.1248"></a>
+<span class="sourceLineNo">1249</span>    boolean pathCreated = fs.mkdirs(dst.getParent());<a name="line.1249"></a>
+<span class="sourceLineNo">1250</span>    if (!pathCreated) {<a name="line.1250"></a>
+<span class="sourceLineNo">1251</span>      LOG.error("Failed to create path: " + dst.getParent());<a name="line.1251"></a>
+<span class="sourceLineNo">1252</span>      return false;<a name="line.1252"></a>
+<span class="sourceLineNo">1253</span>    }<a name="line.1253"></a>
+<span class="sourceLineNo">1254</span>    LOG.info("Trying to sideline file " + path + " to " + dst);<a name="line.1254"></a>
+<span class="sourceLineNo">1255</span>    return fs.rename(path, dst);<a name="line.1255"></a>
+<span class="sourceLineNo">1256</span>  }<a name="line.1256"></a>
+<span class="sourceLineNo">1257</span><a name="line.1257"></a>
+<span class="sourceLineNo">1258</span>  /**<a name="line.1258"></a>
+<span class="sourceLineNo">1259</span>   * TODO -- need to add tests for this.<a name="line.1259"></a>
+<span class="sourceLineNo">1260</span>   */<a name="line.1260"></a>
+<span class="sourceLineNo">1261</span>  private void reportEmptyMetaCells() {<a name="line.1261"></a>
+<span class="sourceLineNo">1262</span>    errors.print("Number of empty REGIONINFO_QUALIFIER rows in hbase:meta: " +<a name="line.1262"></a>
+<span class="sourceLineNo">1263</span>      emptyRegionInfoQualifiers.size());<a name="line.1263"></a>
+<span class="sourceLineNo">1264</span>    if (details) {<a name="line.1264"></a>
+<span class="sourceLineNo">1265</span>      for (Result r: emptyRegionInfoQualifiers) {<a name="line.1265"></a>
+<span class="sourceLineNo">1266</span>        errors.print("  " + r);<a name="line.1266"></a>
+<span class="sourceLineNo">1267</span>      }<a name="line.1267"></a>
+<span class="sourceLineNo">1268</span>    }<a name="line.1268"></a>
+<span class="sourceLineNo">1269</span>  }<a name="line.1269"></a>
+<span class="sourceLineNo">1270</span><a name="line.1270"></a>
+<span class="sourceLineNo">1271</span>  /**<a name="line.1271"></a>
+<span class="sourceLineNo">1272</span>   * TODO -- need to add tests for this.<a name="line.1272"></a>
+<span class="sourceLineNo">1273</span>   */<a name="line.1273"></a>
+<span class="sourceLineNo">1274</span>  private void reportTablesInFlux() {<a name="line.1274"></a>
+<span class="sourceLineNo">1275</span>    AtomicInteger numSkipped = new AtomicInteger(0);<a name="line.1275"></a>
+<span class="sourceLineNo">1276</span>    TableDescriptor[] allTables = getTables(numSkipped);<a name="line.1276"></a>
+<span class="sourceLineNo">1277</span>    errors.print("Number of Tables: " + allTables.length);<a name="line.1277"></a>
+<span class="sourceLineNo">1278</span>    if (details) {<a name="line.1278"></a>
+<span class="sourceLineNo">1279</span>      if (numSkipped.get() &gt; 0) {<a name="line.1279"></a>
+<span class="sourceLineNo">1280</span>        errors.detail("Number of Tables in flux: " + numSkipped.get());<a name="line.1280"></a>
+<span class="sourceLineNo">1281</span>      }<a name="line.1281"></a>
+<span class="sourceLineNo">1282</span>      for (TableDescriptor td : allTables) {<a name="line.1282"></a>
+<span class="sourceLineNo">1283</span>        errors.detail("  Table: " + td.getTableName() + "\t" +<a name="line.1283"></a>
+<span class="sourceLineNo">1284</span>                           (td.isReadOnly() ? "ro" : "rw") + "\t" +<a name="line.1284"></a>
+<span class="sourceLineNo">1285</span>                            (td.isMetaRegion() ? "META" : "    ") + "\t" +<a name="line.1285"></a>
+<span class="sourceLineNo">1286</span>                           " families: " + td.getColumnFamilyCount());<a name="line.1286"></a>
+<span class="sourceLineNo">1287</span>      }<a name="line.1287"></a>
+<span class="sourceLineNo">1288</span>    }<a name="line.1288"></a>
+<span class="sourceLineNo">1289</span>  }<a name="line.1289"></a>
+<span class="sourceLineNo">1290</span><a name="line.1290"></a>
+<span class="sourceLineNo">1291</span>  public ErrorReporter getErrors() {<a name="line.1291"></a>
+<span class="sourceLineNo">1292</span>    return errors;<a name="line.1292"></a>
+<span class="sourceLineNo">1293</span>  }<a name="line.1293"></a>
+<span class="sourceLineNo">1294</span><a name="line.1294"></a>
+<span class="sourceLineNo">1295</span>  /**<a name="line.1295"></a>
+<span class="sourceLineNo">1296</span>   * Read the .regioninfo file from the file system.  If there is no<a name="line.1296"></a>
+<span class="sourceLineNo">1297</span>   * .regioninfo, add it to the orphan hdfs region list.<a name="line.1297"></a>
+<span class="sourceLineNo">1298</span>   */<a name="line.1298"></a>
+<span class="sourceLineNo">1299</span>  private void loadHdfsRegioninfo(HbckInfo hbi) throws IOException {<a name="line.1299"></a>
+<span class="sourceLineNo">1300</span>    Path regionDir = hbi.getHdfsRegionDir();<a name="line.1300"></a>
+<span class="sourceLineNo">1301</span>    if (regionDir == null) {<a name="line.1301"></a>
+<span class="sourceLineNo">1302</span>      if (hbi.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.1302"></a>
+<span class="sourceLineNo">1303</span>        // Log warning only for default/ primary replica with no region dir<a name="line.1303"></a>
+<span class="sourceLineNo">1304</span>        LOG.warn("No HDFS region dir found: " + hbi + " meta=" + hbi.metaEntry);<a name="line.1304"></a>
+<span class="sourceLineNo">1305</span>      }<a name="line.1305"></a>
+<span class="sourceLineNo">1306</span>      return;<a name="line.1306"></a>
+<span class="sourceLineNo">1307</span>    }<a name="line.1307"></a>
+<span class="sourceLineNo">1308</span><a name="line.1308"></a>
+<span class="sourceLineNo">1309</span>    if (hbi.hdfsEntry.hri != null) {<a name="line.1309"></a>
+<span class="sourceLineNo">1310</span>      // already loaded data<a name="line.1310"></a>
+<span class="sourceLineNo">1311</span>      return;<a name="line.1311"></a>
+<span class="sourceLineNo">1312</span>    }<a name="line.1312"></a>
+<span class="sourceLineNo">1313</span><a name="line.1313"></a>
+<span class="sourceLineNo">1314</span>    FileSystem fs = FileSystem.get(getConf());<a name="line.1314"></a>
+<span class="sourceLineNo">1315</span>    RegionInfo hri = HRegionFileSystem.loadRegionInfoFileContent(fs, regionDir);<a name="line.1315"></a>
+<span class="sourceLineNo">1316</span>    LOG.debug("RegionInfo read: " + hri.toString());<a name="line.1316"></a>
+<span class="sourceLineNo">1317</span>    hbi.hdfsEntry.hri = hri;<a name="line.1317"></a>
+<span class="sourceLineNo">1318</span>  }<a name="line.1318"></a>
+<span class="sourceLineNo">1319</span><a name="line.1319"></a>
+<span class="sourceLineNo">1320</span>  /**<a name="line.1320"></a>
+<span class="sourceLineNo">1321</span>   * Exception thrown when a integrity repair operation fails in an<a name="line.1321"></a>
+<span class="sourceLineNo">1322</span>   * unresolvable way.<a name="line.1322"></a>
+<span class="sourceLineNo">1323</span>   */<a name="line.1323"></a>
+<span class="sourceLineNo">1324</span>  public static class RegionRepairException extends IOException {<a name="line.1324"></a>
+<span class="sourceLineNo">1325</span>    private static final long serialVersionUID = 1L;<a name="line.1325"></a>
+<span class="sourceLineNo">1326</span>    final IOException ioe;<a name="line.1326"></a>
+<span class="sourceLineNo">1327</span>    public RegionRepairException(String s, IOException ioe) {<a name="line.1327"></a>
+<span class="sourceLineNo">1328</span>      super(s);<a name="line.1328"></a>
+<span class="sourceLineNo">1329</span>      this.ioe = ioe;<a name="line.1329"></a>
+<span class="sourceLineNo">1330</span>    }<a name="line.1330"></a>
+<span class="sourceLineNo">1331</span>  }<a name="line.1331"></a>
+<span class="sourceLineNo">1332</span><a name="line.1332"></a>
+<span class="sourceLineNo">1333</span>  /**<a name="line.1333"></a>
+<span class="sourceLineNo">1334</span>   * Populate hbi's from regionInfos loaded from file system.<a name="line.1334"></a>
+<span class="sourceLineNo">1335</span>   */<a name="line.1335"></a>
+<span class="sourceLineNo">1336</span>  private SortedMap&lt;TableName, TableInfo&gt; loadHdfsRegionInfos()<a name="line.1336"></a>
+<span class="sourceLineNo">1337</span>      throws IOException, InterruptedException {<a name="line.1337"></a>
+<span class="sourceLineNo">1338</span>    tablesInfo.clear(); // regenerating the data<a name="line.1338"></a>
+<span class="sourceLineNo">1339</span>    // generate region split structure<a name="line.1339"></a>
+<span class="sourceLineNo">1340</span>    Collection&lt;HbckInfo&gt; hbckInfos = regionInfoMap.values();<a name="line.1340"></a>
+<span class="sourceLineNo">1341</span><a name="line.1341"></a>
+<span class="sourceLineNo">1342</span>    // Parallelized read of .regioninfo files.<a name="line.1342"></a>
+<span class="sourceLineNo">1343</span>    List&lt;WorkItemHdfsRegionInfo&gt; hbis = new ArrayList&lt;&gt;(hbckInfos.size());<a name="line.1343"></a>
+<span class="sourceLineNo">1344</span>    List&lt;Future&lt;Void&gt;&gt; hbiFutures;<a name="line.1344"></a>
+<span class="sourceLineNo">1345</span><a name="line.1345"></a>
+<span class="sourceLineNo">1346</span>    for (HbckInfo hbi : hbckInfos) {<a name="line.1346"></a>
+<span class="sourceLineNo">1347</span>      WorkItemHdfsRegionInfo work = new WorkItemHdfsRegionInfo(hbi, this, errors);<a name="line.1347"></a>
+<span class="sourceLineNo">1348</span>      hbis.add(work);<a name="line.1348"></a>
+<span class="sourceLineNo">1349</span>    }<a name="line.1349"></a>
+<span class="sourceLineNo">1350</span><a name="line.1350"></a>
+<span class="sourceLineNo">1351</span>    // Submit and wait for completion<a name="line.1351"></a>
+<span class="sourceLineNo">1352</span>    hbiFutures = executor.invokeAll(hbis);<a name="line.1352"></a>
+<span class="sourceLineNo">1353</span><a name="line.1353"></a>
+<span class="sourceLineNo">1354</span>    for(int i=0; i&lt;hbiFutures.size(); i++) {<a name="line.1354"></a>
+<span class="sourceLineNo">1355</span>      WorkItemHdfsRegionInfo work = hbis.get(i);<a name="line.1355"></a>
+<span class="sourceLineNo">1356</span>      Future&lt;Void&gt; f = hbiFutures.get(i);<a name="line.1356"></a>
+<span class="sourceLineNo">1357</span>      try {<a name="line.1357"></a>
+<span class="sourceLineNo">1358</span>        f.get();<a name="line.1358"></a>
+<span class="sourceLineNo">1359</span>      } catch(ExecutionException e) {<a name="line.1359"></a>
+<span class="sourceLineNo">1360</span>        LOG.warn("Failed to read .regioninfo file for region " +<a name="line.1360"></a>
+<span class="sourceLineNo">1361</span>              work.hbi.getRegionNameAsString(), e.getCause());<a name="line.1361"></a>
+<span class="sourceLineNo">1362</span>      }<a name="line.1362"></a>
+<span class="sourceLineNo">1363</span>    }<a name="line.1363"></a>
+<span class="sourceLineNo">1364</span><a name="line.1364"></a>
+<span class="sourceLineNo">1365</span>    Path hbaseRoot = FSUtils.getRootDir(getConf());<a name="line.1365"></a>
+<span class="sourceLineNo">1366</span>    FileSystem fs = hbaseRoot.getFileSystem(getConf());<a name="line.1366"></a>
+<span class="sourceLineNo">1367</span>    // serialized table info gathering.<a name="line.1367"></a>
+<span class="sourceLineNo">1368</span>    for (HbckInfo hbi: hbckInfos) {<a name="line.1368"></a>
+<span class="sourceLineNo">1369</span><a name="line.1369"></a>
+<span class="sourceLineNo">1370</span>      if (hbi.getHdfsHRI() == null) {<a name="line.1370"></a>
+<span class="sourceLineNo">1371</span>        // was an orphan<a name="line.1371"></a>
+<span class="sourceLineNo">1372</span>        continue;<a name="line.1372"></a>
+<span class="sourceLineNo">1373</span>      }<a name="line.1373"></a>
+<span class="sourceLineNo">1374</span><a name="line.1374"></a>
 <span class="sourceLineNo">1375</span><a name="line.1375"></a>
-<span class="sourceLineNo">1376</span><a name="line.1376"></a>
-<span class="sourceLineNo">1377</span>      // get table name from hdfs, populate various HBaseFsck tables.<a name="line.1377"></a>
-<span class="sourceLineNo">1378</span>      TableName tableName = hbi.getTableName();<a name="line.1378"></a>
-<span class="sourceLineNo">1379</span>      if (tableName == null) {<a name="line.1379"></a>
-<span class="sourceLineNo">1380</span>        // There was an entry in hbase:meta not in the HDFS?<a name="line.1380"></a>
-<span class="sourceLineNo">1381</span>        LOG.warn("tableName was null for: " + hbi);<a name="line.1381"></a>
-<span class="sourceLineNo">1382</span>        continue;<a name="line.1382"></a>
-<span class="sourceLineNo">1383</span>      }<a name="line.1383"></a>
-<span class="sourceLineNo">1384</span><a name="line.1384"></a>
-<span class="sourceLineNo">1385</span>      TableInfo modTInfo = tablesInfo.get(tableName);<a name="line.1385"></a>
-<span class="sourceLineNo">1386</span>      if (modTInfo == null) {<a name="line.1386"></a>
-<span class="sourceLineNo">1387</span>        // only executed once per table.<a name="line.1387"></a>
-<span class="sourceLineNo">1388</span>        modTInfo = new TableInfo(tableName);<a name="line.1388"></a>
-<span class="sourceLineNo">1389</span>        tablesInfo.put(tableName, modTInfo);<a name="line.1389"></a>
-<span class="sourceLineNo">1390</span>        try {<a name="line.1390"></a>
-<span class="sourceLineNo">1391</span>          TableDescriptor htd =<a name="line.1391"></a>
-<span class="sourceLineNo">1392</span>              FSTableDescriptors.getTableDescriptorFromFs(fs, hbaseRoot, tableName);<a name="line.1392"></a>
-<span class="sourceLineNo">1393</span>          modTInfo.htds.add(htd);<a name="line.1393"></a>
-<span class="sourceLineNo">1394</span>        } catch (IOException ioe) {<a name="line.1394"></a>
-<span class="sourceLineNo">1395</span>          if (!orphanTableDirs.containsKey(tableName)) {<a name="line.1395"></a>
-<span class="sourceLineNo">1396</span>            LOG.warn("Unable to read .tableinfo from " + hbaseRoot, ioe);<a name="line.1396"></a>
-<span class="sourceLineNo">1397</span>            //should only report once for each table<a name="line.1397"></a>
-<span class="sourceLineNo">1398</span>            errors.reportError(ERROR_CODE.NO_TABLEINFO_FILE,<a name="line.1398"></a>
-<span class="sourceLineNo">1399</span>                "Unable to read .tableinfo from " + hbaseRoot + "/" + tableName);<a name="line.1399"></a>
-<span class="sourceLineNo">1400</span>            Set&lt;String&gt; columns = new HashSet&lt;&gt;();<a name="line.1400"></a>
-<span class="sourceLineNo">1401</span>            orphanTableDirs.put(tableName, getColumnFamilyList(columns, hbi));<a name="line.1401"></a>
-<span class="sourceLineNo">1402</span>          }<a name="line.1402"></a>
-<span class="sourceLineNo">1403</span>        }<a name="line.1403"></a>
-<span class="sourceLineNo">1404</span>      }<a name="line.1404"></a>
-<span class="sourceLineNo">1405</span>      if (!hbi.isSkipChecks()) {<a name="line.1405"></a>
-<span class="sourceLineNo">1406</span>        modTInfo.addRegionInfo(hbi);<a name="line.1406"></a>
-<span class="sourceLineNo">1407</span>      }<a name="line.1407"></a>
-<span class="sourceLineNo">1408</span>    }<a name="line.1408"></a>
-<span class="sourceLineNo">1409</span><a name="line.1409"></a>
-<span class="sourceLineNo">1410</span>    loadTableInfosForTablesWithNoRegion();<a name="line.1410"></a>
-<span class="sourceLineNo">1411</span>    errors.print("");<a name="line.1411"></a>
-<span class="sourceLineNo">1412</span><a name="line.1412"></a>
-<span class="sourceLineNo">1413</span>    return tablesInfo;<a name="line.1413"></a>
-<span class="sourceLineNo">1414</span>  }<a name="line.1414"></a>
-<span class="sourceLineNo">1415</span><a name="line.1415"></a>
-<span class="sourceLineNo">1416</span>  /**<a name="line.1416"></a>
-<span class="sourceLineNo">1417</span>   * To get the column family list according to the column family dirs<a name="line.1417"></a>
-<span class="sourceLineNo">1418</span>   * @param columns<a name="line.1418"></a>
-<span class="sourceLineNo">1419</span>   * @param hbi<a name="line.1419"></a>
-<span class="sourceLineNo">1420</span>   * @return a set of column families<a name="line.1420"></a>
-<span class="sourceLineNo">1421</span>   * @throws IOException<a name="line.1421"></a>
-<span class="sourceLineNo">1422</span>   */<a name="line.1422"></a>
-<span class="sourceLineNo">1423</span>  private Set&lt;String&gt; getColumnFamilyList(Set&lt;String&gt; columns, HbckInfo hbi) throws IOException {<a name="line.1423"></a>
-<span class="sourceLineNo">1424</span>    Path regionDir = hbi.getHdfsRegionDir();<a name="line.1424"></a>
-<span class="sourceLineNo">1425</span>    FileSystem fs = regionDir.getFileSystem(getConf());<a name="line.1425"></a>
-<span class="sourceLineNo">1426</span>    FileStatus[] subDirs = fs.listStatus(regionDir, new FSUtils.FamilyDirFilter(fs));<a name="line.1426"></a>
-<span class="sourceLineNo">1427</span>    for (FileStatus subdir : subDirs) {<a name="line.1427"></a>
-<span class="sourceLineNo">1428</span>      String columnfamily = subdir.getPath().getName();<a name="line.1428"></a>
-<span class="sourceLineNo">1429</span>      columns.add(columnfamily);<a name="line.1429"></a>
-<span class="sourceLineNo">1430</span>    }<a name="line.1430"></a>
-<span class="sourceLineNo">1431</span>    return columns;<a name="line.1431"></a>
-<span class="sourceLineNo">1432</span>  }<a name="line.1432"></a>
-<span class="sourceLineNo">1433</span><a name="line.1433"></a>
-<span class="sourceLineNo">1434</span>  /**<a name="line.1434"></a>
-<span class="sourceLineNo">1435</span>   * To fabricate a .tableinfo file with following contents&lt;br&gt;<a name="line.1435"></a>
-<span class="sourceLineNo">1436</span>   * 1. the correct tablename &lt;br&gt;<a name="line.1436"></a>
-<span class="sourceLineNo">1437</span>   * 2. the correct colfamily list&lt;br&gt;<a name="line.1437"></a>
-<span class="sourceLineNo">1438</span>   * 3. the default properties for both {@link TableDescriptor} and {@link ColumnFamilyDescriptor}&lt;br&gt;<a name="line.1438"></a>
-<span class="sourceLineNo">1439</span>   * @throws IOException<a name="line.1439"></a>
-<span class="sourceLineNo">1440</span>   */<a name="line.1440"></a>
-<span class="sourceLineNo">1441</span>  private boolean fabricateTableInfo(FSTableDescriptors fstd, TableName tableName,<a name="line.1441"></a>
-<span class="sourceLineNo">1442</span>      Set&lt;String&gt; columns) throws IOException {<a name="line.1442"></a>
-<span class="sourceLineNo">1443</span>    if (columns ==null || columns.isEmpty()) return false;<a name="line.1443"></a>
-<span class="sourceLineNo">1444</span>    TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(tableName);<a name="line.1444"></a>
-<span class="sourceLineNo">1445</span>    for (String columnfamimly : columns) {<a name="line.1445"></a>
-<span class="sourceLineNo">1446</span>      builder.setColumnFamily(ColumnFamilyDescriptorBuilder.of(columnfamimly));<a name="line.1446"></a>
-<span class="sourceLineNo">1447</span>    }<a name="line.1447"></a>
-<span class="sourceLineNo">1448</span>    fstd.createTableDescriptor(builder.build(), true);<a name="line.1448"></a>
-<span class="sourceLineNo">1449</span>    return true;<a name="line.1449"></a>
-<span class="sourceLineNo">1450</span>  }<a name="line.1450"></a>
-<span class="sourceLineNo">1451</span><a name="line.1451"></a>
-<span class="sourceLineNo">1452</span>  /**<a name="line.1452"></a>
-<span class="sourceLineNo">1453</span>   * To fix the empty REGIONINFO_QUALIFIER rows from hbase:meta &lt;br&gt;<a name="line.1453"></a>
-<span class="sourceLineNo">1454</span>   * @throws IOException<a name="line.1454"></a>
-<span class="sourceLineNo">1455</span>   */<a name="line.1455"></a>
-<span class="sourceLineNo">1456</span>  public void fixEmptyMetaCells() throws IOException {<a name="line.1456"></a>
-<span class="sourceLineNo">1457</span>    if (shouldFixEmptyMetaCells() &amp;&amp; !emptyRegionInfoQualifiers.isEmpty()) {<a name="line.1457"></a>
-<span class="sourceLineNo">1458</span>      LOG.info("Trying to fix empty REGIONINFO_QUALIFIER hbase:meta rows.");<a name="line.1458"></a>
-<span class="sourceLineNo">1459</span>      for (Result region : emptyRegionInfoQualifiers) {<a name="line.1459"></a>
-<span class="sourceLineNo">1460</span>        deleteMetaRegion(region.getRow());<a name="line.1460"></a>
-<span class="sourceLineNo">1461</span>        errors.getErrorList().remove(ERROR_CODE.EMPTY_META_CELL);<a name="line.1461"></a>
-<span class="sourceLineNo">1462</span>      }<a name="line.1462"></a>
-<span class="sourceLineNo">1463</span>      emptyRegionInfoQualifiers.clear();<a name="line.1463"></a>
-<span class="sourceLineNo">1464</span>    }<a name="line.1464"></a>
-<span class="sourceLineNo">1465</span>  }<a name="line.1465"></a>
-<span class="sourceLineNo">1466</span><a name="line.1466"></a>
-<span class="sourceLineNo">1467</span>  /**<a name="line.1467"></a>
-<span class="sourceLineNo">1468</span>   * To fix orphan table by creating a .tableinfo file under tableDir &lt;br&gt;<a name="line.1468"></a>
-<span class="sourceLineNo">1469</span>   * 1. if TableInfo is cached, to recover the .tableinfo accordingly &lt;br&gt;<a name="line.1469"></a>
-<span class="sourceLineNo">1470</span>   * 2. else create a default .tableinfo file with following items&lt;br&gt;<a name="line.1470"></a>
-<span class="sourceLineNo">1471</span>   * &amp;nbsp;2.1 the correct tablename &lt;br&gt;<a name="line.1471"></a>
-<span class="sourceLineNo">1472</span>   * &amp;nbsp;2.2 the correct colfamily list&lt;br&gt;<a name="line.1472"></a>
-<span class="sourceLineNo">1473</span>   * &amp;nbsp;2.3 the default properties for both {@link TableDescriptor} and {@link ColumnFamilyDescriptor}&lt;br&gt;<a name="line.1473"></a>
-<span class="sourceLineNo">1474</span>   * @throws IOException<a name="line.1474"></a>
-<span class="sourceLineNo">1475</span>   */<a name="line.1475"></a>
-<span class="sourceLineNo">1476</span>  public void fixOrphanTables() throws IOException {<a name="line.1476"></a>
-<span class="sourceLineNo">1477</span>    if (shouldFixTableOrphans() &amp;&amp; !orphanTableDirs.isEmpty()) {<a name="line.1477"></a>
-<span class="sourceLineNo">1478</span><a name="line.1478"></a>
-<span class="sourceLineNo">1479</span>      List&lt;TableName&gt; tmpList = new ArrayList&lt;&gt;(orphanTableDirs.keySet().size());<a name="line.1479"></a>
-<span class="sourceLineNo">1480</span>      tmpList.addAll(orphanTableDirs.keySet());<a name="line.1480"></a>
-<span class="sourceLineNo">1481</span>      TableDescriptor[] htds = getTableDescriptors(tmpList);<a name="line.1481"></a>
-<span class="sourceLineNo">1482</span>      Iterator&lt;Entry&lt;TableName, Set&lt;String&gt;&gt;&gt; iter =<a name="line.1482"></a>
-<span class="sourceLineNo">1483</span>          orphanTableDirs.entrySet().iterator();<a name="line.1483"></a>
-<span class="sourceLineNo">1484</span>      int j = 0;<a name="line.1484"></a>
-<span class="sourceLineNo">1485</span>      int numFailedCase = 0;<a name="line.1485"></a>
-<span class="sourceLineNo">1486</span>      FSTableDescriptors fstd = new FSTableDescriptors(getConf());<a name="line.1486"></a>
-<span class="sourceLineNo">1487</span>      while (iter.hasNext()) {<a name="line.1487"></a>
-<span class="sourceLineNo">1488</span>        Entry&lt;TableName, Set&lt;String&gt;&gt; entry =<a name="line.1488"></a>
-<span class="sourceLineNo">1489</span>            iter.next();<a name="line.1489"></a>
-<span class="sourceLineNo">1490</span>        TableName tableName = entry.getKey();<a name="line.1490"></a>
-<span class="sourceLineNo">1491</span>        LOG.info("Trying to fix orphan table error: " + tableName);<a name="line.1491"></a>
-<span class="sourceLineNo">1492</span>        if (j &lt; htds.length) {<a name="line.1492"></a>
-<span class="sourceLineNo">1493</span>          if (tableName.equals(htds[j].getTableName())) {<a name="line.1493"></a>
-<span class="sourceLineNo">1494</span>            TableDescriptor htd = htds[j];<a name="line.1494"></a>
-<span class="sourceLineNo">1495</span>            LOG.info("fixing orphan table: " + tableName + " from cache");<a name="line.1495"></a>
-<span class="sourceLineNo">1496</span>            fstd.createTableDescriptor(htd, true);<a name="line.1496"></a>
-<span class="sourceLineNo">1497</span>            j++;<a name="line.1497"></a>
-<span class="sourceLineNo">1498</span>            iter.remove();<a name="line.1498"></a>
-<span class="sourceLineNo">1499</span>          }<a name="line.1499"></a>
-<span class="sourceLineNo">1500</span>        } else {<a name="line.1500"></a>
-<span class="sourceLineNo">1501</span>          if (fabricateTableInfo(fstd, tableName, entry.getValue())) {<a name="line.1501"></a>
-<span class="sourceLineNo">1502</span>            LOG.warn("fixing orphan table: " + tableName + " with a default .tableinfo file");<a name="line.1502"></a>
-<span class="sourceLineNo">1503</span>            LOG.warn("Strongly recommend to modify the TableDescriptor if necessary for: " + tableName);<a name="line.1503"></a>
-<span class="sourceLineNo">1504</span>            iter.remove();<a name="line.1504"></a>
-<span class="sourceLineNo">1505</span>          } else {<a name="line.1505"></a>
-<span class="sourceLineNo">1506</span>            LOG.error("Unable to create default .tableinfo for " + tableName + " while missing column family information");<a name="line.1506"></a>
-<span class="sourceLineNo">1507</span>            numFailedCase++;<a name="line.1507"></a>
-<span class="sourceLineNo">1508</span>          }<a name="line.1508"></a>
-<span class="sourceLineNo">1509</span>        }<a name="line.1509"></a>
-<span class="sourceLineNo">1510</span>        fixes++;<a name="line.1510"></a>
-<span class="sourceLineNo">1511</span>      }<a name="line.1511"></a>
-<span class="sourceLineNo">1512</span><a name="line.1512"></a>
-<span class="sourceLineNo">1513</span>      if (orphanTableDirs.isEmpty()) {<a name="line.1513"></a>
-<span class="sourceLineNo">1514</span>        // all orphanTableDirs are luckily recovered<a name="line.1514"></a>
-<span class="sourceLineNo">1515</span>        // re-run doFsck after recovering the .tableinfo file<a name="line.1515"></a>
-<span class="sourceLineNo">1516</span>        setShouldRerun();<a name="line.1516"></a>
-<span class="sourceLineNo">1517</span>        LOG.warn("Strongly recommend to re-run manually hfsck after all orphanTableDirs being fixed");<a name="line.1517"></a>
-<span class="sourceLineNo">1518</span>      } else if (numFailedCase &gt; 0) {<a name="line.1518"></a>
-<span class="sourceLineNo">1519</span>        LOG.error("Failed to fix " + numFailedCase<a name="line.1519"></a>
-<span class="sourceLineNo">1520</span>            + " OrphanTables with default .tableinfo files");<a name="line.1520"></a>
-<span class="sourceLineNo">1521</span>      }<a name="line.1521"></a>
-<span class="sourceLineNo">1522</span><a name="line.1522"></a>
-<span class="sourceLineNo">1523</span>    }<a name="line.1523"></a>
-<span class="sourceLineNo">1524</span>    //cleanup the list<a name="line.1524"></a>
-<span class="sourceLineNo">1525</span>    orphanTableDirs.clear();<a name="line.1525"></a>
-<span class="sourceLineNo">1526</span><a name="line.1526"></a>
-<span class="sourceLineNo">1527</span>  }<a name="line.1527"></a>
-<span class="sourceLineNo">1528</span><a name="line.1528"></a>
-<span class="sourceLineNo">1529</span>  /**<a name="line.1529"></a>
-<span class="sourceLineNo">1530</span>   * This borrows code from MasterFileSystem.bootstrap(). Explicitly creates it's own WAL, so be<a name="line.1530"></a>
-<span class="sourceLineNo">1531</span>   * sure to close it as well as the region when you're finished.<a name="line.1531"></a>
-<span class="sourceLineNo">1532</span>   * @param walFactoryID A unique identifier for WAL factory. Filesystem implementations will use<a name="line.1532"></a>
-<span class="sourceLineNo">1533</span>   *          this ID to make a directory inside WAL directory path.<a name="line.1533"></a>
-<span class="sourceLineNo">1534</span>   * @return an open hbase:meta HRegion<a name="line.1534"></a>
-<span class="sourceLineNo">1535</span>   */<a name="line.1535"></a>
-<span class="sourceLineNo">1536</span>  private HRegion createNewMeta(String walFactoryID) throws IOException {<a name="line.1536"></a>
-<span class="sourceLineNo">1537</span>    Path rootdir = FSUtils.getRootDir(getConf());<a name="line.1537"></a>
-<span class="sourceLineNo">1538</span>    Configuration c = getConf();<a name="line.1538"></a>
-<span class="sourceLineNo">1539</span>    RegionInfo metaHRI = RegionInfoBuilder.FIRST_META_REGIONINFO;<a name="line.1539"></a>
-<span class="sourceLineNo">1540</span>    TableDescriptor metaDescriptor = new FSTableDescriptors(c).get(TableName.META_TABLE_NAME);<a name="line.1540"></a>
-<span class="sourceLineNo">1541</span>    MasterFileSystem.setInfoFamilyCachingForMeta(metaDescriptor, false);<a name="line.1541"></a>
-<span class="sourceLineNo">1542</span>    // The WAL subsystem will use the default rootDir rather than the passed in rootDir<a name="line.1542"></a>
-<span class="sourceLineNo">1543</span>    // unless I pass along via the conf.<a name="line.1543"></a>
-<spa

<TRUNCATED>