[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #7354: [ISSUE #7353] Topic creation and deletion commands act on slave nodes

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #7354:
URL: https://github.com/apache/rocketmq/pull/7354#discussion_r1325252365


##########
tools/src/main/java/org/apache/rocketmq/tools/command/topic/UpdateTopicSubCommand.java:
##########
@@ -168,7 +168,7 @@ public void execute(final CommandLine commandLine, final Options options,
                 defaultMQAdminExt.start();
 
                 Set<String> masterSet =
-                    CommandUtil.fetchMasterAddrByClusterName(defaultMQAdminExt, clusterName);
+                    CommandUtil.fetchMasterAndSlaveAddrByClusterName(defaultMQAdminExt, clusterName);

Review Comment:
   Same as above



##########
tools/src/main/java/org/apache/rocketmq/tools/command/topic/DeleteTopicSubCommand.java:
##########
@@ -38,7 +38,7 @@ public static void deleteTopic(final DefaultMQAdminExt adminExt,
         final String topic
     ) throws InterruptedException, MQBrokerException, RemotingException, MQClientException {
 
-        Set<String> masterBrokerAddressSet = CommandUtil.fetchMasterAddrByClusterName(adminExt, clusterName);
+        Set<String> masterBrokerAddressSet = CommandUtil.fetchMasterAndSlaveAddrByClusterName(adminExt, clusterName);

Review Comment:
   It would be better to rename `masterBrokerAddressSet` to `brokerAddressSet`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org