You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/06/26 10:03:30 UTC
[camel] branch main updated: (chores) camel-openstack: fixed missing assertions
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new b398e59d471 (chores) camel-openstack: fixed missing assertions
b398e59d471 is described below
commit b398e59d4715fcbe5f3feb238acb0b2de4c1f875
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Sun Jun 26 11:08:47 2022 +0200
(chores) camel-openstack: fixed missing assertions
---
.../camel/component/openstack/it/OpenstackCinderVolumeTest.java | 6 ++++--
.../apache/camel/component/openstack/it/OpenstackGlanceTest.java | 4 +++-
.../camel/component/openstack/it/OpenstackKeystoneDomainTest.java | 3 ++-
.../camel/component/openstack/it/OpenstackKeystoneGroupTest.java | 7 ++++---
.../camel/component/openstack/it/OpenstackKeystoneProjectTest.java | 3 ++-
.../camel/component/openstack/it/OpenstackKeystoneRegionTest.java | 3 ++-
.../camel/component/openstack/it/OpenstackKeystoneUserTest.java | 3 ++-
.../camel/component/openstack/it/OpenstackNeutronNetworkTest.java | 3 ++-
8 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackCinderVolumeTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackCinderVolumeTest.java
index e7faa80510f..793a5ec1ef2 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackCinderVolumeTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackCinderVolumeTest.java
@@ -28,6 +28,7 @@ import org.openstack4j.model.storage.block.Volume;
import org.openstack4j.model.storage.block.VolumeAttachment;
import org.openstack4j.model.storage.block.VolumeType;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -118,12 +119,13 @@ public class OpenstackCinderVolumeTest extends OpenstackWiremockTestSupport {
headers.put(CinderConstants.IS_BOOTABLE, false);
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.UPDATE);
- template.requestBodyAndHeaders(uri, null, headers);
+ assertDoesNotThrow(() -> template.requestBodyAndHeaders(uri, null, headers));
}
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, CinderConstants.VOLUME_ID, "fffab33e-38e8-4626-9fee-fe90f240ff0f");
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, CinderConstants.VOLUME_ID,
+ "fffab33e-38e8-4626-9fee-fe90f240ff0f"));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackGlanceTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackGlanceTest.java
index 4c8f5b59afa..93da9987d53 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackGlanceTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackGlanceTest.java
@@ -30,6 +30,7 @@ import org.openstack4j.model.image.ContainerFormat;
import org.openstack4j.model.image.DiskFormat;
import org.openstack4j.model.image.Image;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -98,6 +99,7 @@ public class OpenstackGlanceTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, "8a2ea42d-06b5-42c2-a54d-97105420f2bb");
+ assertDoesNotThrow(
+ () -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, "8a2ea42d-06b5-42c2-a54d-97105420f2bb"));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneDomainTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneDomainTest.java
index 8d846e44306..1007ec30a25 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneDomainTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneDomainTest.java
@@ -22,6 +22,7 @@ import org.junit.jupiter.api.Test;
import org.openstack4j.api.Builders;
import org.openstack4j.model.identity.v3.Domain;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -90,6 +91,6 @@ public class OpenstackKeystoneDomainTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, DOMAIN_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, DOMAIN_ID));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneGroupTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneGroupTest.java
index b864a4606b6..9da6cc25bff 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneGroupTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneGroupTest.java
@@ -25,6 +25,7 @@ import org.junit.jupiter.api.Test;
import org.openstack4j.api.Builders;
import org.openstack4j.model.identity.v3.Group;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -97,7 +98,7 @@ public class OpenstackKeystoneGroupTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, GROUP_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, GROUP_ID));
}
@Test
@@ -107,7 +108,7 @@ public class OpenstackKeystoneGroupTest extends OpenstackWiremockTestSupport {
headers.put(KeystoneConstants.GROUP_ID, "851398fccda34f208e1839ebbc1251d1");
String uri = String.format(URI_FORMAT, url(), KeystoneConstants.ADD_USER_TO_GROUP);
- template.requestBodyAndHeaders(uri, null, headers, Group.class);
+ assertDoesNotThrow(() -> template.requestBodyAndHeaders(uri, null, headers, Group.class));
}
@Test
@@ -128,6 +129,6 @@ public class OpenstackKeystoneGroupTest extends OpenstackWiremockTestSupport {
headers.put(KeystoneConstants.GROUP_ID, "851398fccda34f208e1839ebbc1251d1");
String uri = String.format(URI_FORMAT, url(), KeystoneConstants.REMOVE_USER_FROM_GROUP);
- template.requestBodyAndHeaders(uri, null, headers);
+ assertDoesNotThrow(() -> template.requestBodyAndHeaders(uri, null, headers));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneProjectTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneProjectTest.java
index eea327a013f..b32832eb911 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneProjectTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneProjectTest.java
@@ -25,6 +25,7 @@ import org.junit.jupiter.api.Test;
import org.openstack4j.api.Builders;
import org.openstack4j.model.identity.v3.Project;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -111,7 +112,7 @@ public class OpenstackKeystoneProjectTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, PROJECT_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, PROJECT_ID));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneRegionTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneRegionTest.java
index 125e3fa0b83..97545044010 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneRegionTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneRegionTest.java
@@ -22,6 +22,7 @@ import org.junit.jupiter.api.Test;
import org.openstack4j.api.Builders;
import org.openstack4j.model.identity.v3.Region;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
@@ -90,7 +91,7 @@ public class OpenstackKeystoneRegionTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, REGION_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, REGION_ID));
}
@Test
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneUserTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneUserTest.java
index 5a85ece959a..5fcbda9ab1c 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneUserTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackKeystoneUserTest.java
@@ -22,6 +22,7 @@ import org.junit.jupiter.api.Test;
import org.openstack4j.api.Builders;
import org.openstack4j.model.identity.v3.User;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
@@ -93,6 +94,6 @@ public class OpenstackKeystoneUserTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, USER_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, USER_ID));
}
}
diff --git a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackNeutronNetworkTest.java b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackNeutronNetworkTest.java
index dd11462c90d..3e37df5cd9e 100644
--- a/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackNeutronNetworkTest.java
+++ b/components/camel-openstack/src/test/java/org/apache/camel/component/openstack/it/OpenstackNeutronNetworkTest.java
@@ -24,6 +24,7 @@ import org.openstack4j.model.network.Network;
import org.openstack4j.model.network.NetworkType;
import org.openstack4j.model.network.State;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -80,6 +81,6 @@ public class OpenstackNeutronNetworkTest extends OpenstackWiremockTestSupport {
@Test
void deleteShouldSucceed() {
String uri = String.format(URI_FORMAT, url(), OpenstackConstants.DELETE);
- template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, NETWORK_ID);
+ assertDoesNotThrow(() -> template.requestBodyAndHeader(uri, null, OpenstackConstants.ID, NETWORK_ID));
}
}