You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Chao Huang <ch...@gmail.com> on 2012/06/15 10:25:25 UTC
[Call-for-Review] Some issue about memory leak in Aoo3.4
hi, all
I'm Huang Chao from China. My interesting areas are Mac porting,
performance(startup, loading, saving, etc), stability, build env.
At recent stage, I will focus on memory leak issue in Aoo3.4.
Here are the fixed for memory leak defects I opened. Please confirm them
and review them. I will continue to work on this area. Thanks!
https://issues.apache.org/ooo/show_bug.cgi?id=119991
https://issues.apache.org/ooo/show_bug.cgi?id=119992
https://issues.apache.org/ooo/show_bug.cgi?id=119996
https://issues.apache.org/ooo/show_bug.cgi?id=119997
Please note that the patches for bug119996 and bug119997 are on the same
source file.
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
Jurgen, thanks for your reminder.
It's very useful for me to know the changes on code base / document / wiki
2012/6/21 Jürgen Schmidt <jo...@googlemail.com>
> On 6/21/12 7:56 AM, Chao Huang wrote:
> > All the fixed are included in R1352129. You can use the build after
> > R1352129.
> >
> > What's the revision of the latest build on buildbot?
>
> for developers I recommend to subscribe to the ooo-commits mailing list.
> Here you can see all commits (on the webpage, the code repository) and
> will also see status mails from the build bots.
>
> These mails contains further info about the build. See for example
> http://ci.apache.org/builders/aoo-win7/builds/205 of the Win7 build bot
> which failed last night.
>
> Further useful links regarding the build bots
>
> - http://ci.apache.org/projects/openoffice/install/ -> where you can
> find the final builds
>
> - http://ci.apache.org/projects/openoffice/rat-output.html -> the RAT
> tool report
>
> - http://ci.apache.org/projects/openoffice/buildlogs/ -> build bot logs
>
> Juergen
>
> >
> >
> > 2012/6/21 Zhe Liu <al...@gmail.com>
> >
> >> Do the builds on buildbot have these code changes include?
> >> If yes, I will try compare it with my last testing.
> >>
> >> 2012/6/21 Chao Huang <ch...@gmail.com>:
> >>> The thrid batch for memory leak issue has been delivered yet. Thanks
> for
> >>> Aim's review.
> >>>
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=120038
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=120040
> >>>
> >>> Propose to put these memory leak fixed into 3.4.1
> >>>
> >>>
> >>> 2012/6/20 Chao Huang <ch...@gmail.com>
> >>>
> >>>> The second batch for memory leak issue has been delivered yet. Thanks
> >> for
> >>>> Herbert and JianFang's review.
> >>>>
> >>>> <http://goog_371113529>
> >>>> https://issues.apache.org/ooo/show_bug.cgi?id=120019
> >>>> https://issues.apache.org/ooo/show_bug.cgi?id=120021
> >>>> https://issues.apache.org/ooo/show_bug.cgi?id=120028
> >>>>
> >>>>
> >>>>
> >>>> 2012/6/15 Chao Huang <ch...@gmail.com>
> >>>>
> >>>>> hi, all
> >>>>>
> >>>>> I'm Huang Chao from China. My interesting areas are Mac porting,
> >>>>> performance(startup, loading, saving, etc), stability, build env.
> >>>>> At recent stage, I will focus on memory leak issue in Aoo3.4.
> >>>>>
> >>>>> Here are the fixed for memory leak defects I opened. Please confirm
> >> them
> >>>>> and review them. I will continue to work on this area. Thanks!
> >>>>>
> >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
> >>>>>
> >>>>> Please note that the patches for bug119996 and bug119997 are on the
> >> same
> >>>>> source file.
> >>>>>
> >>>>> --
> >>>>> Best regards,
> >>>>> Chao Huang
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Best regards,
> >>>> Chao Huang
> >>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>> Chao Huang
> >>
> >>
> >>
> >> --
> >> Best Regards
> >> From aliuzhe@gmail.com
> >>
> >
> >
> >
>
>
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/21/12 7:56 AM, Chao Huang wrote:
> All the fixed are included in R1352129. You can use the build after
> R1352129.
>
> What's the revision of the latest build on buildbot?
for developers I recommend to subscribe to the ooo-commits mailing list.
Here you can see all commits (on the webpage, the code repository) and
will also see status mails from the build bots.
These mails contains further info about the build. See for example
http://ci.apache.org/builders/aoo-win7/builds/205 of the Win7 build bot
which failed last night.
Further useful links regarding the build bots
- http://ci.apache.org/projects/openoffice/install/ -> where you can
find the final builds
- http://ci.apache.org/projects/openoffice/rat-output.html -> the RAT
tool report
- http://ci.apache.org/projects/openoffice/buildlogs/ -> build bot logs
Juergen
>
>
> 2012/6/21 Zhe Liu <al...@gmail.com>
>
>> Do the builds on buildbot have these code changes include?
>> If yes, I will try compare it with my last testing.
>>
>> 2012/6/21 Chao Huang <ch...@gmail.com>:
>>> The thrid batch for memory leak issue has been delivered yet. Thanks for
>>> Aim's review.
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120038
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120040
>>>
>>> Propose to put these memory leak fixed into 3.4.1
>>>
>>>
>>> 2012/6/20 Chao Huang <ch...@gmail.com>
>>>
>>>> The second batch for memory leak issue has been delivered yet. Thanks
>> for
>>>> Herbert and JianFang's review.
>>>>
>>>> <http://goog_371113529>
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=120019
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=120021
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>>>>
>>>>
>>>>
>>>> 2012/6/15 Chao Huang <ch...@gmail.com>
>>>>
>>>>> hi, all
>>>>>
>>>>> I'm Huang Chao from China. My interesting areas are Mac porting,
>>>>> performance(startup, loading, saving, etc), stability, build env.
>>>>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>>>>
>>>>> Here are the fixed for memory leak defects I opened. Please confirm
>> them
>>>>> and review them. I will continue to work on this area. Thanks!
>>>>>
>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>>>>
>>>>> Please note that the patches for bug119996 and bug119997 are on the
>> same
>>>>> source file.
>>>>>
>>>>> --
>>>>> Best regards,
>>>>> Chao Huang
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best regards,
>>>> Chao Huang
>>>>
>>>>
>>>
>>>
>>> --
>>> Best regards,
>>> Chao Huang
>>
>>
>>
>> --
>> Best Regards
>> From aliuzhe@gmail.com
>>
>
>
>
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Zhe Liu <al...@gmail.com>.
oops! It's 1351931.
http://ci.apache.org/projects/openoffice/install/linux32/
Anybody can provide one latest build?
2012/6/21 Chao Huang <ch...@gmail.com>:
> All the fixed are included in R1352129. You can use the build after
> R1352129.
>
> What's the revision of the latest build on buildbot?
>
>
> 2012/6/21 Zhe Liu <al...@gmail.com>
>
>> Do the builds on buildbot have these code changes include?
>> If yes, I will try compare it with my last testing.
>>
>> 2012/6/21 Chao Huang <ch...@gmail.com>:
>> > The thrid batch for memory leak issue has been delivered yet. Thanks for
>> > Aim's review.
>> >
>> > https://issues.apache.org/ooo/show_bug.cgi?id=120038
>> > https://issues.apache.org/ooo/show_bug.cgi?id=120040
>> >
>> > Propose to put these memory leak fixed into 3.4.1
>> >
>> >
>> > 2012/6/20 Chao Huang <ch...@gmail.com>
>> >
>> >> The second batch for memory leak issue has been delivered yet. Thanks
>> for
>> >> Herbert and JianFang's review.
>> >>
>> >> <http://goog_371113529>
>> >> https://issues.apache.org/ooo/show_bug.cgi?id=120019
>> >> https://issues.apache.org/ooo/show_bug.cgi?id=120021
>> >> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>> >>
>> >>
>> >>
>> >> 2012/6/15 Chao Huang <ch...@gmail.com>
>> >>
>> >>> hi, all
>> >>>
>> >>> I'm Huang Chao from China. My interesting areas are Mac porting,
>> >>> performance(startup, loading, saving, etc), stability, build env.
>> >>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>> >>>
>> >>> Here are the fixed for memory leak defects I opened. Please confirm
>> them
>> >>> and review them. I will continue to work on this area. Thanks!
>> >>>
>> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>> >>>
>> >>> Please note that the patches for bug119996 and bug119997 are on the
>> same
>> >>> source file.
>> >>>
>> >>> --
>> >>> Best regards,
>> >>> Chao Huang
>> >>>
>> >>>
>> >>
>> >>
>> >> --
>> >> Best regards,
>> >> Chao Huang
>> >>
>> >>
>> >
>> >
>> > --
>> > Best regards,
>> > Chao Huang
>>
>>
>>
>> --
>> Best Regards
>> From aliuzhe@gmail.com
>>
>
>
>
> --
> Best regards,
> Chao Huang
--
Best Regards
>From aliuzhe@gmail.com
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
All the fixed are included in R1352129. You can use the build after
R1352129.
What's the revision of the latest build on buildbot?
2012/6/21 Zhe Liu <al...@gmail.com>
> Do the builds on buildbot have these code changes include?
> If yes, I will try compare it with my last testing.
>
> 2012/6/21 Chao Huang <ch...@gmail.com>:
> > The thrid batch for memory leak issue has been delivered yet. Thanks for
> > Aim's review.
> >
> > https://issues.apache.org/ooo/show_bug.cgi?id=120038
> > https://issues.apache.org/ooo/show_bug.cgi?id=120040
> >
> > Propose to put these memory leak fixed into 3.4.1
> >
> >
> > 2012/6/20 Chao Huang <ch...@gmail.com>
> >
> >> The second batch for memory leak issue has been delivered yet. Thanks
> for
> >> Herbert and JianFang's review.
> >>
> >> <http://goog_371113529>
> >> https://issues.apache.org/ooo/show_bug.cgi?id=120019
> >> https://issues.apache.org/ooo/show_bug.cgi?id=120021
> >> https://issues.apache.org/ooo/show_bug.cgi?id=120028
> >>
> >>
> >>
> >> 2012/6/15 Chao Huang <ch...@gmail.com>
> >>
> >>> hi, all
> >>>
> >>> I'm Huang Chao from China. My interesting areas are Mac porting,
> >>> performance(startup, loading, saving, etc), stability, build env.
> >>> At recent stage, I will focus on memory leak issue in Aoo3.4.
> >>>
> >>> Here are the fixed for memory leak defects I opened. Please confirm
> them
> >>> and review them. I will continue to work on this area. Thanks!
> >>>
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
> >>>
> >>> Please note that the patches for bug119996 and bug119997 are on the
> same
> >>> source file.
> >>>
> >>> --
> >>> Best regards,
> >>> Chao Huang
> >>>
> >>>
> >>
> >>
> >> --
> >> Best regards,
> >> Chao Huang
> >>
> >>
> >
> >
> > --
> > Best regards,
> > Chao Huang
>
>
>
> --
> Best Regards
> From aliuzhe@gmail.com
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Zhe Liu <al...@gmail.com>.
Do the builds on buildbot have these code changes include?
If yes, I will try compare it with my last testing.
2012/6/21 Chao Huang <ch...@gmail.com>:
> The thrid batch for memory leak issue has been delivered yet. Thanks for
> Aim's review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=120038
> https://issues.apache.org/ooo/show_bug.cgi?id=120040
>
> Propose to put these memory leak fixed into 3.4.1
>
>
> 2012/6/20 Chao Huang <ch...@gmail.com>
>
>> The second batch for memory leak issue has been delivered yet. Thanks for
>> Herbert and JianFang's review.
>>
>> <http://goog_371113529>
>> https://issues.apache.org/ooo/show_bug.cgi?id=120019
>> https://issues.apache.org/ooo/show_bug.cgi?id=120021
>> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>>
>>
>>
>> 2012/6/15 Chao Huang <ch...@gmail.com>
>>
>>> hi, all
>>>
>>> I'm Huang Chao from China. My interesting areas are Mac porting,
>>> performance(startup, loading, saving, etc), stability, build env.
>>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>>
>>> Here are the fixed for memory leak defects I opened. Please confirm them
>>> and review them. I will continue to work on this area. Thanks!
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>>
>>> Please note that the patches for bug119996 and bug119997 are on the same
>>> source file.
>>>
>>> --
>>> Best regards,
>>> Chao Huang
>>>
>>>
>>
>>
>> --
>> Best regards,
>> Chao Huang
>>
>>
>
>
> --
> Best regards,
> Chao Huang
--
Best Regards
>From aliuzhe@gmail.com
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by zhangjf <zh...@apache.org>.
The fix code for 120669 still have some problems and need more study,
so I removed it's review tag.
And here are some more memory leak bugs with patch, please help to review again,
https://issues.apache.org/ooo/show_bug.cgi?id=120677
https://issues.apache.org/ooo/show_bug.cgi?id=120675
https://issues.apache.org/ooo/show_bug.cgi?id=120680
https://issues.apache.org/ooo/show_bug.cgi?id=120735
https://issues.apache.org/ooo/show_bug.cgi?id=120737
zhangjf
On Thu, Aug 23, 2012 at 2:00 PM, zhangjf <zh...@apache.org> wrote:
> Some more memory leak bugs, please help to have a review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=113600
> https://issues.apache.org/ooo/show_bug.cgi?id=113605
> https://issues.apache.org/ooo/show_bug.cgi?id=120669
> https://issues.apache.org/ooo/show_bug.cgi?id=120662
> https://issues.apache.org/ooo/show_bug.cgi?id=120663
> https://issues.apache.org/ooo/show_bug.cgi?id=120667
> https://issues.apache.org/ooo/show_bug.cgi?id=120668
>
> Thanks,
> Zhangjf
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by zhangjf <zh...@apache.org>.
Some more memory leak bugs, please help to have a review.
https://issues.apache.org/ooo/show_bug.cgi?id=113600
https://issues.apache.org/ooo/show_bug.cgi?id=113605
https://issues.apache.org/ooo/show_bug.cgi?id=120669
https://issues.apache.org/ooo/show_bug.cgi?id=120662
https://issues.apache.org/ooo/show_bug.cgi?id=120663
https://issues.apache.org/ooo/show_bug.cgi?id=120667
https://issues.apache.org/ooo/show_bug.cgi?id=120668
Thanks,
Zhangjf
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
The 5th batch for memory leak issue. Please help to review them. Thanks!
https://issues.apache.org/ooo/show_bug.cgi?id=120098 fixed
https://issues.apache.org/ooo/show_bug.cgi?id=120105
https://issues.apache.org/ooo/show_bug.cgi?id=120106
https://issues.apache.org/ooo/show_bug.cgi?id=120108
2012/6/25 Chao Huang <ch...@gmail.com>
> Here are the 4th batch for memory leak issue. Please help to review them.
> Thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=120050 in reviewing
> https://issues.apache.org/ooo/show_bug.cgi?id=120072 fixed
> https://issues.apache.org/ooo/show_bug.cgi?id=120073
> https://issues.apache.org/ooo/show_bug.cgi?id=120074
> https://issues.apache.org/ooo/show_bug.cgi?id=120077
> https://issues.apache.org/ooo/show_bug.cgi?id=120079
>
>
>
> 2012/6/21 Chao Huang <ch...@gmail.com>
>
>> The thrid batch for memory leak issue has been delivered yet. Thanks for
>> Aim's review.
>>
>> https://issues.apache.org/ooo/show_bug.cgi?id=120038
>> https://issues.apache.org/ooo/show_bug.cgi?id=120040
>>
>> Propose to put these memory leak fixed into 3.4.1
>>
>>
>>
>> 2012/6/20 Chao Huang <ch...@gmail.com>
>>
>>> The second batch for memory leak issue has been delivered yet. Thanks
>>> for Herbert and JianFang's review.
>>>
>>> <http://goog_371113529>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120019
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120021
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>>>
>>>
>>>
>>> 2012/6/15 Chao Huang <ch...@gmail.com>
>>>
>>>> hi, all
>>>>
>>>> I'm Huang Chao from China. My interesting areas are Mac porting,
>>>> performance(startup, loading, saving, etc), stability, build env.
>>>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>>>
>>>> Here are the fixed for memory leak defects I opened. Please confirm
>>>> them and review them. I will continue to work on this area. Thanks!
>>>>
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>>>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>>>
>>>> Please note that the patches for bug119996 and bug119997 are on the
>>>> same source file.
>>>>
>>>> --
>>>> Best regards,
>>>> Chao Huang
>>>>
>>>>
>>>
>>>
>>> --
>>> Best regards,
>>> Chao Huang
>>>
>>>
>>
>>
>> --
>> Best regards,
>> Chao Huang
>>
>>
>
>
> --
> Best regards,
> Chao Huang
>
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
Here are the 4th batch for memory leak issue. Please help to review them.
Thanks!
https://issues.apache.org/ooo/show_bug.cgi?id=120050 in reviewing
https://issues.apache.org/ooo/show_bug.cgi?id=120072 fixed
https://issues.apache.org/ooo/show_bug.cgi?id=120073
https://issues.apache.org/ooo/show_bug.cgi?id=120074
https://issues.apache.org/ooo/show_bug.cgi?id=120077
https://issues.apache.org/ooo/show_bug.cgi?id=120079
2012/6/21 Chao Huang <ch...@gmail.com>
> The thrid batch for memory leak issue has been delivered yet. Thanks for
> Aim's review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=120038
> https://issues.apache.org/ooo/show_bug.cgi?id=120040
>
> Propose to put these memory leak fixed into 3.4.1
>
>
>
> 2012/6/20 Chao Huang <ch...@gmail.com>
>
>> The second batch for memory leak issue has been delivered yet. Thanks for
>> Herbert and JianFang's review.
>>
>> <http://goog_371113529>
>> https://issues.apache.org/ooo/show_bug.cgi?id=120019
>> https://issues.apache.org/ooo/show_bug.cgi?id=120021
>> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>>
>>
>>
>> 2012/6/15 Chao Huang <ch...@gmail.com>
>>
>>> hi, all
>>>
>>> I'm Huang Chao from China. My interesting areas are Mac porting,
>>> performance(startup, loading, saving, etc), stability, build env.
>>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>>
>>> Here are the fixed for memory leak defects I opened. Please confirm them
>>> and review them. I will continue to work on this area. Thanks!
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>>
>>> Please note that the patches for bug119996 and bug119997 are on the same
>>> source file.
>>>
>>> --
>>> Best regards,
>>> Chao Huang
>>>
>>>
>>
>>
>> --
>> Best regards,
>> Chao Huang
>>
>>
>
>
> --
> Best regards,
> Chao Huang
>
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
The thrid batch for memory leak issue has been delivered yet. Thanks for
Aim's review.
https://issues.apache.org/ooo/show_bug.cgi?id=120038
https://issues.apache.org/ooo/show_bug.cgi?id=120040
Propose to put these memory leak fixed into 3.4.1
2012/6/20 Chao Huang <ch...@gmail.com>
> The second batch for memory leak issue has been delivered yet. Thanks for
> Herbert and JianFang's review.
>
> <http://goog_371113529>
> https://issues.apache.org/ooo/show_bug.cgi?id=120019
> https://issues.apache.org/ooo/show_bug.cgi?id=120021
> https://issues.apache.org/ooo/show_bug.cgi?id=120028
>
>
>
> 2012/6/15 Chao Huang <ch...@gmail.com>
>
>> hi, all
>>
>> I'm Huang Chao from China. My interesting areas are Mac porting,
>> performance(startup, loading, saving, etc), stability, build env.
>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>
>> Here are the fixed for memory leak defects I opened. Please confirm them
>> and review them. I will continue to work on this area. Thanks!
>>
>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>
>> Please note that the patches for bug119996 and bug119997 are on the same
>> source file.
>>
>> --
>> Best regards,
>> Chao Huang
>>
>>
>
>
> --
> Best regards,
> Chao Huang
>
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
The second batch for memory leak issue has been delivered yet. Thanks for
Herbert and JianFang's review.
<goog_371113529>https://issues.apache.org/ooo/show_bug.cgi?id=120019
https://issues.apache.org/ooo/show_bug.cgi?id=120021
https://issues.apache.org/ooo/show_bug.cgi?id=120028
2012/6/15 Chao Huang <ch...@gmail.com>
> hi, all
>
> I'm Huang Chao from China. My interesting areas are Mac porting,
> performance(startup, loading, saving, etc), stability, build env.
> At recent stage, I will focus on memory leak issue in Aoo3.4.
>
> Here are the fixed for memory leak defects I opened. Please confirm them
> and review them. I will continue to work on this area. Thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>
> Please note that the patches for bug119996 and bug119997 are on the same
> source file.
>
> --
> Best regards,
> Chao Huang
>
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
This is the first batch for memory leak issue. I will plan to deliver more
batches in recent days.
Thanks for your verification work.
2012/6/15 Zhe Liu <al...@gmail.com>
> Great！
> When these patches are delivered, I will perform long-running testing
> again. By comparing with the past, let's see the result.
>
> 2012/6/15 Chao Huang <ch...@gmail.com>:
> > hi, all
> >
> > I'm Huang Chao from China. My interesting areas are Mac porting,
> > performance(startup, loading, saving, etc), stability, build env.
> > At recent stage, I will focus on memory leak issue in Aoo3.4.
> >
> > Here are the fixed for memory leak defects I opened. Please confirm them
> > and review them. I will continue to work on this area. Thanks!
> >
> > https://issues.apache.org/ooo/show_bug.cgi?id=119991
> > https://issues.apache.org/ooo/show_bug.cgi?id=119992
> > https://issues.apache.org/ooo/show_bug.cgi?id=119996
> > https://issues.apache.org/ooo/show_bug.cgi?id=119997
> >
> > Please note that the patches for bug119996 and bug119997 are on the same
> > source file.
> >
> > --
> > Best regards,
> > Chao Huang
>
>
>
> --
> Best Regards
> From aliuzhe@gmail.com
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Zhe Liu <al...@gmail.com>.
Great！
When these patches are delivered, I will perform long-running testing
again. By comparing with the past, let's see the result.
2012/6/15 Chao Huang <ch...@gmail.com>:
> hi, all
>
> I'm Huang Chao from China. My interesting areas are Mac porting,
> performance(startup, loading, saving, etc), stability, build env.
> At recent stage, I will focus on memory leak issue in Aoo3.4.
>
> Here are the fixed for memory leak defects I opened. Please confirm them
> and review them. I will continue to work on this area. Thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>
> Please note that the patches for bug119996 and bug119997 are on the same
> source file.
>
> --
> Best regards,
> Chao Huang
--
Best Regards
>From aliuzhe@gmail.com
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
Another tools are Purify on Windows, Shark on Mac OS X.
2012/6/18 zhangjf <zh...@apache.org>
> On Fri, Jun 15, 2012 at 9:57 PM, Rob Weir <ro...@apache.org> wrote:
> > On Fri, Jun 15, 2012 at 4:25 AM, Chao Huang <ch...@gmail.com>
> wrote:
> >> hi, all
> >>
> >> I'm Huang Chao from China. My interesting areas are Mac porting,
> >> performance(startup, loading, saving, etc), stability, build env.
> >> At recent stage, I will focus on memory leak issue in Aoo3.4.
> >>
> >> Here are the fixed for memory leak defects I opened. Please confirm them
> >> and review them. I will continue to work on this area. Thanks!
> >>
> >> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> >> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> >> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> >> https://issues.apache.org/ooo/show_bug.cgi?id=119997
> >>
> >
> > Cool! What tool(s) did you use to find the location of the memory leaks?
>
> We are mainly on Windows platform now. umdh from Windows SDK is the
> most effective tool we can find for AOO memory leak. We will try
> different tools on different platforms in the future.
>
> >
> > -Rob
> >
> >> Please note that the patches for bug119996 and bug119997 are on the same
> >> source file.
> >>
> >> --
> >> Best regards,
> >> Chao Huang
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by zhangjf <zh...@apache.org>.
On Fri, Jun 15, 2012 at 9:57 PM, Rob Weir <ro...@apache.org> wrote:
> On Fri, Jun 15, 2012 at 4:25 AM, Chao Huang <ch...@gmail.com> wrote:
>> hi, all
>>
>> I'm Huang Chao from China. My interesting areas are Mac porting,
>> performance(startup, loading, saving, etc), stability, build env.
>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>
>> Here are the fixed for memory leak defects I opened. Please confirm them
>> and review them. I will continue to work on this area. Thanks!
>>
>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>>
>
> Cool! What tool(s) did you use to find the location of the memory leaks?
We are mainly on Windows platform now. umdh from Windows SDK is the
most effective tool we can find for AOO memory leak. We will try
different tools on different platforms in the future.
>
> -Rob
>
>> Please note that the patches for bug119996 and bug119997 are on the same
>> source file.
>>
>> --
>> Best regards,
>> Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Rob Weir <ro...@apache.org>.
On Fri, Jun 15, 2012 at 4:25 AM, Chao Huang <ch...@gmail.com> wrote:
> hi, all
>
> I'm Huang Chao from China. My interesting areas are Mac porting,
> performance(startup, loading, saving, etc), stability, build env.
> At recent stage, I will focus on memory leak issue in Aoo3.4.
>
> Here are the fixed for memory leak defects I opened. Please confirm them
> and review them. I will continue to work on this area. Thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> https://issues.apache.org/ooo/show_bug.cgi?id=119992
> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>
Cool! What tool(s) did you use to find the location of the memory leaks?
-Rob
> Please note that the patches for bug119996 and bug119997 are on the same
> source file.
>
> --
> Best regards,
> Chao Huang
[AOO 3.4.1] fix for memory leak of issue 119997 should get into our
next release (was [Call-for-Review] Some issue about memory leak in Aoo3.4)
Posted by Herbert Duerr <hd...@apache.org>.
Extracting the release-critical part of the thread
"[Call-for-Review] Some issue about memory leak in Aoo3.4":
On 15.06.2012 14:55, Chao Huang wrote:
> 2012/6/15 Herbert Duerr<hd...@apache.org>
>> [...]
>>> https://issues.apache.org/ooo/**show_bug.cgi?id=119997<https://issues.apache.org/ooo/show_bug.cgi?id=119997>
>> [...]
>> The second one is important enough to be an AOO 3.4.1 candidate.
>>
> +1
Many thanks to Chao Huang for finding the leak and providing a patch
that solves the problem!
Herbert
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Chao Huang <ch...@gmail.com>.
2012/6/15 Herbert Duerr <hd...@apache.org>
> Hi Chao Huang,
>
>
> I'm Huang Chao from China. My interesting areas are Mac porting,
>> performance(startup, loading, saving, etc), stability, build env.
>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>>
>
> Welcome!
>
>
> Here are the fixed for memory leak defects I opened. Please confirm them
>> and review them. I will continue to work on this area. Thanks!
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=119991<https://issues.apache.org/ooo/show_bug.cgi?id=119991>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=119992<https://issues.apache.org/ooo/show_bug.cgi?id=119992>
>>
>
> Can't help you here as I don't know these parts of the code.
>
> https://issues.apache.org/ooo/**show_bug.cgi?id=119996<https://issues.apache.org/ooo/show_bug.cgi?id=119996>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=119997<https://issues.apache.org/ooo/show_bug.cgi?id=119997>
>>
>
> I reviewed them and updated their bugzilla entries.
>
Thanks for your review and check-in !
> The second one is important enough to be an AOO 3.4.1 candidate.
>
+1
>
> Herbert
>
--
Best regards,
Chao Huang
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by zhangjf <zh...@apache.org>.
On Fri, Jun 15, 2012 at 5:46 PM, Herbert Duerr <hd...@apache.org> wrote:
> Hi Chao Huang,
>
>
>> I'm Huang Chao from China. My interesting areas are Mac porting,
>> performance(startup, loading, saving, etc), stability, build env.
>> At recent stage, I will focus on memory leak issue in Aoo3.4.
>
>
> Welcome!
>
>
>> Here are the fixed for memory leak defects I opened. Please confirm them
>> and review them. I will continue to work on this area. Thanks!
>>
>> https://issues.apache.org/ooo/show_bug.cgi?id=119991
>> https://issues.apache.org/ooo/show_bug.cgi?id=119992
>
>
> Can't help you here as I don't know these parts of the code.
These two fixes are quite straightforward, I will review and commit them.
zhangjf
>
>> https://issues.apache.org/ooo/show_bug.cgi?id=119996
>> https://issues.apache.org/ooo/show_bug.cgi?id=119997
>
>
> I reviewed them and updated their bugzilla entries.
> The second one is important enough to be an AOO 3.4.1 candidate.
>
> Herbert
Re: [Call-for-Review] Some issue about memory leak in Aoo3.4
Posted by Herbert Duerr <hd...@apache.org>.
Hi Chao Huang,
> I'm Huang Chao from China. My interesting areas are Mac porting,
> performance(startup, loading, saving, etc), stability, build env.
> At recent stage, I will focus on memory leak issue in Aoo3.4.
Welcome!
> Here are the fixed for memory leak defects I opened. Please confirm them
> and review them. I will continue to work on this area. Thanks!
>
> https://issues.apache.org/ooo/show_bug.cgi?id=119991
> https://issues.apache.org/ooo/show_bug.cgi?id=119992
Can't help you here as I don't know these parts of the code.
> https://issues.apache.org/ooo/show_bug.cgi?id=119996
> https://issues.apache.org/ooo/show_bug.cgi?id=119997
I reviewed them and updated their bugzilla entries.
The second one is important enough to be an AOO 3.4.1 candidate.
Herbert