You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2025/02/01 12:09:27 UTC
Re: [PR] Remove Alembic migration autogenerated comment [airflow]
jason810496 commented on code in PR #46322:
URL: https://github.com/apache/airflow/pull/46322#discussion_r1938264081
##########
airflow/migrations/versions/0057_3_0_0_add_new_task_instance_field_scheduled_.py:
##########
@@ -42,23 +42,17 @@
def upgrade():
"""Apply add new task_instance field scheduled_dttm."""
- # ### commands auto generated by Alembic - please adjust! ###
with op.batch_alter_table("task_instance", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
with op.batch_alter_table("task_instance_history", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
- # ### end Alembic commands ###
-
Review Comment:
Hi @ephraimbuddy, there is only a placeholder migration file in the FAB provider, and it does not contain an Alembic-generated comment. So, I think we can skip it, right?
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/fab/migrations/versions/0001_1_4_0_placeholder_migration.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org