You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/02/01 23:58:58 UTC

Review Request 43070: HIVE-12976 MetaStoreDirectSql doesn't batch IN lists in all cases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43070/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9c 

Diff: https://reviews.apache.org/r/43070/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 43070: HIVE-12976 MetaStoreDirectSql doesn't batch IN lists in all cases

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43070/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 8:43 p.m.)


Review request for hive, Ashutosh Chauhan and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9c 

Diff: https://reviews.apache.org/r/43070/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 43070: HIVE-12976 MetaStoreDirectSql doesn't batch IN lists in all cases

Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43070/#review117566
-----------------------------------------------------------




metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (line 1789)
<https://reviews.apache.org/r/43070/#comment178798>

    Very suspicious line. 
    
    If the query doesn't return any results, it will get re-run old stuff?


- Gopal V


On Feb. 3, 2016, 2:39 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43070/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 2:39 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Sushanth Sowmyan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9c 
> 
> Diff: https://reviews.apache.org/r/43070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 43070: HIVE-12976 MetaStoreDirectSql doesn't batch IN lists in all cases

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43070/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 2:39 a.m.)


Review request for hive, Ashutosh Chauhan and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9c 

Diff: https://reviews.apache.org/r/43070/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 43070: HIVE-12976 MetaStoreDirectSql doesn't batch IN lists in all cases

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43070/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 11:02 p.m.)


Review request for hive, Ashutosh Chauhan and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9c 

Diff: https://reviews.apache.org/r/43070/diff/


Testing
-------


Thanks,

Sergey Shelukhin