You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/04/14 14:58:34 UTC

[GitHub] [celix] abroekhuis commented on a change in pull request #195: Feature/make tcp admin more robust

abroekhuis commented on a change in pull request #195: Feature/make tcp admin more robust
URL: https://github.com/apache/celix/pull/195#discussion_r408204584
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/src/pubsub_endpoint.c
 ##########
 @@ -181,7 +181,9 @@ celix_properties_t* pubsubEndpoint_createFromPublisherTrackerInfo(bundle_context
     }
 
     free(topic);
-    free(scopeFromFilter);
+    if (scope != NULL) {
 
 Review comment:
   I left these as a free on NULL is not a problem. But I'm fine with those changes as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services