You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/07/22 16:06:28 UTC

[GitHub] flink pull request #2287: [hotfix] Prevent CheckpointCommitter from failing ...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2287

    [hotfix] Prevent CheckpointCommitter from failing job

    This PR fixes an issue in the `GenericWriteAheadSink` that @aljoscha stumbled upon.
    
    If the sink fails while writing the data into the external storage the sink retries again on the next notify; it will never fail the job. However, the CheckpointCommitter does not behave that way; if the storage cannot be queried it will throw an exception that is not catched by the sink.
    
    The exceptions are now catched and logged by the sink.
    
    @aljoscha Could you try out whether this fixes the issue?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink cass_cc_failure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2287
    
----
commit e6c69b5c165489ea513ac134ff9801c78e88e948
Author: zentol <ch...@apache.org>
Date:   2016-07-22T15:50:10Z

    [hotfix] Prevent CheckpointCommitter from failing job
    
    Prevents the CheckpointCommitter from failing a job, if either
    commitCheckpoint() or isCheckpointCommitter() failed. Instead, we will
    try again on the next notify().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    This does in fact fix the problem. Running smoothly now. \U0001f603 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    Thanks! \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    - added test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    I'm checking now but I'm assuming it will fix it from looking at the code. Could we also a a test for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    That's great to hear, working on a test right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2287: [hotfix] Prevent CheckpointCommitter from failing job

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2287
  
    Test looks good!
    
    Please go ahead and merge if you're ready. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2287: [hotfix] Prevent CheckpointCommitter from failing ...

Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/2287


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---