[GitHub] [tinkerpop] spmallette commented on pull request #1850: [TINKERPOP-2819] Refactoring java driver and extracting SimpleSocketServer to new module

[GitBox <gi...@apache.org>]

spmallette commented on PR #1850:
URL: https://github.com/apache/tinkerpop/pull/1850#issuecomment-1306208325

   In introducing the new `gremlin-util` module there should be some Upgrade Documentation to accompany this change. It should probably make note why this change isn't a breaking one and what impact it might have during upgrade. 
   
   Speaking of which, I can't think of a scenario where users should notice anything different in their upgrades unless they aren't using maven or something similar. If they were somehow manually managing jar files they might miss that `gremlin-util` was a new module i guess. I'd sorta advocated a hope for being able to test drivers along 3.5.x and 3.6.x so perhaps that swayed you in this direction. seeing it here gives me a bit of pause that we're going to somehow annoy folks by moving these classes about. 
   
   how do you feel about taking this a step more slowly? the work you've done here shows that the change could be made without breaking too much. if we really wanted to test 3.5.x/3.6.x we could in the future always backport this commit to these branches. so, you could just target master now with this commit as it is. introduce a follow-on commit that renames packages if you like as we can take a breaking change in 3.7.x. you do have the issue of groovy in gremlin-util but making a note of that in commit comment will remind us of that issue if we decided to backport the commit. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org