You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2020/10/07 21:08:00 UTC
[jira] [Comment Edited] (CASSANDRA-16198) Add ant task to check
license and fix all files missing a licence
[ https://issues.apache.org/jira/browse/CASSANDRA-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209867#comment-17209867 ]
David Capwell edited comment on CASSANDRA-16198 at 10/7/20, 9:07 PM:
---------------------------------------------------------------------
[~mck]
bq. What was the purpose with the existing "rat" target?
No idea! It requires we build the tarball then checks both tarballs (binary/source). I tried running it and gave up after 5 minutes (2.2).
bq. When and were was it (intended to be) run?
Not sure, git says you added it!
{code}
commit 382bcad07dc84b58eb2a0fbec8eab91d8517932b
Author: Mick Semb Wever <mc...@apache.org>
Date: Fri Aug 28 10:57:16 2020 +0200
Backport CASSANDRA-14970 to 2.1 - New releases must supply SHA-256 and/or SHA-512 checksums
patch by Mick Semb Wever; reviewed by Benjamin Lerer for CASSANDRA-16081
{code}
CASSANDRA-14970 doesn't really tell me much though, best I see is "I have moved the checksumming into the `artifacts` tasks (alongside the generation of the original artefacts), and renamed the `release` task to `rat`."
First commit I see with rat report is
{code}
commit 0f8b6097559815a3f770fda01b1ec5c19cdad547
Author: Eric Evans <ee...@apache.org>
Date: Wed Feb 24 19:54:14 2010 +0000
merge w/ 0.6 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@915953 13f79535-47bb-0310-9956-ffa450edef68
{code}
bq. What shall we do with it now?
Not sure what uses it so I left as is. It was too slow that I don't intend to use it, not sure if anyone else is...
was (Author: dcapwell):
[~mck]
bq. What was the purpose with the existing "rat" target?
No idea! It requires we build the tarball then checks both tarballs (binary/source). I tried running it and gave up after 5 minutes (2.2).
bq. When and were was it (intended to be) run?
Not sure, git says you added it!
{code}
commit 382bcad07dc84b58eb2a0fbec8eab91d8517932b
Author: Mick Semb Wever <mc...@apache.org>
Date: Fri Aug 28 10:57:16 2020 +0200
Backport CASSANDRA-14970 to 2.1 - New releases must supply SHA-256 and/or SHA-512 checksums
patch by Mick Semb Wever; reviewed by Benjamin Lerer for CASSANDRA-16081
{code}
CASSANDRA-14970 doesn't really tell me much though, best I see is "I have moved the checksumming into the `artifacts` tasks (alongside the generation of the original artefacts), and renamed the `release` task to `rat`."
bq. What shall we do with it now?
Not sure what uses it so I left as is. It was too slow that I don't intend to use it, not sure if anyone else is...
> Add ant task to check license and fix all files missing a licence
> -----------------------------------------------------------------
>
> Key: CASSANDRA-16198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16198
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Low
> Fix For: NA
>
>
> We should block the build on license to avoid missing licenses in the build.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org