You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/03 19:36:53 UTC
[GitHub] codecov-io edited a comment on issue #5544: Improve URLs for Chart
and Dashboard ModelViews
codecov-io edited a comment on issue #5544: Improve URLs for Chart and Dashboard ModelViews
URL: https://github.com/apache/incubator-superset/pull/5544#issuecomment-409821280
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=h1) Report
> Merging [#5544](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4bf69a7260f1d4c8fbfe9d9c0300cae39ca3bf81?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `87.5%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5544 +/- ##
==========================================
- Coverage 63.29% 63.25% -0.04%
==========================================
Files 349 351 +2
Lines 22194 22258 +64
Branches 2467 2470 +3
==========================================
+ Hits 14047 14079 +32
- Misses 8133 8164 +31
- Partials 14 15 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.09% <ø> (+0.08%)` | :arrow_up: |
| [superset/assets/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0Rhc2hib2FyZFRhYmxlLmpzeA==) | `83.33% <ø> (ø)` | :arrow_up: |
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | `71.42% <ø> (ø)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `81.63% <ø> (-0.19%)` | :arrow_down: |
| [...set/assets/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2FjdGlvbnMvc2F2ZU1vZGFsQWN0aW9ucy5qcw==) | `80.55% <100%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.98% <85.71%> (-0.19%)` | :arrow_down: |
| [superset/assets/src/modules/visUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3Zpc1V0aWxzLmpz) | `58.33% <0%> (-16.67%)` | :arrow_down: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.34% <0%> (-6.13%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `54.19% <0%> (-1.07%)` | :arrow_down: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `58.51% <0%> (-0.8%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-superset/pull/5544/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=footer). Last update [4bf69a7...2c076b2](https://codecov.io/gh/apache/incubator-superset/pull/5544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org