You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/15 05:08:53 UTC

[GitHub] [pulsar] rudy2steiner commented on a change in pull request #8048: [Issue 7903][proxy]Enable AutoTopicCreationType partitioned through proxy

rudy2steiner commented on a change in pull request #8048:
URL: https://github.com/apache/pulsar/pull/8048#discussion_r488388769



##########
File path: pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyTest.java
##########
@@ -222,7 +244,7 @@ public void testRegexSubscription() throws Exception {
             final int numMessages = 20;
 
             try (Producer<byte[]> producer = client.newProducer(Schema.BYTES)
-                .topic("persistent://sample/test/local/topic1")
+                .topic("persistent://sample/test/local/regex-sub-topic1")

Review comment:
       I have a unit test case for this change and run the unit test ProxyTest. and found out the consumer of testRegexSubscription case will blocking because of consuming message from inconsistent topic with producer. maybe i should fix the issue in another pr.  
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org