[GitHub] [pinot] jtao15 commented on pull request #7617: Use maxEndTimeMs for merge/roll-up delay metrics.

[GitBox <gi...@apache.org>]

jtao15 commented on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949946633


   > What happens if the system clock is adjusted backwards so that `bufferTimeMs` > `System.currentTimeMillis()`? Durations should be recorded using `System.nanoTime()`.
   
   @richardstartin Based on [java doc](https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#nanoTime--), nanoTime() can only be used to measure elapsed time and is not related to any other notion of system or wall-clock time. I'm trying to use the system wall time instead of elapsed time here. If the system clock is adjusted, I think it make sense that the delay is updated also. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org