[GitHub] [pulsar] yuruguo edited a comment on pull request #12242: [pulsar-admin] Add --update-mode to optimize topic rate policy

[GitBox <gi...@apache.org>]

yuruguo edited a comment on pull request #12242:
URL: https://github.com/apache/pulsar/pull/12242#issuecomment-946696384


   > @yuruguo I think we don't need to introduce the new flag, the `publishThrottlingRateInMsg` and `publishThrottlingRateInByte ` can be treated as a single unit, if users want to use an old value a part of it, they can get the policy first and then copy the old value for the new operation.
   
   There is no doubt that we can achieve the above effects according to your instructions, and [here](https://github.com/apache/pulsar/pull/12242#issue-1011143271) is also used in this way.
   
   **However**, this is an unfriendly operation for users, and users generally do not have this operating habit. In actual use, I always thought that the previously option's(such as `publishThrottlingRateInMsg`)  value is still valid when I set other option(such as `publishThrottlingRateInByte`) , but this is not the case.
   
   **In addition**, the effect of kafka setting rate configuration is to cover and add, such as
   ```
   bin/kafka-configs.sh --zookeeper localhost:2181/kafka --alter --entity-type clients --entity-default  --add-config 'producer_byte_rate=2097152'
   bin/kafka-configs.sh --zookeeper localhost:2181/kafka --alter --entity-type clients --entity-default  --add-config 'consumer_byte_rate=2097152'
   ```
   above equals to
   ```
   bin/kafka-configs.sh --zookeeper localhost:2181/kafka --alter --entity-type clients --entity-default  --add-config 'producer_byte_rate=2097152, consumer_byte_rate=2097152'
   ```
   We can also achieve this effect like kafka by adding `--update-mode`, and this is a meaningful support for people who change from kafka users to pulsar users.
   
   **Finally**, the default value of `--update-mode` is false, which is consistent with the previous behavior, unless the user explicitly specifies it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org