You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/11 17:35:00 UTC
[jira] [Commented] (GEODE-7568) Pass persistence service to manager
constructors instead of to each operation
[ https://issues.apache.org/jira/browse/GEODE-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993739#comment-16993739 ]
ASF subversion and git services commented on GEODE-7568:
--------------------------------------------------------
Commit 6ed908bdbc63c5e4d6de12089f87b5e594cb4f30 in geode's branch refs/heads/develop from Dale Emery
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6ed908b ]
GEODE-7568: Pass persistence service to config mgr constructors (#4462)
* GEODE-7568: Pass persistence service to config mgr constructors
Pass the persistence service to each manager on construction, rather
than passing it to each method.
Co-authored-by: Dale Emery <de...@pivotal.io>
* Remove spurious commented code
> Pass persistence service to manager constructors instead of to each operation
> -----------------------------------------------------------------------------
>
> Key: GEODE-7568
> URL: https://issues.apache.org/jira/browse/GEODE-7568
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Dale Emery
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently each {{ConfigurationManager}} takes a persistence service parameter for each of its operation methods, like so:
> {{delete(InternalConfigurationPersistenceService service, Deployment config, String groupName)}}
> We could instead pass the persistence service to the constructor of each configuration manager implementation. This would simplify the operation methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)