[jira] Commented: (ADFFACES-55) inhibit skinning css properties

["Adam Winer (JIRA)" <ad...@incubator.apache.org>]

    [ http://issues.apache.org/jira/browse/ADFFACES-55?page=comments#action_12428315 ] 
            
Adam Winer commented on ADFFACES-55:
------------------------------------

Simon:  one thing in the patch I don't get:

+      if(inhibitedProperties.contains(INHIBIT_ALL_VALUE))
+      {
+        _inhibitAll = true;
+        _inhibitedProperties = new ArrayList<String>(inhibitedProperties.size()-1);
+        for(String property : inhibitedProperties)
+        {
+          _inhibitedProperties.add(property);
+        }
+      }
+      else
+      {
+        _inhibitedProperties = new ArrayList<String>(inhibitedProperties);
+      }

Shouldn't _inhibitedProperties be empty if "all" is present, since _inhibitAll
is sufficent?  Or, at least, is the intent here something more like:

+        for(String property : inhibitedProperties)
+        {
+          if (!property.equals(INHIBIT_ALL_VALUE)
+            _inhibitedProperties.add(property);
+        }


> inhibit skinning css properties
> -------------------------------
>
>                 Key: ADFFACES-55
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-55
>             Project: MyFaces ADF-Faces
>          Issue Type: New Feature
>            Reporter: Jeanne Waldman
>         Attachments: Inhibit.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira