[GitHub] [pulsar] Hongten commented on a diff in pull request #11821: [PIP-82] [pulsar-broker] Misc fixes:

["Hongten (via GitHub)" <gi...@apache.org>]

Hongten commented on code in PR #11821:
URL: https://github.com/apache/pulsar/pull/11821#discussion_r1102227728


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java:
##########
@@ -321,6 +321,12 @@ protected BytesAndMessagesCount getGlobalUsageStats(ResourceGroupMonitoringClass
 
     protected BytesAndMessagesCount updateLocalQuota(ResourceGroupMonitoringClass monClass,
                                                      BytesAndMessagesCount newQuota) throws PulsarAdminException {
+        // Only the Publish side is functional now; add the Dispatch side code when the consume side is ready.

Review Comment:
   @kaushik-develop , May I check if the consume side is ready or not now? Because we can still see this part in the master branch and it seems not to work when I set the `--msg-dispatch-rate 10 --byte-dispatch-rate 2000` to a resourcegroup. Can you advise? 
   Thanks,
   Hongten



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org