You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/08/16 18:14:00 UTC

[GitHub] [logging-log4j2] fmarchioni opened a new pull request #402: Added two articles recently published

fmarchioni opened a new pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402


   I've added two fresh articles based on the latest releases of WildFly application Server and Spring Boot 2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers commented on pull request #402: Added two articles recently published

Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675593486


   Thanks for making the changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #402: Added two articles recently published

Posted by GitBox <gi...@apache.org>.
rgoers edited a comment on pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675277664


   A couple of comments on the Srping Boot article:
   1. In the first two paragraphs you say "new" in each. The first commit for Log4j 2 was 10 years ago and the first GA release was 6 years ago. I'd hardly call that new.
   2. You use the phrase "substantially based on Logback". That is quite incorrect and would violate Logback's licensing were it true.  Logback originated from Log4j 1. Log4j 2 took ideas from Logback and Log4j 1 but was almost entirely new code. 
   3. While using spring-boot-starter-log4j2 is an option I recommend importing log4j-bom instead. That way you control the version of Log4j 2 you are using.
   4. Log4j provides direct Spring Boot support. In 2.13.3 it is included in the log4j-spring-cloud-config module. The code that only requires Spring Boot is moving to a new log4j-spring-boot module in 2.14.0.
   5. It is worth looking into the support the log4j-spring-cloud-config module provides as it supports placing your log4j2.xml file in Spring Cloud config where it can be shared by all the instances of your application dynamically updating them all when it changes.
   
   
   The first 2 comments also apply to the JBoss article.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers commented on pull request #402: Added two articles recently published

Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675277664


   A couple of comments on the Srping Boot article:
   1. In the first two paragraphs you say "new" in each. The first commit for Log4j 2 was 10 years ago and the first GA release was 6 years ago. I'd hardly call that new.
   2. You use the phrase "substantially based on Logback". That is quite incorrect and would violate Logback's licensing were it true.  Logback originated from Log4j 1. Log4j 2 took ideas from Logback and Log4j 1 but was almost entirely new code. 
   3. While using spring-boot-starter-log4j2 is an option I recommend importing log4j-bom instead. That way you control the version of Log4j 2 you are using.
   4. Log4j provides direct Spring Boot support. In 2.13.3 it is included in the log4j-spring-cloud-config module. The code that only requires Spring Boot is moving to a new log4j-spring-boot module in 2.14.0.
   5. It is worth looking into the support the log4j-spring-cloud-config module provides as it supports placing your log4j2.xml file in Spring Cloud config where it can be shared by all the instances of your application dynamically updating them all when it changes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] fmarchioni commented on pull request #402: Added two articles recently published

Posted by GitBox <gi...@apache.org>.
fmarchioni commented on pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402#issuecomment-675412587


   Thanks for taking the time to review the article.
   I've fixed point 1) and 2)
   Also for point 3) I've added a section to show how to use log4j-bom both both for Spring Boot and WildFly article.
   About 4) and 5) that's a great suggestion. Being more specific to spring cloud, I'd like to discuss it in a new article which focuses on spring cloud and log4j. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers merged pull request #402: Added two articles recently published

Posted by GitBox <gi...@apache.org>.
rgoers merged pull request #402:
URL: https://github.com/apache/logging-log4j2/pull/402


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org