[GitHub] [pinot] richardstartin commented on a diff in pull request #10254: Handle big In clause

["richardstartin (via GitHub)" <gi...@apache.org>]

richardstartin commented on code in PR #10254:
URL: https://github.com/apache/pinot/pull/10254#discussion_r1101843881


##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -297,12 +300,18 @@ public static FilterContext getFilter(FunctionContext filterFunction) {
         for (int i = 1; i < numOperands; i++) {
           values.add(getStringValue(operands.get(i)));
         }
+        if (numOperands > THRESHOLD_OF_LARGE_IN_CLAUSE_VALUES) {
+          Collections.sort(values);

Review Comment:
   I'm not sure this is valid unless the column type is `STRING`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org