[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9694: Craig/helm fixes

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #9694:
URL: https://github.com/apache/incubator-superset/pull/9694#discussion_r417792836



##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -49,7 +49,7 @@ Create chart name and version as used by the chart label.
 {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}
 {{- end -}}
 
-{{- define "superset-connections.script" }}
+{{- define "superset-config" }}

Review comment:
       We could use f strings here and make the config more readable




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org