You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/29 07:30:58 UTC

[GitHub] [airflow] RosterIn opened a new issue #11929: add DateTimeBranchOperator

RosterIn opened a new issue #11929:
URL: https://github.com/apache/airflow/issues/11929


   
   **Use case / motivation**
   
   Airflow have `BranchSQLOperator` and `BranchPythonOperator`.
   Airflow also have `DateTimeSensor`.
   
   I find it very useful to have `DateTimeBranchOperator` that will allow to branch workflow based on specific DateTime
   Sometimes in DAGs you want to do another set of tasks according to specific dates or time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #11929:
URL: https://github.com/apache/airflow/issues/11929


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] tomasfarias commented on issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
tomasfarias commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-798923736


   @eladkal thanks to you for the patience, great feedback, and all the work in Airflow! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-798871578


   @tomasfarias Thanks for your contribution :+1:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] tomasfarias commented on issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
tomasfarias commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-719113348


   Hello 👋 
   
   I've been using Airflow for a while now and would love to get involved with the project and contribute some code. If nobody's working on this I'd like to open a PR. Just wanted to clarify a few questions:
   
   * Should `DateTimeBranchOperator` support comparisons with partial dates? For example: branching based on a comparison between the current date and only a year, instead of a full date. I believe we should, although this may lead to a long argument list as we would need one for each date attribute.
   * Should the operator inherit from `BaseBranchOperator`? Seems to me that would be the best option, but none of the examples mentioned inherit from it (`BranchSQLOperator` and `BranchPythonOperator`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-719150311


   @tomasfarias Hi. It is best if you prepare a small POC that will not contain tests and will not even fully work but will allow us to familiarize ourselves with your concept. Then we can iterate over this code together. What do you think about it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] tomasfarias commented on issue #11929: add DateTimeBranchOperator

Posted by GitBox <gi...@apache.org>.
tomasfarias commented on issue #11929:
URL: https://github.com/apache/airflow/issues/11929#issuecomment-719410061


   Sounds perfect to me! Thanks for the guidance @mik-laj, I'll open a PR shortly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org