[GitHub] [arrow] westonpace commented on a diff in pull request #13489: ARROW-16948: [C++] Benchmark Aggregates Fails To Compile After Aggregate Updates

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #13489:
URL: https://github.com/apache/arrow/pull/13489#discussion_r912127376


##########
cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:
##########
@@ -308,8 +308,21 @@ BENCHMARK_TEMPLATE(ReferenceSum, SumBitmapVectorizeUnroll<int64_t>)
 
 using arrow::compute::internal::GroupBy;
 
-static void BenchmarkGroupBy(benchmark::State& state, std::vector<Aggregate> aggregates,
+struct BenchmarkAggregate {

Review Comment:
   ```suggestion
   // The internal function GroupBy simulates an aggregate node and
   // doesn't need a target or name.  This helper class allows us to
   // just specify the fields we need and make up a dummy target / name.
   struct BenchmarkAggregate {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org