You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2026/06/02 17:36:12 UTC

(impala) 01/02: IMPALA-15036: Set HTTP port for minicluster Trino in a more robust way

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit c83cfcbe4b3a605187740caff36b0d728047c200
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Fri May 22 14:52:38 2026 +0200

    IMPALA-15036: Set HTTP port for minicluster Trino in a more robust way
    
    Prior to this patch Impala used sed to replace property
    "http-server.http.port" in Trino's config file. However, newer Trino
    versions might not define that property, which means sed fail silently
    then Trino binds the default port 8080.
    
    This patch first removes property http-server.http.port if it exists,
    then adds it with the desired value.
    
    Change-Id: If8e1300694200aaaf675675fb348f0c767e6c147
    Reviewed-on: http://gerrit.cloudera.org:8080/24346
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 testdata/bin/minicluster_trino/Dockerfile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testdata/bin/minicluster_trino/Dockerfile b/testdata/bin/minicluster_trino/Dockerfile
index c8ffa2186..a29e68900 100644
--- a/testdata/bin/minicluster_trino/Dockerfile
+++ b/testdata/bin/minicluster_trino/Dockerfile
@@ -22,8 +22,9 @@ FROM trinodb/trino:latest
 ARG USERNAME
 
 RUN \
-    sed -i 's/http-server.http.port=8080/http-server.http.port=9091/' /etc/trino/config.properties && \
-    sed -i 's/localhost:8080/localhost:9091/' /etc/trino/config.properties && \
+    sed -i '/^http-server\.http\.port=/d' /etc/trino/config.properties && \
+    echo "http-server.http.port=9091" >> /etc/trino/config.properties && \
+    sed -i 's/localhost:8080/localhost:9091/g' /etc/trino/config.properties && \
     echo "-DHADOOP_USER_NAME=$USERNAME" >> /etc/trino/jvm.config
 
 COPY hive-site.xml core-site.xml hdfs-site.xml /etc/