You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/03/30 12:07:09 UTC
Review Request 32614: LENS-468 : Connection leak in
JDBCDriver.estimate path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32614/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-468
https://issues.apache.org/jira/browse/LENS-468
Repository: lens
Description
-------
Fixed connection leak by moving connection creation down to prepareInternal
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56bf2b513dbaf27562061a404b205c55a74b
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 550a4680d9c2784660dbfe053da2f454f1b9bef7
Diff: https://reviews.apache.org/r/32614/diff/
Testing
-------
Adding failing test. Waiting for all test results
Thanks,
Jaideep dhok
Re: Review Request 32614: LENS-468 : Connection leak in
JDBCDriver.estimate path
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32614/
-----------------------------------------------------------
(Updated March 30, 2015, 10:38 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-468
https://issues.apache.org/jira/browse/LENS-468
Repository: lens
Description
-------
Fixed connection leak by moving connection creation down to prepareInternal
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56bf2b513dbaf27562061a404b205c55a74b
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 550a4680d9c2784660dbfe053da2f454f1b9bef7
Diff: https://reviews.apache.org/r/32614/diff/
Testing (updated)
-------
Adding failing test.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.437s]
[INFO] Lens .............................................. SUCCESS [2.037s]
[INFO] Lens API .......................................... SUCCESS [6.334s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.407s]
[INFO] Lens Cube ......................................... SUCCESS [2:16.877s]
[INFO] Lens DB storage ................................... SUCCESS [10.083s]
[INFO] Lens Query Library ................................ SUCCESS [5.396s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:29.197s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.595s]
[INFO] Lens Server ....................................... SUCCESS [4:43.104s]
[INFO] Lens client ....................................... SUCCESS [21.376s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.856s]
[INFO] Lens Examples ..................................... SUCCESS [0.896s]
[INFO] Lens Distribution ................................. SUCCESS [10.378s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.373s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.507s]
[INFO] Lens Regression ................................... SUCCESS [0.468s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:40.319s
[INFO] Finished at: Mon Mar 30 10:30:40 UTC 2015
[INFO] Final Memory: 109M/1122M
[INFO] ------------------------------------------------------------------------
[SLOCCount] Report successfully processed and all data stored
Recording test results
Finished: SUCCESS
Thanks,
Jaideep dhok
Re: Review Request 32614: LENS-468 : Connection leak in
JDBCDriver.estimate path
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32614/#review78190
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 30, 2015, 10:07 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32614/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 10:07 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-468
> https://issues.apache.org/jira/browse/LENS-468
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixed connection leak by moving connection creation down to prepareInternal
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 121b56bf2b513dbaf27562061a404b205c55a74b
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 550a4680d9c2784660dbfe053da2f454f1b9bef7
>
> Diff: https://reviews.apache.org/r/32614/diff/
>
>
> Testing
> -------
>
> Adding failing test. Waiting for all test results
>
>
> Thanks,
>
> Jaideep dhok
>
>