You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/07/28 21:41:47 UTC
Review Request 61130: Search API folding and tag attribute honoring
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61130/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1994
https://issues.apache.org/jira/browse/ATLAS-1994
Repository: atlas
Description
-------
Currently when the entity text query is specified with the entity and it's filters none of the tag attributes are considered during filtering (search). This change honors the tag attributes during search even under the above scenario
TODO: Caching of the gremlin expression for tag attribute filtering
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java dcdcbbbb
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 385951bc
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 7e096720
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1bf03464
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8481a4f6
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3
Diff: https://reviews.apache.org/r/61130/diff/1/
Testing
-------
Ongoing
Thanks,
Apoorv Naik
Re: Review Request 61130: Search API folding and tag attribute
honoring
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61130/#review181772
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 30, 2017, 4:53 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61130/
> -----------------------------------------------------------
>
> (Updated July 30, 2017, 4:53 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1994
> https://issues.apache.org/jira/browse/ATLAS-1994
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently when the entity text query is specified with the entity and it's filters none of the tag attributes are considered during filtering (search). This change honors the tag attributes during search even under the above scenario
>
> TODO: Caching of the gremlin expression for tag attribute filtering, add '-' the offending char list
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 9e263d70
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java dcdcbbbb
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 385951bc
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 7e096720
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1bf03464
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8481a4f6
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3
>
>
> Diff: https://reviews.apache.org/r/61130/diff/2/
>
>
> Testing
> -------
>
> Ongoing
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 61130: Search API folding and tag attribute
honoring
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61130/
-----------------------------------------------------------
(Updated July 30, 2017, 4:53 a.m.)
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1994
https://issues.apache.org/jira/browse/ATLAS-1994
Repository: atlas
Description (updated)
-------
Currently when the entity text query is specified with the entity and it's filters none of the tag attributes are considered during filtering (search). This change honors the tag attributes during search even under the above scenario
TODO: Caching of the gremlin expression for tag attribute filtering, add '-' the offending char list
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 9e263d70
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java dcdcbbbb
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 385951bc
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 7e096720
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1bf03464
repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8481a4f6
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3
Diff: https://reviews.apache.org/r/61130/diff/2/
Changes: https://reviews.apache.org/r/61130/diff/1-2/
Testing
-------
Ongoing
Thanks,
Apoorv Naik