You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 14:06:03 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3985: Add Pull Request guidelines to contributor guide
alamb opened a new pull request, #3985:
URL: https://github.com/apache/arrow-datafusion/pull/3985
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/3957
# Rationale for this change
Document how we should handle PRs
# What changes are included in this PR?
Add Pull Request guidelines to contributor guide
# Are there any user-facing changes?
docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3985: Add Pull Request guidelines to contributor guide
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3985:
URL: https://github.com/apache/arrow-datafusion/pull/3985#issuecomment-1297122938
Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3985: Add Pull Request guidelines to contributor guide
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3985:
URL: https://github.com/apache/arrow-datafusion/pull/3985#issuecomment-1297125897
Benchmark runs are scheduled for baseline = 8f1ae58494b78cf4dde237aaa2be0b5037cfc403 and contender = 22dea55937bf890630e8fbddb8047a27ae3f8d14. 22dea55937bf890630e8fbddb8047a27ae3f8d14 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1203826023e54d1693a29c2ded0c1b04...d8d2ce5ac3b74935b7b027a174f47591/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/69efee79f3934cf68edfc8ed9dcfe3a7...6a316e131ee64ac6a2a0eb9f45145535/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d75ae2ec3b924fdcb0f86f44146ce3c2...f7f52e8709254505a99d8bacee24c832/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0a276a0b07a64db090c42e610f2647c8...6632b9d473124e01acf5dfa074d19ee7/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3985: Add Pull Request guidelines to contributor guide
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3985:
URL: https://github.com/apache/arrow-datafusion/pull/3985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3985: Add Pull Request guidelines to contributor guide
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3985:
URL: https://github.com/apache/arrow-datafusion/pull/3985#issuecomment-1297123824
> We could potentially add wording about it specifically being "days" not "business days" or >=1 approval, but LGTM.
I wanted to keep it simple to begin with -- let's try this wording and then refine with additional details if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org