[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #738: Created a camel gson extension #681

[GitBox <gi...@apache.org>]

ppalaga commented on a change in pull request #738: Created a camel gson extension #681
URL: https://github.com/apache/camel-quarkus/pull/738#discussion_r383171072
 
 

 ##########
 File path: integration-tests/dataformats-json/src/main/java/org/apache/camel/quarkus/component/jackson/JsonDataformatsRoute.java
 ##########
 @@ -16,47 +16,93 @@
  */
 package org.apache.camel.quarkus.component.jackson;
 
+import java.lang.reflect.Type;
+import java.util.Arrays;
+import java.util.List;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import com.google.gson.ExclusionStrategy;
+import com.google.gson.FieldAttributes;
+import com.google.gson.FieldNamingPolicy;
+import com.google.gson.reflect.TypeToken;
 import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.gson.GsonDataFormat;
 import org.apache.camel.component.jackson.JacksonDataFormat;
 import org.apache.camel.model.dataformat.JsonLibrary;
 import org.apache.camel.quarkus.component.jackson.model.DummyObject;
+import org.apache.camel.quarkus.component.jackson.model.ExcludeField;
 import org.apache.camel.quarkus.component.jackson.model.PojoA;
 import org.apache.camel.quarkus.component.jackson.model.PojoB;
+import org.apache.camel.spi.DataFormat;
 
 public class JsonDataformatsRoute extends RouteBuilder {
 
     @Override
     public void configure() {
-        JacksonDataFormat format = new JacksonDataFormat(DummyObject.class);
-        format.useList();
+        JacksonDataFormat jacksonDummyObjectDataFormat = new JacksonDataFormat(DummyObject.class);
 
 Review comment:
   Why do these data format variables have the `Dummy` infix in their name? I do not see anything "dummy" in how they are used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services