You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2013/01/18 11:06:11 UTC

[FalconJx] accessor emitter bug

Hi,

When I run a full class through the compiler, accessor member function
blocks (ScopeNode) are empty (type BRACES). However, when I run the
same code through TestGoogAccessorMembers, they are not  (type
SYNTHESIZED) and the tests pass. What could I (or the compiler) be
doing wrong?

EdB



--
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: [FalconJx] accessor emitter bug

Posted by Erik de Bruin <er...@ixsoftware.nl>.

Excellent!

See what I mean by still learning about the code ;-)

EdB



On Fri, Jan 18, 2013 at 11:54 AM, Michael Schmalle
<ap...@teotigraphix.com> wrote:
> Ok, fixed.
>
> Like I said you overrode the emitMethod() that did this parsing. Function
> block parsing is deferred only until needed.
>
>
> Mike
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Ok, 2 commits: one for some new and improved functionality and another
>> offering 2 new test files which, when you un-ignore the second test in
>> TestGoogFiles will show the problem.
>>
>> EdB
>>
>>
>>
>> On Fri, Jan 18, 2013 at 11:21 AM, Erik de Bruin <er...@ixsoftware.nl>
>> wrote:
>>>
>>> Hold on, I'll check in my latest, gotta make the test pass again
>>> first. A couple of minutes...
>>>
>>> EdB
>>>
>>>
>>>
>>> On Fri, Jan 18, 2013 at 11:17 AM, Michael Schmalle
>>> <ap...@teotigraphix.com> wrote:
>>>>
>>>> Hmm,
>>>>
>>>> There is something in the compiler that defers function block parsing
>>>> for
>>>> certain situations.
>>>>
>>>> What is "getAccessor" in context to?
>>>>
>>>> Give me a place to look, it's early here. :)
>>>>
>>>> Mike
>>>>
>>>>
>>>>
>>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>>
>>>>> Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
>>>>> The rest stands, however: the ScopedBlockNodes for accessors are empty
>>>>> (have no children) when I run a full class vs. when I run through
>>>>> 'getAccessor'.
>>>>>
>>>>> EdB
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> When I run a full class through the compiler, accessor member function
>>>>>> blocks (ScopeNode) are empty (type BRACES). However, when I run the
>>>>>> same code through TestGoogAccessorMembers, they are not  (type
>>>>>> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
>>>>>> doing wrong?
>>>>>>
>>>>>> EdB
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Ix Multimedia Software
>>>>>>
>>>>>> Jan Luykenstraat 27
>>>>>> 3521 VB Utrecht
>>>>>>
>>>>>> T. 06-51952295
>>>>>> I. www.ixsoftware.nl
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Ix Multimedia Software
>>>>>
>>>>> Jan Luykenstraat 27
>>>>> 3521 VB Utrecht
>>>>>
>>>>> T. 06-51952295
>>>>> I. www.ixsoftware.nl
>>>>>
>>>>
>>>> --
>>>> Michael Schmalle - Teoti Graphix, LLC
>>>> http://www.teotigraphix.com
>>>> http://blog.teotigraphix.com
>>>>
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: [FalconJx] accessor emitter bug

Posted by Michael Schmalle <ap...@teotigraphix.com>.

Ok, fixed.

Like I said you overrode the emitMethod() that did this parsing.  
Function block parsing is deferred only until needed.

Mike

Quoting Erik de Bruin <er...@ixsoftware.nl>:

> Ok, 2 commits: one for some new and improved functionality and another
> offering 2 new test files which, when you un-ignore the second test in
> TestGoogFiles will show the problem.
>
> EdB
>
>
>
> On Fri, Jan 18, 2013 at 11:21 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>> Hold on, I'll check in my latest, gotta make the test pass again
>> first. A couple of minutes...
>>
>> EdB
>>
>>
>>
>> On Fri, Jan 18, 2013 at 11:17 AM, Michael Schmalle
>> <ap...@teotigraphix.com> wrote:
>>> Hmm,
>>>
>>> There is something in the compiler that defers function block parsing for
>>> certain situations.
>>>
>>> What is "getAccessor" in context to?
>>>
>>> Give me a place to look, it's early here. :)
>>>
>>> Mike
>>>
>>>
>>>
>>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>>
>>>> Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
>>>> The rest stands, however: the ScopedBlockNodes for accessors are empty
>>>> (have no children) when I run a full class vs. when I run through
>>>> 'getAccessor'.
>>>>
>>>> EdB
>>>>
>>>>
>>>>
>>>> On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> When I run a full class through the compiler, accessor member function
>>>>> blocks (ScopeNode) are empty (type BRACES). However, when I run the
>>>>> same code through TestGoogAccessorMembers, they are not  (type
>>>>> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
>>>>> doing wrong?
>>>>>
>>>>> EdB
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Ix Multimedia Software
>>>>>
>>>>> Jan Luykenstraat 27
>>>>> 3521 VB Utrecht
>>>>>
>>>>> T. 06-51952295
>>>>> I. www.ixsoftware.nl
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Ix Multimedia Software
>>>>
>>>> Jan Luykenstraat 27
>>>> 3521 VB Utrecht
>>>>
>>>> T. 06-51952295
>>>> I. www.ixsoftware.nl
>>>>
>>>
>>> --
>>> Michael Schmalle - Teoti Graphix, LLC
>>> http://www.teotigraphix.com
>>> http://blog.teotigraphix.com
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com

Re: [FalconJx] accessor emitter bug

Posted by Erik de Bruin <er...@ixsoftware.nl>.

Ok, 2 commits: one for some new and improved functionality and another
offering 2 new test files which, when you un-ignore the second test in
TestGoogFiles will show the problem.

EdB



On Fri, Jan 18, 2013 at 11:21 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Hold on, I'll check in my latest, gotta make the test pass again
> first. A couple of minutes...
>
> EdB
>
>
>
> On Fri, Jan 18, 2013 at 11:17 AM, Michael Schmalle
> <ap...@teotigraphix.com> wrote:
>> Hmm,
>>
>> There is something in the compiler that defers function block parsing for
>> certain situations.
>>
>> What is "getAccessor" in context to?
>>
>> Give me a place to look, it's early here. :)
>>
>> Mike
>>
>>
>>
>> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>>
>>> Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
>>> The rest stands, however: the ScopedBlockNodes for accessors are empty
>>> (have no children) when I run a full class vs. when I run through
>>> 'getAccessor'.
>>>
>>> EdB
>>>
>>>
>>>
>>> On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl>
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> When I run a full class through the compiler, accessor member function
>>>> blocks (ScopeNode) are empty (type BRACES). However, when I run the
>>>> same code through TestGoogAccessorMembers, they are not  (type
>>>> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
>>>> doing wrong?
>>>>
>>>> EdB
>>>>
>>>>
>>>>
>>>> --
>>>> Ix Multimedia Software
>>>>
>>>> Jan Luykenstraat 27
>>>> 3521 VB Utrecht
>>>>
>>>> T. 06-51952295
>>>> I. www.ixsoftware.nl
>>>
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>>
>>
>> --
>> Michael Schmalle - Teoti Graphix, LLC
>> http://www.teotigraphix.com
>> http://blog.teotigraphix.com
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: [FalconJx] accessor emitter bug

Posted by Erik de Bruin <er...@ixsoftware.nl>.

Hold on, I'll check in my latest, gotta make the test pass again
first. A couple of minutes...

EdB



On Fri, Jan 18, 2013 at 11:17 AM, Michael Schmalle
<ap...@teotigraphix.com> wrote:
> Hmm,
>
> There is something in the compiler that defers function block parsing for
> certain situations.
>
> What is "getAccessor" in context to?
>
> Give me a place to look, it's early here. :)
>
> Mike
>
>
>
> Quoting Erik de Bruin <er...@ixsoftware.nl>:
>
>> Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
>> The rest stands, however: the ScopedBlockNodes for accessors are empty
>> (have no children) when I run a full class vs. when I run through
>> 'getAccessor'.
>>
>> EdB
>>
>>
>>
>> On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl>
>> wrote:
>>>
>>> Hi,
>>>
>>> When I run a full class through the compiler, accessor member function
>>> blocks (ScopeNode) are empty (type BRACES). However, when I run the
>>> same code through TestGoogAccessorMembers, they are not  (type
>>> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
>>> doing wrong?
>>>
>>> EdB
>>>
>>>
>>>
>>> --
>>> Ix Multimedia Software
>>>
>>> Jan Luykenstraat 27
>>> 3521 VB Utrecht
>>>
>>> T. 06-51952295
>>> I. www.ixsoftware.nl
>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: [FalconJx] accessor emitter bug

Posted by Michael Schmalle <ap...@teotigraphix.com>.

Hmm,

There is something in the compiler that defers function block parsing  
for certain situations.

What is "getAccessor" in context to?

Give me a place to look, it's early here. :)

Mike


Quoting Erik de Bruin <er...@ixsoftware.nl>:

> Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
> The rest stands, however: the ScopedBlockNodes for accessors are empty
> (have no children) when I run a full class vs. when I run through
> 'getAccessor'.
>
> EdB
>
>
>
> On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>> Hi,
>>
>> When I run a full class through the compiler, accessor member function
>> blocks (ScopeNode) are empty (type BRACES). However, when I run the
>> same code through TestGoogAccessorMembers, they are not  (type
>> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
>> doing wrong?
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com

Re: [FalconJx] accessor emitter bug

Posted by Erik de Bruin <er...@ixsoftware.nl>.

Hold on, forget what I wrote about the type (BRACES vs. SYNTHESIZED).
The rest stands, however: the ScopedBlockNodes for accessors are empty
(have no children) when I run a full class vs. when I run through
'getAccessor'.

EdB



On Fri, Jan 18, 2013 at 11:06 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Hi,
>
> When I run a full class through the compiler, accessor member function
> blocks (ScopeNode) are empty (type BRACES). However, when I run the
> same code through TestGoogAccessorMembers, they are not  (type
> SYNTHESIZED) and the tests pass. What could I (or the compiler) be
> doing wrong?
>
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl