[GitHub] [hbase] Apache9 commented on a change in pull request #291: HBASE-22550 Do not use Threads.newDaemonThreadFactory in ConnectionUt…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #291: HBASE-22550 Do not use Threads.newDaemonThreadFactory in ConnectionUt…
URL: https://github.com/apache/hbase/pull/291#discussion_r291796654
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionOverAsyncConnection.java
 ##########
 @@ -134,13 +139,25 @@ public boolean isClosed() {
     return conn.isClosed();
   }
 
+  private ThreadPoolExecutor createThreadPool() {
+    Configuration conf = conn.getConfiguration();
+    int threads = conf.getInt("hbase.hconnection.threads.max", 256);
 
 Review comment:
   This is just for the legacy coprocessor methods, if you do not call coprocessor related methods then there will be no thread pool. And the coprocessor methods have been deprecated and will be removed in 4.0.0, users are expected to call the ones in async client instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services