You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/09/19 22:46:47 UTC

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep". 

Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11478


Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................

Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

This instructs git to pretend that certain "minimized" and debugging
Bootstrap-related files are treated as binary by git tools, especially
"git grep". As a result, doing something like "git grep pause" won't
yield a wall of indecipherable JavaScript.

Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
---
A .gitattributes
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/11478/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3183/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 03:55:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 4: Code-Review+2

Carrying Tim's +2. Build issue was a rat check for .gitattributes; added it to the ignore list as is done for .gitignore.


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 03:55:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3182/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:27:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/723/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:48:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/721/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:30:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:27:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11478

to look at the new patch set (#4).

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................

Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

This instructs git to pretend that certain "minimized" and debugging
Bootstrap-related files are treated as binary by git tools, especially
"git grep". As a result, doing something like "git grep pause" won't
yield a wall of indecipherable JavaScript.

Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
---
A .gitattributes
M bin/rat_exclude_files.txt
2 files changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/11478/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/728/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 04:26:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 03:55:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11478

to look at the new patch set (#2).

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................

Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

This instructs git to pretend that certain "minimized" and debugging
Bootstrap-related files are treated as binary by git tools, especially
"git grep". As a result, doing something like "git grep pause" won't
yield a wall of indecipherable JavaScript.

Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
---
A .gitattributes
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/11478/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 1:

There's also some minified JS under ./www:
./www/dagre-d3.min.js
./www/bootstrap/js/bootstrap.min.js
./www/datatables.min.js
./www/jquery/jquery-1.12.4.min.js
./www/d3.v3.min.js
./www/DataTables-1.10.12/js/dataTables.jqueryui.min.js
./www/DataTables-1.10.12/js/jquery.dataTables.min.js
./www/DataTables-1.10.12/js/dataTables.foundation.min.js
./www/DataTables-1.10.12/js/dataTables.bootstrap.min.js


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:09:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 16:32:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3182/


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 02:38:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3183/


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 05:35:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3201/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 16:32:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................

Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

This instructs git to pretend that certain "minimized" and debugging
Bootstrap-related files are treated as binary by git tools, especially
"git grep". As a result, doing something like "git grep pause" won't
yield a wall of indecipherable JavaScript.

Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Reviewed-on: http://gerrit.cloudera.org:8080/11478
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A .gitattributes
M bin/rat_exclude_files.txt
2 files changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 7
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 20:09:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 23:17:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".
......................................................................


Patch Set 6:

The build failure looks unrelated to this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 16:33:02 +0000
Gerrit-HasComments: No