You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Johannes Koch (JIRA)" <xe...@xml.apache.org> on 2009/07/17 12:45:14 UTC

[jira] Created: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Make HTMLCollectionImpl serializable
------------------------------------

                 Key: XERCESJ-1386
                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
             Project: Xerces2-J
          Issue Type: Bug
          Components: DOM (HTML)
    Affects Versions: 2.9.0
            Reporter: Johannes Koch


All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Resolved: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich resolved XERCESJ-1386.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.10.0

As requested, I've made HTMLCollectionImpl serializable. See SVN rev 890182.

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>            Assignee: Michael Glavassevich
>             Fix For: 2.10.0
>
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Commented: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Johannes Koch (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732498#action_12732498 ] 

Johannes Koch commented on XERCESJ-1386:
----------------------------------------

Michael,

there's no requirement that a DOM be serializable; true. However, if a super-type (NodeImpl) is serializable, then all sub-types of this type are also serializable. But HTMLDocumentImpl, HTMLFormElementImpl, HTMLTableElementImpl and TableSectionElementImpl (being sub-types of NodeImpl) are in fact not serializable, because they have at least one non-serializable instance variable.

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Commented: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789993#action_12789993 ] 

Michael Glavassevich commented on XERCESJ-1386:
-----------------------------------------------

Implementing java.io.Serializable is not a guarantee that an object can be serialized. Take the Java collection (java.util) classes for example. The Map and List classes can contain non-serializable instances and an attempt to serialize these Collections will fail if they contain such objects. The PSVI DOM is another example. There are explicit guards in place to prevent it from being serialized because there's no serialization support for the XSModel. Here however, I think there was no intention to block serialization of HTML DOMs so I'm going to honour your request.

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Issue Comment Edited: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789993#action_12789993 ] 

Michael Glavassevich edited comment on XERCESJ-1386 at 12/14/09 5:22 AM:
-------------------------------------------------------------------------

Implementing java.io.Serializable is not a guarantee that an object can be serialized. Take the Java collection (java.util) classes for example. The Map and List classes can contain non-serializable instances and an attempt to serialize these Collections will fail if they contain such objects. The PSVI DOM is another example. There are explicit guards in place to prevent it from being serialized because there's no serialization support for the XSModel. Here however I think there was no intention to block serialization of HTML DOMs so I'm going to honour your request.

      was (Author: mrglavas@ca.ibm.com):
    Implementing java.io.Serializable is not a guarantee that an object can be serialized. Take the Java collection (java.util) classes for example. The Map and List classes can contain non-serializable instances and an attempt to serialize these Collections will fail if they contain such objects. The PSVI DOM is another example. There are explicit guards in place to prevent it from being serialized because there's no serialization support for the XSModel. Here however, I think there was no intention to block serialization of HTML DOMs so I'm going to honour your request.
  
> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>            Assignee: Michael Glavassevich
>             Fix For: 2.10.0
>
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Closed: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Johannes Koch (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Koch closed XERCESJ-1386.
----------------------------------


Thanks

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>            Assignee: Michael Glavassevich
>             Fix For: 2.10.0
>
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Updated: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich updated XERCESJ-1386:
------------------------------------------

    Affects Version/s:     (was: 2.9.0)
                       2.9.1
           Issue Type: Improvement  (was: Bug)

Technically this isn't a bug. There's no requirement that a DOM be serializable so I'm marking this as an "improvement".

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Assigned: (XERCESJ-1386) Make HTMLCollectionImpl serializable

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich reassigned XERCESJ-1386:
---------------------------------------------

    Assignee: Michael Glavassevich

> Make HTMLCollectionImpl serializable
> ------------------------------------
>
>                 Key: XERCESJ-1386
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1386
>             Project: Xerces2-J
>          Issue Type: Improvement
>          Components: DOM (HTML)
>    Affects Versions: 2.9.1
>            Reporter: Johannes Koch
>            Assignee: Michael Glavassevich
>
> All HTML element implementations extend org.apache.xerces.dom.NodeImpl, which implements java.io.Serializable. Some HTML element implementations contain instance variables of type org.apache.html.dom.HTMLCollectionImpl, which does not implement java.io.Serializable. So these HTML element implementations are in fact not serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org