[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1229: #1228 sync model

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #1229:
URL: https://github.com/apache/servicecomb-service-center/pull/1229#discussion_r786591585



##########
File path: datasource/manager.go
##########
@@ -66,6 +67,7 @@ func Init(opts Options) error {
 		return err
 	}
 
+	EnableSync = config.GetBool("syncer.enabled", false)

Review comment:
       先放到runtime包下，运行时的状态不能分散管理

##########
File path: client/set.go
##########
@@ -1,7 +1,7 @@
 package client
 
 import (
-	v1sync "github.com/apache/servicecomb-service-center/api/sync/v1"
+	v1sync "github.com/apache/servicecomb-service-center/syncer/api/v1"

Review comment:
       syncer并没有拆库的打算，而是打算长期采用mono repo的管理方式，syncer的api，都扔到代码库根目录下统一管理才是对的




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org