You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by pkuwm <gi...@git.apache.org> on 2016/05/03 00:31:27 UTC
[GitHub] incubator-eagle pull request: EAGLE-289: Fix $elem["dataSource"] i...
GitHub user pkuwm opened a pull request:
https://github.com/apache/incubator-eagle/pull/170
EAGLE-289: Fix $elem["dataSource"] in alert email
It seems that the file eagle-core/eagle-alert/eagle-alert-process/src/main/resources/ALERT_DEFAULT.vm is deleted in dev branch, but it is still in master branch. So we still need to fix it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pkuwm/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 831102996570b87a83cdb6fb19fd6fe8e5af56a3
Author: Lu <hn...@lm-sjc-11002130.corp.ebay.com>
Date: 2016-05-02T22:26:42Z
EAGLE-289: Fix $elem["dataSource"] in alert email
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-289: Fix $elem["dataSource"] i...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/170#issuecomment-216418981
For pull request #170, I don't think it's a good fix (the code needs testing)
Here is my fix in the dev branch, and tested it.
https://github.com/apache/incubator-eagle/commit/035a9f6949e3ef378e98c9fad84c3087afef5e4d
Would you like to help merge this patch to the master branch? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-289: Fix $elem["dataSource"] i...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/170#issuecomment-216417423
It's not a good practice to send the two pull requests (for both EAGLE-287 and EAGLE-289) in the same pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-289: Fix $elem["dataSource"] i...
Posted by pkuwm <gi...@git.apache.org>.
Github user pkuwm closed the pull request at:
https://github.com/apache/incubator-eagle/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-289: Fix $elem["dataSource"] i...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/170#issuecomment-216385429
reviewed please merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---