You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2019/03/30 21:33:00 UTC
[jira] [Commented] (HBASE-22138) [hbase-thirdparty] Undo our
dependence on protos in google.protobuf; e.g. Timestamp, Duration...
[ https://issues.apache.org/jira/browse/HBASE-22138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805989#comment-16805989 ]
stack commented on HBASE-22138:
-------------------------------
It looks there is only one violation though it is in a core type.
$ grep -r google.protobuf . |grep -v com.google.protobuf
./hbase-protocol-shaded/src/main/protobuf/Procedure.proto:import "google/protobuf/any.proto";
./hbase-protocol-shaded/src/main/protobuf/Procedure.proto: repeated google.protobuf.Any state_message = 15; // opaque (user) procedure internal-state
It is used in the Procedure defintion....
repeated google.protobuf.Any state_message = 15; // opaque (user) procedure internal-state
Introduced here:
commit c48dc02b7611dca305940b737cbddd07039dd30b
Author: Balazs Meszaros <ba...@cloudera.com>
Date: Wed Sep 6 15:21:32 2017 +0200
HBASE-18106 Redo ProcedureInfo and LockInfo
Used listing lock and procedure info.
> [hbase-thirdparty] Undo our dependence on protos in google.protobuf; e.g. Timestamp, Duration...
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-22138
> URL: https://issues.apache.org/jira/browse/HBASE-22138
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Priority: Major
> Fix For: thirdparty-2.3.0
>
>
> in our shaded jar, we've bundled a few unshaded google protos. We make use of these protos in some of our core classes. What is needed is a bit of careful work undoing our dependence on these types being careful to unsure we don't break compatibility (it should be fine but needs some careful operation).
> I've targeted this at the next version of hbase-thirdparty.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)