You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@lnd.com> on 2000/04/28 08:04:50 UTC

Ich... commit mails not mailing!?!

Bill,

  Last q of the night...

D:\live>cvs commit -f -F winfix.txt apache-2.0/src/os/win32/os.h
Enter passphrase for RSA key 'wrowe@locus.apache.org':
Checking in apache-2.0/src/os/win32/os.h;
/home/cvs/apache-2.0/src/os/win32/os.h,v  <--  os.h
new revision: 1.23; previous revision: 1.22
done
Mailing the commit message...

  I didn't see a message to myself, and I am on the cvs-update
mailing list!?!  Thoughts?

Bill

Re: Ich... [My] commit mails not mailing!?!

Posted by Manoj Kasichainula <ma...@io.com>.
On Fri, Apr 28, 2000 at 01:37:49AM -0500, William A. Rowe, Jr. wrote:
> Then I don't know what's going on...

I'm guessing ezmlm isn't set up to accept your messages on the
apache-cvs list. I don't know the ezmlm setup well enough to fix it;
I'm trying, though.


RE: Ich... [My] commit mails not mailing!?!

Posted by "William A. Rowe, Jr." <wr...@lnd.com>.
> -----Original Message-----
> From: Manoj Kasichainula [mailto:manojk@io.com]
> Sent: Friday, April 28, 2000 1:19 AM
> 
> On Fri, Apr 28, 2000 at 01:04:50AM -0500, William A. Rowe, Jr. wrote:
> >   I didn't see a message to myself, and I am on the cvs-update
> > mailing list!?!  Thoughts?
> 
> Just got a commit message:
> 
> : bjh         00/04/27 23:15:53
> : 
> :   Modified:    src/build rules.mk
> : 
 
Then I don't know what's going on... here is the summary of my cvs
changes tonight.  I won't commit any further until we figure out
what happened... these were the deal breakers anyway, the other
suggested patches could wait till the weekend... if I have any
feedback.


Revision 1.16 / (download) - [select for diffs] , 
Fri Apr 28 06:28:51 2000 UTC (6 minutes, 17 seconds ago) by wrowe 
Branch: MAIN 
CVS Tags: HEAD 
Changes since 1.15: +0 -1 lines 
Diff to previous 1.15 
  Whoops... ungetchar wasn't used on Win32 either... but we
  seem to be broken.  This finished up that patch on another os.

===================================================================
RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/win32/pipe.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- apache-2.0/src/lib/apr/file_io/win32/pipe.c	2000/04/27 11:19:30	1.15
+++ apache-2.0/src/lib/apr/file_io/win32/pipe.c	2000/04/28 06:28:51	1.16
@@ -101,7 +101,6 @@
     (*in)->pipe = 1;
     (*in)->fname = ap_pstrdup(cont, "PIPE");
     (*in)->timeout = -1;
-    (*in)->ungetchar = -1;
 
     (*out) = (ap_file_t *)ap_pcalloc(cont, sizeof(ap_file_t));
     (*out)->cntxt = cont;


Revision 1.23 / (download) - [select for diffs] , 
Fri Apr 28 05:59:32 2000 UTC (6 minutes, 17 seconds ago) by wrowe 
Branch: MAIN 
CVS Tags: HEAD 
Changes since 1.22: +0 -0 lines 
Diff to previous 1.22 
  Untangle Win32 build errors.  

  #define str*casecmp as stricmp causes reinterpretation of 
  str*casecmp function declarations.  This creates dozens of
  compiler emits.  Since there is no need, the HAVE_STRCASECMP
  macros wipe out the redeclaration.

  This is my second and last hack for the evening...
  spent way to much time fighting the windoze cvs/ssh
  learning curve!  Sorry for the previous nonsense docs of 
  rev 1.22 - still fighting to use the editor for docs :-)


Revision 1.22 / (download) - [select for diffs] , 
Fri Apr 28 05:50:17 2000 UTC (15 minutes, 32 seconds ago) by wrowe 
Branch: MAIN 
Changes since 1.21: +4 -0 lines 
Diff to previous 1.21 
  Replace ERROR constant with TODO_ERROR to flag these for review.

  ERROR is a Windows.h constant of 0, or success, and is unrelated
  to the error codes!

===================================================================
RCS file: /home/cvs/apache-2.0/src/os/win32/os.h,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- apache-2.0/src/os/win32/os.h	2000/04/14 15:59:17	1.21
+++ apache-2.0/src/os/win32/os.h	2000/04/28 05:50:17	1.22
@@ -131,6 +131,10 @@
 
 #define MODULE_VAR_EXPORT   __declspec(dllexport)
 
+
+#define HAVE_STRCASECMP
+#define HAVE_STRNCASECMP
+
 #define strcasecmp(s1, s2) stricmp(s1, s2)
 #define strncasecmp(s1, s2, n) strnicmp(s1, s2, n)
 #define lstat(x, y) stat(x, y)


Revision 1.8 / (download) - [select for diffs] , 
Fri Apr 28 05:41:36 2000 UTC (5 minutes, 4 seconds ago) by wrowe 

  Replace ERROR constant with TODO_ERROR to flag these for review.

  ERROR is a Windows.h constant of 0, or success, and is unrelated
  to the error codes!

===================================================================
RCS file: /home/cvs/apache-2.0/src/os/win32/mod_isapi.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- apache-2.0/src/os/win32/mod_isapi.c	2000/04/15 19:23:08	1.7
+++ apache-2.0/src/os/win32/mod_isapi.c	2000/04/28 05:41:36	1.8
@@ -88,6 +88,10 @@
 /* We use the exact same header file as the original */
 #include <HttpExt.h>
 
+/* TODO: Unknown errors that must be researched for correct codes */
+
+#define TODO_ERROR 1
+
 /* Seems IIS does not enforce the requirement for \r\n termination on HSE_REQ_SEND_RESPONSE_HEADER,
    define this to conform */
 #define RELAX_HEADER_RULE
@@ -370,7 +374,7 @@
     }
 
     if ((writ = ap_rwrite(Buffer, *lpwdwBytes, r)) == EOF) {
-            SetLastError(ERROR); /* TODO: Find the right error code */
+            SetLastError(WSAEDISCON); /* TODO: Find the right error code */
             return FALSE;
     }
 
@@ -453,7 +457,7 @@
                 if (!lf) { /* Huh? Invalid data, I think */
                         ap_log_rerror(APLOG_MARK, APLOG_ERR, r,
                                     "ISA sent invalid headers: %s", r->filename);
-                        SetLastError(ERROR);    /* XXX: Find right error */
+                        SetLastError(TODO_ERROR);
                         return FALSE;
                 }
 
@@ -473,7 +477,7 @@
                 }
 
                 if (!(value = strchr(data, ':'))) {
-                        SetLastError(ERROR);    /* TODO: Find right error */
+                        SetLastError(TODO_ERROR);
                         ap_log_rerror(APLOG_MARK, APLOG_ERR, SERVER_ERROR, r,
                                           "ISA sent invalid headers", r->filename);
                         return FALSE;



Re: Ich... commit mails not mailing!?!

Posted by Manoj Kasichainula <ma...@io.com>.
On Fri, Apr 28, 2000 at 01:04:50AM -0500, William A. Rowe, Jr. wrote:
>   I didn't see a message to myself, and I am on the cvs-update
> mailing list!?!  Thoughts?

Just got a commit message:

: bjh         00/04/27 23:15:53
: 
:   Modified:    src/build rules.mk
: