[GitHub] [helix] narendly commented on a change in pull request #846: [WIP] Make ZKHelixAdmin and ZKHelixManager Realm-aware

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #846: [WIP] Make ZKHelixAdmin and ZKHelixManager Realm-aware
URL: https://github.com/apache/helix/pull/846#discussion_r387493543
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
 ##########
 @@ -118,6 +118,11 @@ public ConfigAccessor(HelixZkClient zkClient) {
     _usesExternalZkClient = true;
   }
 
+  public ConfigAccessor(RealmAwareZkClient zkClient) {
+    _zkClient = zkClient;
+    _usesExternalZkClient = true;
+  }
 
 Review comment:
   The new ConfigAccessor should be created with a Builder. I'm going to assume that this is just a placeholder? :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org