You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2026/10/11 07:28:14 UTC
[PR] Benchmark: Remove unused code [polaris-tools]
MonkeyCanCode opened a new pull request, #287:
URL: https://github.com/apache/polaris-tools/pull/287
Code cleanup for benchmark tool where unused code are now removed from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Benchmark: Remove unused code [polaris-tools]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on code in PR #287:
URL: https://github.com/apache/polaris-tools/pull/287#discussion_r4284234601
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/NAryTreeBuilder.scala:
##########
@@ -46,37 +46,6 @@ case class NAryTreeBuilder(nsWidth: Int, nsDepth: Int) {
pathToRoot(parent, ordinal :: acc)
}
- /**
- * Computes the ordinals of all child nodes for a given node.
- *
- * @param ordinal the ordinal of the parent node
- * @return a list of ordinals representing the child nodes
- */
- def childrenOf(ordinal: Int): List[Int] =
Review Comment:
Sure thing. Restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Benchmark: Remove unused code [polaris-tools]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #287:
URL: https://github.com/apache/polaris-tools/pull/287#issuecomment-6220919428
@dimas-b any other concerns before I merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Benchmark: Remove unused code [polaris-tools]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode merged PR #287:
URL: https://github.com/apache/polaris-tools/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Benchmark: Remove unused code [polaris-tools]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #287:
URL: https://github.com/apache/polaris-tools/pull/287#issuecomment-6227639839
Thanks for review @flyrain and @dimas-b. There are more enhancements I made locally around this tool, I will raise them a bit later this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Benchmark: Remove unused code [polaris-tools]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #287:
URL: https://github.com/apache/polaris-tools/pull/287#discussion_r4279960766
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/NAryTreeBuilder.scala:
##########
@@ -46,37 +46,6 @@ case class NAryTreeBuilder(nsWidth: Int, nsDepth: Int) {
pathToRoot(parent, ordinal :: acc)
}
- /**
- * Computes the ordinals of all child nodes for a given node.
- *
- * @param ordinal the ordinal of the parent node
- * @return a list of ordinals representing the child nodes
- */
- def childrenOf(ordinal: Int): List[Int] =
Review Comment:
Even if this is unused now, the code looks helpful to me in general, in this benchmark's context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org