[jira] [Commented] (S2GRAPH-76) Move orderBy, groupBy logic from PostProcess into Graph#getEdges inside.

["DOYUNG YOON (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304079#comment-15304079 ] 

DOYUNG YOON commented on S2GRAPH-76:
------------------------------------

Maybe Define better representation of Edge that can be converted easily into Json or other type easily should be separated into single issue.

> Move orderBy, groupBy logic from PostProcess into Graph#getEdges inside.
> ------------------------------------------------------------------------
>
>                 Key: S2GRAPH-76
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-76
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> My suggestion in one line, is make PostProcess simply build json from result type of getEdges and make getEdges build complete query result.
> Current return type of Graph#getEdges is not sufficient enough.
> GroupBy, OrderBy, or merging multiple queries result is located on PostProcess, not inside of getEdges.
> Followings are subtasks to resolve this issue.
> 1. Define better return type of getEdges.
> 2. Refactor getEdges to process orderBy, groupBy.
> 3. Define better representation of Edge that can be converted easily into Json or other type easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)