[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4446: Deprecate /riak/ping and add /vault/ping

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4446: Deprecate /riak/ping and add /vault/ping
URL: https://github.com/apache/trafficcontrol/pull/4446#discussion_r385272179
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/ping/riak.go
 ##########
 @@ -21,24 +21,34 @@ package ping
 
 import (
 	"errors"
+	"fmt"
 	"net/http"
 
+	"github.com/apache/trafficcontrol/lib/go-tc"
 	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
 	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/riaksvc"
 )
 
 func Riak(w http.ResponseWriter, r *http.Request) {
+	alerts := tc.CreateAlerts(tc.WarnLevel, fmt.Sprintf("This endpoint is deprecated, please use GET /vault/ping instead"))
 
 Review comment:
   This should also specify the API version, since it has to change in order for the alternative to be used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services