[GitHub] erisu commented on issue #848: Remove deprecated platforms from plugin page

[GitBox <gi...@apache.org>]

erisu commented on issue #848: Remove deprecated platforms from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#issuecomment-406102987
 
 
   @raphinesse I updated the proposal. I added the platform keyword to the sortedPlatforms collection.
   Example: ` {keyword: 'cordova-android', icon: 'android', alt: 'Android'},`
   
   The proposed filter `.filter(platform => keywords.has(platform))` did not work because the `keywords` are not identical to `platform`. 
   
   The `keywords` contains a collection of keywords taken from the npm package.json.
   For example [cordova-plugin-whitelist](https://www.npmjs.com/package/cordova-plugin-whitelist) you can see the list of keywords at the bottom as `cordova, whitelist, ecosystem:cordova, cordova-android`
   
   filter was updated as so: `.filter(platform => keywords.has(platform.keyword))`
   With this, the keyword `cordova-android` will now match platform.keyword `cordova-android`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org