You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2016/05/02 17:40:07 UTC

[GitHub] spark pull request: [SPARK-14346] SHOW CREATE TABLE for data sourc...

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12781#discussion_r61772980
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -45,7 +45,9 @@ statement
         | ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList     #setDatabaseProperties
         | DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?      #dropDatabase
         | createTableHeader ('(' colTypeList ')')? tableProvider
    -        (OPTIONS tablePropertyList)?                                   #createTableUsing
    +        (OPTIONS tablePropertyList)?
    +        (PARTITIONED BY partitionColumnNames=identifierList)?
    +        bucketSpec?                                                    #createTableUsing
    --- End diff --
    
    @cloud-fan Do we allow users to specify bucketing without providing partitioning columns? Seems only `DynamicPartitionWriterContainer` support bucketSpec?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org