[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4065: [INLONG-4030][Sort] Import data in Canal JSON format from Kafka into Hive in insert-only mode

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #4065:
URL: https://github.com/apache/incubator-inlong/pull/4065#discussion_r865566020


##########
inlong-sort/sort-formats/format-json/src/main/java/org/apache/inlong/sort/formats/json/canal/CanalJsonEnhancedDeserializationSchema.java:
##########
@@ -224,6 +236,11 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
             }
             final GenericRowData row = (GenericRowData) jsonDeserializer.convertToRowData(root);
             String type = row.getString(2).toString(); // "type" field
+            // only not appendMode type field is valid
+            if (appendMode) {

Review Comment:
   This judgment should be removed to avoid the type of output being INSERT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org