[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3679: [CARBONDATA-3751]: Segments are not Marked for delete if everything is deleted in a segment with index server enabled

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#discussion_r407363310
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
 ##########
 @@ -168,7 +169,7 @@ public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boo
       throws IOException {
     super.write(out);
     if (isCountJob) {
-      out.writeLong(inputSplit.getRowCount());
+      out.writeLong(inputSplit.getIndexRow().getInt(BlockletIndexRowIndexes.ROW_COUNT_INDEX));
 
 Review comment:
   Please add below comment on separate commit, I will merge this.
   
   In CarbonInputSplit, getDetailInfo() is a lazy call. we want to avoid this during count(*). As rowCount is filled inside getDetailInfo(). In count(*) case we may not have proper row count. So, always take row count from indexRow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services