[GitHub] [activemq-artemis] jbertram commented on pull request #3638: ARTEMIS-3369 only remove destination prefixes that are recognized

[GitBox <gi...@apache.org>]

jbertram commented on pull request #3638:
URL: https://github.com/apache/activemq-artemis/pull/3638#issuecomment-873434780


   These tests should be in the test-suite for 2 reasons:
   - Validate the fix
   - Prevent regressions in the future
   
   See `org.apache.activemq.cli.test.ArtemisTest` for other automated CLI tests. It should be pretty straight-forward to add your tests in there.
   
   Additional thoughts:
    - The `anycastPrefix` and `multicastPrefix` are useful mainly for protocols that have no semantic distinctions for their destinations (e.g. STOMP). The CLI uses JMS which *does* have semantic distinctions for its destinations. That is why it has the built-in `queue://` and `topic://` prefixes for determining semantics. Therefore, I'm not sure it makes a lot of sense to use custom prefixes on the CLI when built-in prefixes already exist to do the same work.
    - The broker will *strip* any configured prefix. So, for example, if you had `anycastPrefix=foo://` and you used `foo://myQueue` from a client then the broker would strip `foo://` from the name and just use `myQueue` with anycast semantics. In your example, if you actually had `anycastPrefix=xyz://` the second screenshot would look exactly like the first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org