You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/29 08:43:21 UTC

[GitHub] [skywalking] BFergerson opened a new pull request #4840: Increased Vert.x support

BFergerson opened a new pull request #4840:
URL: https://github.com/apache/skywalking/pull/4840

- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [x] Improve performance

- Related issues

___
### Bug fix

Fixes https://github.com/apache/skywalking/issues/3338. @wentjiang had the right idea for the fix but the method chosen to enhance is not present ver. 3.5+. I've chosen another method that also works and is present in all versions.

___
### New feature or improvement

I added support for ver. 3.9.1 as well for more complex route handling. The tests I've been using were too simple so I made them more realisitic. The tests I'm using now look like:
- User sends request to `/web-case`
- `/web-case` sends a request to `/healthcheck` (ver. 3.5- = sync / ver. 3.6+ = async)
- Once response is recieved another request is sent to `/withBodyHandler` (ver. 3.5- = sync / ver. 3.6+ = async)
- Before `/withBodyHandler` is called this is processed by Vert.x's internal `BodyHandler`
- `BodyHandler` passes request off to `/withBodyHandler`
- Once the response is received the original request to `/web-case` is responded to

This results in the segment trace stack:
```
ENTER: /case/web-case
ASYNC SPAN STARTED [1]
LOCAL: VertxWebController$$Lambda$.handle(RoutingContext)
EXIT: /case/healthCheck
ASYNC SPAN STARTED [2]
CLOSE EXIT
CLOSE LOCAL
CLOSE ENTER

ENTER: /case/healthCheck
ASYNC SPAN STARTED [3]
LOCAL: VertxWebController$$Lambda$.handle(RoutingContext)
ASYNC SPAN FINISHED [3]
CLOSE LOCAL
CLOSE ENTER

ASYNC SPAN FINISHED [2]
LOCAL: #/case/healthCheck
EXIT: /case/web-case/withBodyHandler
ASYNC SPAN STARTED [4]
CLOSE EXIT
CLOSE LOCAL

ENTER: /case/web-case/withBodyHandler
ASYNC SPAN STARTED [5]
LOCAL: BodyHandlerImpl.handle(RoutingContext)
EXIT LOCAL
CLOSE ENTER

LOCAL: VertxWebController$$Lambda$.handle(RoutingContext)
ASYNC SPAN FINISHED [5]
CLOSE LOCAL

ASYNC SPAN FINISHED [4]
LOCAL: #/vertx-web-3_54minus-scenario/case/web-case/withBodyHandler
ASYNC SPAN FINISHED [1]
CLOSE LOCAL
```

If you look at the above the `ENTER: /case/web-case/withBodyHandler` is called on a separate context than `LOCAL: VertxWebController$$Lambda$.handle(RoutingContext)`. This is because of the added `BodyHandlerImpl.handle(RoutingContext)`. This would occur with any additional handlers before the user-code handler. With the added solution you can add additional handlers (e.g. `CorsHandler`) and it'll still result in the spans being created correctly:
![trace-list](https://user-images.githubusercontent.com/3278877/83239063-591ef480-a1a8-11ea-9afb-65a37c5d7c0e.png)

Apologies for the constant changes. I believe this PR to offer the most thorough support and I wanted to make sure to get better Vert.x support in SkyWalking 8.0.0. When I saw the previous PR couldn't support 3.9.1, I rushed it through because I saw there were bigger changes that I needed to make and I wasn't sure how quickly I could make them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org