You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/24 11:03:17 UTC
[GitHub] [bookkeeper] nodece opened a new pull request #3076: Fix release the CompletionKey
nodece opened a new pull request #3076:
URL: https://github.com/apache/bookkeeper/pull/3076
Signed-off-by: Zixuan Liu <no...@gmail.com>
### Motivation
The `CompletionKey` resources are released many times:
- first - [org/apache/bookkeeper/proto/PerChannelBookieClient.java:1343](https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L1343)
- second - [org/apache/bookkeeper/proto/PerChannelBookieClient.java:1865](https://github.com/apache/bookkeeper/blob/434996d93c335148b04f996f04fb791cacde9f02/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L1865)
Throw log:
```
13:32:45.102 [BookKeeperClientWorker-OrderedExecutor-1-0] INFO org.apache.bookkeeper.client.PendingReadOp - Error: Bookie operation timeout while reading L43555 E365 from bookie: dev-hyd-1-pulsar-bookie-3.dev-hyd-1-pulsar-bookie.viesti-dev.svc.cluster.local:3181
13:32:45.102 [BookKeeperClientWorker-OrderedExecutor-1-0] ERROR org.apache.bookkeeper.common.util.SafeRunnable - Unexpected throwable caught
java.lang.IllegalStateException: recycled already
at io.netty.util.Recycler$Stack.pushNow(Recycler.java:674) ~[io.netty-netty-common-4.1.68.Final.jar:4.1.68.Final]
at io.netty.util.Recycler$Stack.push(Recycler.java:663) ~[io.netty-netty-common-4.1.68.Final.jar:4.1.68.Final]
at io.netty.util.Recycler$DefaultHandle.recycle(Recycler.java:245) ~[io.netty-netty-common-4.1.68.Final.jar:4.1.68.Final]
at org.apache.bookkeeper.proto.PerChannelBookieClient$V2CompletionKey.release(PerChannelBookieClient.java:2361) ~[org.apache.bookkeeper-bookkeeper-server-4.12.0.jar:4.12.0]
at org.apache.bookkeeper.proto.PerChannelBookieClient$ReadCompletion$1.readEntryComplete(PerChannelBookieClient.java:1865) ~[org.apache.bookkeeper-bookkeeper-server-4.12.0.jar:4.12.0]
at org.apache.bookkeeper.proto.PerChannelBookieClient$ReadCompletion.lambda$errorOut$0(PerChannelBookieClient.java:1878) ~[org.apache.bookkeeper-bookkeeper-server-4.12.0.jar:4.12.0]
at org.apache.bookkeeper.proto.PerChannelBookieClient$CompletionValue$1.safeRun(PerChannelBookieClient.java:1671) ~[org.apache.bookkeeper-bookkeeper-server-4.12.0.jar:4.12.0]
at org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_312]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_312]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.68.Final.jar:4.1.68.Final]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
```
### Changes
- Remove first release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nodece closed pull request #3076: Fix release the CompletionKey
Posted by GitBox <gi...@apache.org>.
nodece closed pull request #3076:
URL: https://github.com/apache/bookkeeper/pull/3076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] prodigy91 commented on pull request #3076: Fix release the CompletionKey
Posted by GitBox <gi...@apache.org>.
prodigy91 commented on pull request #3076:
URL: https://github.com/apache/bookkeeper/pull/3076#issuecomment-1056878283
> Currently, this codebase is correct.
@nodece Does this mean this PR does not fix anything and the existing code is actually correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nodece commented on pull request #3076: Fix release the CompletionKey
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #3076:
URL: https://github.com/apache/bookkeeper/pull/3076#issuecomment-1056942389
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nodece commented on pull request #3076: Fix release the CompletionKey
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #3076:
URL: https://github.com/apache/bookkeeper/pull/3076#issuecomment-1056059894
Currently, this codebase is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org