You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2017/06/08 22:38:14 UTC
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7124
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
IMPALA-5470: Modernize links and instructions on download page
This switches from dist.apache.org to www.apache.org/dist for links
for the hashes and signatures. It also includes instructions for how
to check them.
Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
---
M downloads.html
1 file changed, 21 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/7124/1
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:
PS1, Line 189: SHA1
> I can add that. Could you also tell me how to do md5sum and sha512sum?
I found that the shasum tool verifies the sum of different formats automatically, so running "shasum --check $name.sha" would be ok for all SHA sums.
The md5 tool has no flag to verify sums from a file, so you have to run md5 $name.tar.gz and compare the result manually.
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
IMPALA-5470: Modernize links and instructions on download page
This switches from dist.apache.org to www.apache.org/dist for links
for the hashes and signatures. It also includes instructions for how
to check them.
Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Reviewed-on: http://gerrit.cloudera.org:8080/7124
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Jim Apple <jb...@apache.org>
---
M downloads.html
1 file changed, 33 insertions(+), 7 deletions(-)
Approvals:
Jim Apple: Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:
PS1, Line 189: SHA1
macOS doesn't ship these binaries. Instead it comes with a shasum binary, that takes the algorithm as a parameter. You would run "shasum -a256 -c checkSumFile". We don't support building or running Impala on macOS, but it may be helpful for people trying to verify the files on their physical hardware, and some developers use Macs.
Line 189: <li>To check a SHA1 sum, run <code>sha1sum --check
I think it can be a bit confusing that both sha sums use the same file extension. Do we have any control over how these files are named or do they have to end in .sha by convention?
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:
Line 189: <li>To check a SHA1 sum, run <code>sha1sum --check
> I think it can be a bit confusing that both sha sums use the same file exte
Agreed. Unfortunately, the sha1sums are already made and posted (2.7, 2.8, 2.9) and going forward the sha512 sums should follow the ASF release policy, which says to use ".sha".
PS1, Line 189: SHA1
> macOS doesn't ship these binaries. Instead it comes with a shasum binary, t
I can add that. Could you also tell me how to do md5sum and sha512sum?
Alternately, we could make this improvement in a follow-on patch, authored by someone who owns a mac.
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:
PS1, Line 189: SHA1
> I found that the shasum tool verifies the sum of different formats automati
Done
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
IMPALA-5470: Modernize links and instructions on download page
This switches from dist.apache.org to www.apache.org/dist for links
for the hashes and signatures. It also includes instructions for how
to check them.
Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
---
M downloads.html
1 file changed, 33 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/7124/2
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 2: Code-Review+2
This seems reasonably small to give a +2 myself.
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No