You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2013/11/24 21:12:10 UTC
Re: svn commit: r1544776 - in /commons/proper/lang/trunk/src:
changes/ test/java/org/apache/commons/lang3/builder/ test/java/org/apache/commons/lang3/math/
test/java/org/apache/commons/lang3/time/
Hi sebb,
2013/11/23 <se...@apache.org>
> Author: sebb
> Date: Sat Nov 23 12:25:48 2013
> New Revision: 1544776
>
> URL: http://svn.apache.org/r1544776
> Log:
> LANG-932 Spelling fixes
>
> Modified:
> commons/proper/lang/trunk/src/changes/changes.xml
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>
> Modified: commons/proper/lang/trunk/src/changes/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1544776&r1=1544775&r2=1544776&view=diff
>
> ==============================================================================
> --- commons/proper/lang/trunk/src/changes/changes.xml (original)
> +++ commons/proper/lang/trunk/src/changes/changes.xml Sat Nov 23 12:25:48
> 2013
> @@ -22,6 +22,7 @@
> <body>
>
> <release version="3.2" date="TBA" description="Next release">
> + <action issue="LANG-932" type="fix" dev="sebb" due-to="Ville
> Skyttä">Spelling fixes</action>
>
Wrong encoding of pom.xml?
> <action issue="LANG-931" type="update" dev="britter"
> due-to="Christoph Schneegans">Misleading Javadoc comment in
> StrBuilderReader class</action>
> <action issue="LANG-929" type="fix">OctalUnescaper tried to parse all
> of \279</action>
> <action issue="LANG-928" type="fix">OctalUnescaper had bugs when
> parsing octals starting with a zero</action>
>
> Modified:
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>
> ==============================================================================
> ---
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
> (original)
> +++
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
> Sat Nov 23 12:25:48 2013
> @@ -79,7 +79,7 @@ public class HashCodeBuilderAndEqualsBui
> *
> * @param lhs The Left-Hand-Side of the equals test
> * @param rhs The Right-Hand-Side of the equals test
> - * @param testTransients wether to test transient fields
> + * @param testTransients whether to test transient fields
> */
> private void assertEqualsAndHashCodeContract(final Object lhs, final
> Object rhs, final boolean testTransients) {
> if (EqualsBuilder.reflectionEquals(lhs, rhs, testTransients)) {
>
> Modified:
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>
> ==============================================================================
> ---
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
> (original)
> +++
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
> Sat Nov 23 12:25:48 2013
> @@ -284,7 +284,7 @@ public class NumberUtilsTest {
> }
>
> @Test(expected=NumberFormatException.class)
> - // Check that the code fails to create a valid number when preceeded
> by -- rather than -
> + // Check that the code fails to create a valid number when preceded
> by -- rather than -
> public void testCreateNumberFailure_1() {
> NumberUtils.createNumber("--1.1E-700F");
> }
>
> Modified:
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>
> ==============================================================================
> ---
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
> (original)
> +++
> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
> Sat Nov 23 12:25:48 2013
> @@ -506,7 +506,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setMonths(base, 12);
> - fail("DateUtils.setMonths did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setMonths did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
> @@ -528,7 +528,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setDays(base, 32);
> - fail("DateUtils.setDays did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setDays did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
> @@ -550,7 +550,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setHours(base, 24);
> - fail("DateUtils.setHours did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setHours did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
> @@ -572,7 +572,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setMinutes(base, 60);
> - fail("DateUtils.setMinutes did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setMinutes did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
> @@ -594,7 +594,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setSeconds(base, 60);
> - fail("DateUtils.setSeconds did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setSeconds did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
> @@ -616,7 +616,7 @@ public class DateUtilsTest {
>
> try {
> result = DateUtils.setMilliseconds(base, 1000);
> - fail("DateUtils.setMilliseconds did not throw an expected
> IllegalArguementException.");
> + fail("DateUtils.setMilliseconds did not throw an expected
> IllegalArgumentException.");
> } catch (final IllegalArgumentException e) {
>
> }
>
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1544776 - in /commons/proper/lang/trunk/src:
changes/ test/java/org/apache/commons/lang3/builder/ test/java/org/apache/commons/lang3/math/
test/java/org/apache/commons/lang3/time/
Posted by Benedikt Ritter <br...@apache.org>.
2013/11/24 Benedikt Ritter <br...@apache.org>
> Hi sebb,
>
>
> 2013/11/23 <se...@apache.org>
>
> Author: sebb
>> Date: Sat Nov 23 12:25:48 2013
>> New Revision: 1544776
>>
>> URL: http://svn.apache.org/r1544776
>> Log:
>> LANG-932 Spelling fixes
>>
>> Modified:
>> commons/proper/lang/trunk/src/changes/changes.xml
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>>
>> Modified: commons/proper/lang/trunk/src/changes/changes.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> --- commons/proper/lang/trunk/src/changes/changes.xml (original)
>> +++ commons/proper/lang/trunk/src/changes/changes.xml Sat Nov 23 12:25:48
>> 2013
>> @@ -22,6 +22,7 @@
>> <body>
>>
>> <release version="3.2" date="TBA" description="Next release">
>> + <action issue="LANG-932" type="fix" dev="sebb" due-to="Ville
>> Skyttä">Spelling fixes</action>
>>
>
> Wrong encoding of pom.xml?
>
I meant changes.xml of corse...
>
>
>> <action issue="LANG-931" type="update" dev="britter"
>> due-to="Christoph Schneegans">Misleading Javadoc comment in
>> StrBuilderReader class</action>
>> <action issue="LANG-929" type="fix">OctalUnescaper tried to parse
>> all of \279</action>
>> <action issue="LANG-928" type="fix">OctalUnescaper had bugs when
>> parsing octals starting with a zero</action>
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -79,7 +79,7 @@ public class HashCodeBuilderAndEqualsBui
>> *
>> * @param lhs The Left-Hand-Side of the equals test
>> * @param rhs The Right-Hand-Side of the equals test
>> - * @param testTransients wether to test transient fields
>> + * @param testTransients whether to test transient fields
>> */
>> private void assertEqualsAndHashCodeContract(final Object lhs, final
>> Object rhs, final boolean testTransients) {
>> if (EqualsBuilder.reflectionEquals(lhs, rhs, testTransients)) {
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -284,7 +284,7 @@ public class NumberUtilsTest {
>> }
>>
>> @Test(expected=NumberFormatException.class)
>> - // Check that the code fails to create a valid number when preceeded
>> by -- rather than -
>> + // Check that the code fails to create a valid number when preceded
>> by -- rather than -
>> public void testCreateNumberFailure_1() {
>> NumberUtils.createNumber("--1.1E-700F");
>> }
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -506,7 +506,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMonths(base, 12);
>> - fail("DateUtils.setMonths did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMonths did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -528,7 +528,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setDays(base, 32);
>> - fail("DateUtils.setDays did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setDays did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -550,7 +550,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setHours(base, 24);
>> - fail("DateUtils.setHours did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setHours did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -572,7 +572,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMinutes(base, 60);
>> - fail("DateUtils.setMinutes did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMinutes did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -594,7 +594,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setSeconds(base, 60);
>> - fail("DateUtils.setSeconds did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setSeconds did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -616,7 +616,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMilliseconds(base, 1000);
>> - fail("DateUtils.setMilliseconds did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMilliseconds did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>>
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: svn commit: r1544776 - in /commons/proper/lang/trunk/src:
changes/ test/java/org/apache/commons/lang3/builder/ test/java/org/apache/commons/lang3/math/
test/java/org/apache/commons/lang3/time/
Posted by sebb <se...@gmail.com>.
On 24 November 2013 20:12, Benedikt Ritter <br...@apache.org> wrote:
> Hi sebb,
>
>
> 2013/11/23 <se...@apache.org>
>
>> Author: sebb
>> Date: Sat Nov 23 12:25:48 2013
>> New Revision: 1544776
>>
>> URL: http://svn.apache.org/r1544776
>> Log:
>> LANG-932 Spelling fixes
>>
>> Modified:
>> commons/proper/lang/trunk/src/changes/changes.xml
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>>
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>>
>> Modified: commons/proper/lang/trunk/src/changes/changes.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> --- commons/proper/lang/trunk/src/changes/changes.xml (original)
>> +++ commons/proper/lang/trunk/src/changes/changes.xml Sat Nov 23 12:25:48
>> 2013
>> @@ -22,6 +22,7 @@
>> <body>
>>
>> <release version="3.2" date="TBA" description="Next release">
>> + <action issue="LANG-932" type="fix" dev="sebb" due-to="Ville
>> Skyttä">Spelling fixes</action>
>>
>
> Wrong encoding of pom.xml?
Not sure what the problem is here.
changes.xml should default to utf-8.
When I view the file as utf-8 the surname looks OK.
Also AFAICT the mail was sent as utf-8.
I'll try adding
svnmailer:content-charset utf-8
and see if that fixes it.
>
>> <action issue="LANG-931" type="update" dev="britter"
>> due-to="Christoph Schneegans">Misleading Javadoc comment in
>> StrBuilderReader class</action>
>> <action issue="LANG-929" type="fix">OctalUnescaper tried to parse all
>> of \279</action>
>> <action issue="LANG-928" type="fix">OctalUnescaper had bugs when
>> parsing octals starting with a zero</action>
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderAndEqualsBuilderTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -79,7 +79,7 @@ public class HashCodeBuilderAndEqualsBui
>> *
>> * @param lhs The Left-Hand-Side of the equals test
>> * @param rhs The Right-Hand-Side of the equals test
>> - * @param testTransients wether to test transient fields
>> + * @param testTransients whether to test transient fields
>> */
>> private void assertEqualsAndHashCodeContract(final Object lhs, final
>> Object rhs, final boolean testTransients) {
>> if (EqualsBuilder.reflectionEquals(lhs, rhs, testTransients)) {
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -284,7 +284,7 @@ public class NumberUtilsTest {
>> }
>>
>> @Test(expected=NumberFormatException.class)
>> - // Check that the code fails to create a valid number when preceeded
>> by -- rather than -
>> + // Check that the code fails to create a valid number when preceded
>> by -- rather than -
>> public void testCreateNumberFailure_1() {
>> NumberUtils.createNumber("--1.1E-700F");
>> }
>>
>> Modified:
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java?rev=1544776&r1=1544775&r2=1544776&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
>> Sat Nov 23 12:25:48 2013
>> @@ -506,7 +506,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMonths(base, 12);
>> - fail("DateUtils.setMonths did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMonths did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -528,7 +528,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setDays(base, 32);
>> - fail("DateUtils.setDays did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setDays did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -550,7 +550,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setHours(base, 24);
>> - fail("DateUtils.setHours did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setHours did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -572,7 +572,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMinutes(base, 60);
>> - fail("DateUtils.setMinutes did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMinutes did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -594,7 +594,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setSeconds(base, 60);
>> - fail("DateUtils.setSeconds did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setSeconds did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>> @@ -616,7 +616,7 @@ public class DateUtilsTest {
>>
>> try {
>> result = DateUtils.setMilliseconds(base, 1000);
>> - fail("DateUtils.setMilliseconds did not throw an expected
>> IllegalArguementException.");
>> + fail("DateUtils.setMilliseconds did not throw an expected
>> IllegalArgumentException.");
>> } catch (final IllegalArgumentException e) {
>>
>> }
>>
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org