You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2023/12/18 00:47:05 UTC

(superset) branch cleanup-telemetry-component created (now b0358b7212)

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a change to branch cleanup-telemetry-component
in repository https://gitbox.apache.org/repos/asf/superset.git


      at b0358b7212 chore(scarf): removing redundant rendering logic

This branch includes the following new commits:

     new b0358b7212 chore(scarf): removing redundant rendering logic

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: chore(scarf): removing redundant rendering logic

Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch cleanup-telemetry-component
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b0358b7212d1fc050a8c449e828326c4d1cae38f
Author: Evan Rusackas <ev...@rusackas.com>
AuthorDate: Sun Dec 17 17:46:56 2023 -0700

    chore(scarf): removing redundant rendering logic
---
 superset-frontend/src/components/TelemetryPixel/index.tsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset-frontend/src/components/TelemetryPixel/index.tsx b/superset-frontend/src/components/TelemetryPixel/index.tsx
index 6bfe1d20b9..6c7ce106e6 100644
--- a/superset-frontend/src/components/TelemetryPixel/index.tsx
+++ b/superset-frontend/src/components/TelemetryPixel/index.tsx
@@ -45,8 +45,7 @@ const TelemetryPixel = ({
   build = 'unknownBuild',
 }: TelemetryPixelProps): React.ReactElement | null => {
   const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`;
-  return process.env.SCARF_ANALYTICS === 'false' ||
-    process.env.SCARF_ANALYTICS === 'false' ? null : (
+  return process.env.SCARF_ANALYTICS === 'false' ? null : (
     <img
       referrerPolicy="no-referrer-when-downgrade"
       src={pixelPath}